Repository navigation
Conversation
|
Changes requested — not ready for Class-A qualification [P1] Correct the MP2307 power stage. The source uses R2 = 10 kΩ and R9 = 3.01 kΩ, which sets approximately 4.0 V with the MP2307’s 0.925 V feedback reference, not 3.3 V. That exceeds the STM32G030’s 3.6 V maximum and risks the connected sensors. The COMP network is also incorrect: C4 is connected between FB and COMP, with no COMP-to-GND compensation network. Please correct the divider and compensation topology against the MP2307 datasheet, then rerun voltage and ERC checks. [P1] Use correctly rated input protection. D2 is the registry part [P1] Apply the declared netclasses. POWER, VALVE, and I2C are declared but assigned to no nets, so the valve power paths and other critical signals are routed with default geometry rather than the stated widths and clearances. Apply the classes explicitly and rerun routing and DRC. [P1] Address the return-path failure. The README records 105 layer changes without a ground-return via within 1.53 mm on a two-layer board carrying switching valve currents, analog probe inputs, and I2C. This is a signal-integrity and EMI design problem, not just a limitation to document. Add ground stitching/return paths or justify a different stackup and rerun the board review. [P2] Bring the schematic and BOM to qualification quality. Twelve decoupling placements are reported far from their devices, a junction exceeds the readable wire limit, and the functional region boxes overlap. Correct the schematic layout rather than accepting these as limitations. Twenty parts also lack distributor identity, so the BOM is not orderable as presented. [P2] Complete reproducibility evidence. The README documents only one local export/router run. Add repeated artifact comparisons and independent PCB review evidence before treating this as Class-A qualification material. |
|
@SammyOina re your review: fixed divider, COMP, Q1/D1, TVS, netclasses, schematic. Still open: return-path vias (#280), BOM identities, independent review. Pushed in 5faa6c9. |
|
@SammyOina re BOM identities: those 14 registry parts are generic placeholders, so nobody picked a real orderable product for them. I didn't invent part numbers. |
|
@SammyOina re BOM identities: fixed. Every part now names a manufacturer number, LCSC where found; APDS-9301 has none. Per-value fuse and inductor added. Pushed in e9b3a4d. |
e9b3a4d to
74011e1
Compare
|
@SammyOina re your review: agent-made now. Return-path warnings 105→1, classes applied, regions disjoint, exports hash-match. Open: reset button, via sizes, BOM, TVS clamp. Pushed in 74011e1. |
JeffMboya
changed the title
JeffMboya
changed the title
…hored The final run of the Class A irrigation controller imported four parts from KiCad's symbols and authored four. Each carries the footprint_dimensions the registry requires, taken from its footprint's courtyard in the installed KiCad library: the importer and synth_author_part write none for four of them. header_1x5 is byte for byte the part the I2C sensor node's PR adds.
One prompt, one agent driving synth mcp, an empty workspace and an empty user registry. After its release export the agent compacted the layout with synth_compact_layout: seven attempts, each exported through the release gates, kept the tightest that routed (83.9 x 67.0 mm). The source and sidecar are the agent's; the README records what was measured on the exported files, KiCad 10.0.6 DRC (0 errors), every connector flush with the edge, and three exports into empty directories that match the agent's own.
82437dd to
b3e7348
Compare
What type of PR is this?
This is a feature.
What does this do?
Adds
qualification/class-a/irrigation-controller/: an 86-component, 83.9 x 67.0 mm board an agent produced and compacted, with its run.Which issue(s) does this PR fix/relate to?
Resolves #263, #260. Related Issue #39, #280.
Have you included tests for your changes?
No. The board is data; the README compares four exports, three from empty directories, by hash.
Did you document any new/modified feature?
Yes. The README gives measurements, open items and reproducibility;
agent-run/holds the prompt, resumes, calls and report.Notes
Stacked on #326 (eight parts). Needs #266 and Synth PRs #335, #337, #339, #341, #343, #345, #348, #350, #352.