Explicitly mark dependencies as keep for bracket-headers used.#365
Merged
maliberty merged 1 commit intoMay 26, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds comments to the BUILD file dependencies to prevent them from being removed by build tools. The reviewer suggested using the standard # keep directive instead of # build_cleaner keep to ensure better compatibility and conciseness across different Bazel dependency management tools.
hzeller
force-pushed
the
feature-20260525-keep-inc
branch
2 times, most recently
from
d153e67 to
362856d
Compare
This project uses bracket includes for dependencies that are actually vendored via the MODULE.bazel. So they should use `"zlib.h"`, `"tcl.h"` etc, but here they use `<zlib.h>`, `<tcl.h>` which makes them look like system headers. They are meant to be using the vendored headers, to explicitly tell build_cleaner (`bant`) that the dependencies should be kept. (ideally, we fix the includes, but since this is a fork, this might be harder to maintain). Also keeps `@openmp` for now, but see The-OpenROAD-Project#364 if this is actually needed. Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
force-pushed
the
feature-20260525-keep-inc
branch
from
362856d to
224907d
Compare
Contributor
Author
|
CC @maliberty |
maliberty
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This project uses bracket includes for dependencies that are actually vendored via the MODULE.bazel.
So they should use
"zlib.h","tcl.h"etc, but here they use<zlib.h>,<tcl.h>which makes them look like system headers.They are meant to be using the vendored headers, to explicitly tell build_cleaner (
bant) that the dependencies should be kept. (ideally, we fix the includes, but since this is a fork, this might be harder to maintain).Also keeps
@openmpfor now, but see #364 if this is actually needed.