Skip to content

Commit d153e67

Browse files
committed
Explicitly mark dependencies as keep for bracket-headers used.
This project uses bracket includes for dependencies that are actually vendored via the MODULE.bazel. So they should use `"zlib.h"`, `"tcl.h"` etc, but here they use `<zlib.h>`, `<tcl.h>` which makes them look like system headers. They are meant to be using the vendored headers, to explicitly tell build_cleaner (`bant`) that the dependencies should be kept. (ideally, we fix the includes, but since this is a fork, this might be harder to maintain). Also keeps `@openmp` for now, but see #364 if this is actually needed. Signed-off-by: Henner Zeller <h.zeller@acm.org>
1 parent 8575070 commit d153e67

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

BUILD

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -396,11 +396,11 @@ cc_library(
396396
visibility = ["//:__subpackages__"],
397397
deps = [
398398
"@cudd",
399-
"@eigen",
400-
"@openmp",
399+
"@eigen", # keep. Is used, but with <>-includes
400+
"@openmp", # keep. Is needed ? Nobody includes omp.h
401401
"@rules_flex//flex:current_flex_toolchain",
402-
"@tcl_lang//:tcl",
403-
"@zlib",
402+
"@tcl_lang//:tcl", # keep. Is used, but with <>-includes
403+
"@zlib", # keep. Is used, but with <>-includes
404404
],
405405
)
406406

0 commit comments

Comments
 (0)