Add a build-cleaner tool.#10531
Open
hzeller wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new bash script etc/run-build-cleaner.sh to run the bant build cleaner for optimizing dependencies in cc_libraries. Feedback on the script includes exporting the BAZEL variable so child processes can inherit it, quoting dirname "$0" to handle paths with spaces, and double-quoting the positional parameters "$@" to prevent word splitting and globbing issues.
Collaborator
Author
|
To use without annoyance
etc/run-build-cleaner.sh //src/cgt -vvv |
29278ad to
48d3bf5
Compare
This runs the depend-on-what-you-use command of bant https://github.com/hzeller/bant#dwyu--depend-on-what-you-use It should be possible to make new `cc_libraries()`, add a bunch of `srcs=[]` and i`hdrs=[]` to it, and have the build cleaner figure out all the dependencies needed, emitting an edit script to make it happen. Signed-off-by: Henner Zeller <h.zeller@acm.org>
48d3bf5 to
e0f5c67
Compare
Member
|
@dsengupta0628 should update STA later this week so let's hold this PR for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This runs the depend-on-what-you-use command of bant https://github.com/hzeller/bant#dwyu--depend-on-what-you-use
It should be possible to make new cc_libraries(), add a bunch of
srcs=[]iand ihdrs=[]ito it, and have bant figure out all the dependencies needed, emitting an edit script to make it happen.