Repository navigation
Conversation
…n links - Adding a transaction from a filtered list built its "Review transfers" and "Bills" links from the Cancel URL with ?account=…, so both were broken; they now use the Transactions path without the query. - Discard import, Remove budget, Unlink payment and Disconnect phone ran at once. A shared Confirm disclosure names the action, says what happens, and holds the "Confirm …" button. - The day panel's × asks "Remove?" on the same button before removing. - Transfers and Recurring show dates as "Jul 14, 2026", not ISO. - Bills and Budgets keep their status region mounted so the first result is announced. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Keep main's HO-120 and HO-121 entries, then this branch's HO-122. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx
Keeps it clear of the skip link and link rules the accessibility PR adds before body, so the two merge without a conflict. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx
This was referenced Oct 11, 2026
Keep main's HO-123 (#48), then this branch's HO-122. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
These are the behaviour findings from the UI audit (see #48 and #49).
/transactions/new?account=…) built "Review transfers" from the Cancel URL, giving…/transactions?account=…/transfers. The "Bills" link failed its/transactions$replace and pointed back at Transactions. A newtransactionsPath()helper drops the query for those links; Cancel still keeps the filter.Confirmcomponent (src/components/ui/confirm.tsx) works the way Recurring's existing "Remove tracking" does: a<details>that names the action, says what will happen, and holds the "Confirm …" button. It now guards:role="status"mounted (.live-region, which takes no space while empty), so the first message is read out.Feature / bug
Bug: transaction form links (F-04). Confirmations: F-05/F-06, F-09, F-12, F-24, bills
Governing ADRs
ADR-042 (no alarms or guilt copy; the confirmation text is neutral), ADR-046
Type
Definition of done (AGENTS.md section 8)
transaction-form.test.tsfortransactionsPath)pdf-import,bills,budgets,agent-linkandcalendar. The calendar test also checks that the first press removes nothing.transactions.spec.tschecks the hint links and Cancel on a filtered new transaction.storage-testscredentials this container doesn't have.Database
Security impact
None. No server actions changed; only the UI in front of them.
Screenshots
Not captured in this session.
🤖 Generated with Claude Code
https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx
Generated by Claude Code