Skip to content

fix(ui): confirm before deleting or disconnecting; fix new-transaction links - #50

Open
TahubCS wants to merge 5 commits into
mainfrom
fix/ui-confirmations
Open

TahubCS wants to merge 5 commits into
mainfrom
fix/ui-confirmations

Conversation

@TahubCS

@TahubCS TahubCS commented Oct 11, 2026

Copy link
Copy Markdown
Owner

Summary

These are the behaviour findings from the UI audit (see #48 and #49).

  • Bug: broken links. Adding a transaction from a filtered list (/transactions/new?account=…) built "Review transfers" from the Cancel URL, giving …/transactions?account=…/transfers. The "Bills" link failed its /transactions$ replace and pointed back at Transactions. A new transactionsPath() helper drops the query for those links; Cancel still keeps the filter.
  • Confirmations: a new shared Confirm component (src/components/ui/confirm.tsx) works the way Recurring's existing "Remove tracking" does: a <details> that names the action, says what will happen, and holds the "Confirm …" button. It now guards:
    • Import: Discard, which deletes the preview and its saved CSV
    • Budgets: Remove budget
    • Bills: Unlink payment
    • Settings: Disconnect (phone)
  • Day panel ×: the first press turns the same button into "Remove?" and the second press removes. Focus stays on the button, and moving away puts the × back.
  • Left as one click: Bills "Stop tracking bill" and "Dismiss pattern" and Recurring "Not recurring", because each already has a Restore.
  • Dates: Transfers showed raw ISO dates ("2026-07-14"), and Recurring showed the raw next date. Both now read "Jul 14, 2026".
  • Live regions: form results on Bills and Budgets were only announced if a status element already existed. They now keep an empty role="status" mounted (.live-region, which takes no space while empty), so the first message is read out.

Feature / bug

Bug: transaction form links (F-04). Confirmations: F-05/F-06, F-09, F-12, F-24, bills

Governing ADRs

ADR-042 (no alarms or guilt copy; the confirmation text is neutral), ADR-046

Type

  • feat
  • fix
  • refactor
  • test
  • docs
  • chore / ci

Definition of done (AGENTS.md section 8)

  • Follows every non-negotiable rule in AGENTS.md section 4
  • Vitest tests for domain logic, including edge cases (transaction-form.test.ts for transactionsPath)
  • Playwright test for the user-facing flow:
    • Every spec that clicked a now-confirmed action goes through the confirmation: pdf-import, bills, budgets, agent-link and calendar. The calendar test also checks that the first press removes nothing.
    • transactions.spec.ts checks the hint links and Cancel on a filtered new transaction.
  • Workspace isolation matrix updated if a new server action or route was added (none added)
  • Lint, typecheck, unit and E2E pass locally:
    • Lint, typecheck, format:check, docs:check and build pass.
    • Unit tests: 2705 pass. The 8 that fail need Neon storage-tests credentials this container doesn't have.
    • E2E is left to the author.
  • Docs updated; HANDOFF entry appended (HO-122)

Database

  • No schema change
  • Schema change with generated migration included (describe below)

Security impact

None. No server actions changed; only the UI in front of them.

Screenshots

Not captured in this session.

🤖 Generated with Claude Code

https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx


Generated by Claude Code

…n links

- Adding a transaction from a filtered list built its "Review transfers"
  and "Bills" links from the Cancel URL with ?account=…, so both were
  broken; they now use the Transactions path without the query.
- Discard import, Remove budget, Unlink payment and Disconnect phone ran
  at once. A shared Confirm disclosure names the action, says what
  happens, and holds the "Confirm …" button.
- The day panel's × asks "Remove?" on the same button before removing.
- Transfers and Recurring show dates as "Jul 14, 2026", not ISO.
- Bills and Budgets keep their status region mounted so the first result
  is announced.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx
@vercel

vercel Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
reeflect Ready Ready Preview Oct 11, 2026 2:47pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: TahubCS/Reeflect/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 825a0b5e-6b3d-4d22-86af-432176eb3e25

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T14:22:36.559946Z a846736 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Keep main's HO-120 and HO-121 entries, then this branch's HO-122.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx
Keeps it clear of the skip link and link rules the accessibility PR adds
before body, so the two merge without a conflict.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx
Keep main's HO-123 (#48), then this branch's HO-122.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx

@JacobGittHub JacobGittHub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

This branch was successfully deployed

1 active deployment
Preview — b3d70371 Deployed Oct 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants