Skip to content

fix(ui): one page frame, one title, readable fields on every page - #48

Merged
TahubCS merged 2 commits into
mainfrom
fix/ui-page-frame
Oct 11, 2026
Merged

TahubCS merged 2 commits into
mainfrom
fix/ui-page-frame

Conversation

@TahubCS

@TahubCS TahubCS commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

A UI audit (four review agents checking against AGENTS.md section 4 and the Vercel Web Interface Guidelines) found that pages looked like different apps. This PR fixes the CSS-only part.

  • Dark greys: cards, lines, tints and soft text are now neutral greys instead of blue-grey, matching the #0a0a0a header. This is the follow-up to fix(ui): give dark-mode pages the header's gridded night band #45, which merged before that commit was pushed.
  • Page frame:
    • New tokens: --gutter, --page-top, --page-narrow (48rem, lists and forms), --page-medium (60rem) and --page-wide (72rem, card grids).
    • Every page is left-aligned under the header, with the header's gutter.
    • Budgets had no side padding, so its text touched the screen edge on phones.
    • Bills and Recurring were centred at 86rem with a 1rem top padding.
  • Titles: the bare h1 rule, meant for the dashboard headline, applied to every page. It is now .hero h1. A new main h1 rule is the one page title style, and seven copies of that rule in feature modules are gone.
  • Fields: new --field-line token (#767676 light, #707070 dark) for input and select borders. These are 3:1 or better on every background (WCAG 1.4.11); the old --line borders were about 1.3:1.
  • Focus:
    • Per-page focus rings are removed, so the global one applies everywhere. They were green on Bills, purple on Budgets and Insights, with a 3px offset on Transfers.
    • The header tabs' focus ring is drawn inside the tab, because the sideways-scrolling row clipped it.
  • Controls:
    • --radius-control (8px) and --radius-card (12px) replace eight different corner values. This now includes the new summary panel from feat(summary): Gemini summary panel on the dashboard (F-15) #47.
    • Buttons on Bills, Recurring, Budgets and Transfers use the shared 0.5rem 1rem padding.
    • Every button has a hover state.
    • The selected Bills tab is filled with ink; it was 1.04:1 against the page.
    • The settings switch's blue literal shadow is gone.

Feature / bug

UI consistency (F-18 themes and accessibility)

Governing ADRs

ADR-046 (plain CSS, tokens in globals.css), ADR-042 (no colour-only signals)

Type

  • feat
  • fix
  • refactor
  • test
  • docs
  • chore / ci

Definition of done (AGENTS.md section 8)

  • Follows every non-negotiable rule in AGENTS.md section 4
  • Vitest tests for domain logic, including edge cases (no domain logic changed)
  • Playwright test for the user-facing flow (tests/e2e/app-nav.spec.ts):
    • Every page has the header's gutter and the same title size, with no sideways scroll at 360px and 1440px.
    • A field border is 3:1 against its card in both themes.
    • The dark greys are neutral.
  • Workspace isolation matrix updated if a new server action or route was added (none added)
  • Lint, typecheck, unit and E2E pass locally:
    • Lint, typecheck, format:check, docs:check and build pass.
    • Unit tests: 2702 pass. 8 fail only because this container has no Neon storage-tests credentials (TEST-05). scripts/db/verify.test.ts timed out once in the full run and passes on its own.
    • E2E is left to the author.
  • Docs updated; HANDOFF entry appended (HO-123; main had already taken HO-120 and HO-121)

Database

  • No schema change
  • Schema change with generated migration included (describe below)

Security impact

None. CSS, two className changes and an e2e test.

Screenshots

Not captured in this session. The committed screenshots in docs/screenshots/ regenerate when their specs run.

Merging with #49 and #50

All three are up to date with main. A trial merge of all three builds and passes lint, typecheck and docs:check. The only overlap is the end of docs/HANDOFF.md, where each PR appends its own entry, so the second and third to merge need main merged in again.

🤖 Generated with Claude Code

https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx

A UI audit found pages that looked like different apps:
- Dark greys were blue-grey next to the neutral header (left over from
  #45, which merged before that commit was pushed).
- Pages used six widths, some centred, and Budgets had no side padding
  (text touched the screen edge on phones).
- A bare h1 rule meant for the dashboard made Bills and Recurring titles
  3rem while others were 2.5rem.
- Input borders were about 1.3:1 against cards (WCAG 1.4.11 asks 3:1).
- Focus rings came in three colours, buttons in five shapes, with no
  hover states; the selected Bills tab was 1.04:1.

Tokens now carry the frame (--gutter, --page-top, --page-narrow/medium/
wide), field borders (--field-line) and corners (--radius-control,
--radius-card). Pages are left-aligned under the header, share one title
style, use the global focus ring, and every button has a hover state.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx
@vercel

vercel Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
reeflect Ready Ready Preview Oct 11, 2026 2:36pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: TahubCS/Reeflect/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: de6a31ba-2650-4778-a179-31fe57487da5

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T14:07:36.065398Z d2c9411 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

main took HO-120 and HO-121, so this branch's handoff entry is now
HO-123, after them. The new summary panel's corners use the
--radius-control token like every other module.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx
@TahubCS
TahubCS merged commit a435424 into main Oct 11, 2026
9 checks passed
TahubCS pushed a commit that referenced this pull request Oct 11, 2026
Keep main's HO-123 (#48), then this branch's HO-124.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx
TahubCS pushed a commit that referenced this pull request Oct 11, 2026
Keep main's HO-123 (#48), then this branch's HO-122.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx

This branch was successfully deployed

1 active deployment
Preview — 3d9a59c3 Deployed Oct 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants