Skip to content

fix(ui): calendar, header and phone accessibility fixes - #49

Open
TahubCS wants to merge 4 commits into
mainfrom
fix/ui-a11y
Open

TahubCS wants to merge 4 commits into
mainfrom
fix/ui-a11y

Conversation

@TahubCS

@TahubCS TahubCS commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

These are the accessibility findings from the same UI audit as #48.

  • Quiet days: with a filter on, days with nothing of that kind faded to opacity 0.35, which put their numbers at about 2:1 on buttons that still work. They now stay at full opacity in --ink-soft (7:1 or better).
  • Planning to cancel: a subscription the person plans to cancel was shown only as a strikethrough. The day cell's label (describeDay) and the list view now say "planning to cancel" in words, as ADR-042 requires for every visual state.
  • Day panel: it stuck at top: 1rem, under the sticky header. A new --header-h token keeps it below the header; it is never taller than the window and scrolls inside itself.
  • Phones (360px):
    • The three sums sat in about 100px columns, so a five-digit balance overlapped the next one. At 40rem and below, each sum is now a row.
    • The balance-line label now opens to the left once it's past the middle of the screen, so it no longer runs off the edge.
  • Skip link: "Skip to content" is the first Tab stop on every signed-in page.
  • Links: links without a class used the browser's default blue, which fails contrast on the dark background. They now take the surrounding text colour.

Feature / bug

Accessibility (F-18), calendar (F-12)

Governing ADRs

ADR-042 (text equivalent for every calendar state, no colour-only signals), ADR-046

Type

  • feat
  • fix
  • refactor
  • test
  • docs
  • chore / ci

Definition of done (AGENTS.md section 8)

  • Follows every non-negotiable rule in AGENTS.md section 4
  • Vitest tests for domain logic, including edge cases (month-grid.test.ts for describeDay)
  • Playwright test for the user-facing flow:
    • calendar.spec.ts checks quiet days, the cancel label, 360px with a five-digit balance, and the panel staying below the header.
    • New skip-link.spec.ts covers the skip link.
  • Workspace isolation matrix updated if a new server action or route was added (none added)
  • Lint, typecheck, unit and E2E pass locally:
    • Lint, typecheck, format:check, docs:check and build pass.
    • Unit tests: 2706 pass. The 8 that fail need Neon storage-tests credentials this container doesn't have (TEST-05).
    • E2E is left to the author.
  • Docs updated; HANDOFF entry appended (HO-124; main had already taken HO-120 and HO-121)

Database

  • No schema change
  • Schema change with generated migration included (describe below)

Security impact

None.

Screenshots

Not captured in this session.

Merging with #48 and #50

All three are up to date with main. I moved --header-h so this PR's globals.css changes no longer touch the lines #48 changes. A trial merge of all three builds and passes lint, typecheck and docs:check. The only overlap is the end of docs/HANDOFF.md, where each PR appends its own entry.

🤖 Generated with Claude Code

https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx

- Quiet calendar days (a filter is on, nothing of that kind) kept their
  buttons but faded to about 2:1; they now use the soft ink at full
  opacity.
- "Planning to cancel" was only a strikethrough; the day's label and the
  list view say it in words (ADR-042).
- The sticky day panel slid under the sticky header; it now sticks below
  it (--header-h) and scrolls inside itself.
- At 360px the three sums overlapped and the balance label ran off the
  screen; sums stack as rows and the label flips past the middle.
- A "Skip to content" link is the first Tab stop.
- Links without a class take the surrounding text colour instead of the
  browser's default blue.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx
@vercel

vercel Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
reeflect Ready Ready Preview Oct 11, 2026 2:46pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: TahubCS/Reeflect/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 70b17dce-5cb1-4f80-b838-0b5166efa0a8

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T14:13:21.260463Z 20eefdf PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

main took HO-120 and HO-121, so this branch's handoff entry is now
HO-124, after them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx
Keeps the token clear of the page-frame tokens added after --font-num in
the page-frame PR, so the two merge without a conflict.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx
Keep main's HO-123 (#48), then this branch's HO-124.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx

@JacobGittHub JacobGittHub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

This branch was successfully deployed

1 active deployment
Preview — 9d597188 Deployed Oct 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants