Skip to content

fix(deps): patch advisory overrides and remove vulnerable braces build dependency - #225

Open
sdcarlson wants to merge 5 commits into
mainfrom
deps/audit-fix
Open

sdcarlson wants to merge 5 commits into
mainfrom
deps/audit-fix

Conversation

@sdcarlson

@sdcarlson sdcarlson commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Dependency security blocks main and all open PRs on newly published advisories, preventing staging releases. This raises the existing undici, sharp, and source-map-js overrides to patched versions and removes the vulnerable braces dependency from Vinext's dynamic-import build path.

vite-plugin-dynamic-import@1.6.0 is patched in both ESM and CommonJS builds to use tinyglobby.globSync, which already exists in the dependency graph, instead of fast-glob.sync. A targeted package extension supplies tinyglobby and removes only that plugin's fast-glob dependency. No advisory suppression is added. The patch is pinned in the lockfile and should be removed when the upstream plugin adopts a safe glob implementation.

Validation on Node 24.21.0 and pnpm 11.19.0: frozen install, lint, typecheck, all 749 unit tests, and complete Vinext production build pass. Six ESM/CommonJS fixtures verify dynamic imports with explicit extensions, extension inference, directory index imports, nested imports, and hidden-file exclusion. pnpm audit --audit-level high passes with zero high/critical advisories and two remaining moderate findings. Deployment still uses the protected staging and production workflow with separate peer approval.

…ries

pnpm audit --audit-level high now fails on main (and every PR) for
GHSA-rfgv-xxqx-mfg5 and GHSA-w293-vg96-wgc3 (undici <7.29.1),
GHSA-wq5f-xc86-pv6w (sharp <0.35.5) and GHSA-68fv-2mgg-jv7q
(source-map-js <1.2.2), all transitive. Raise the existing overrides to
the first patched versions.

GHSA-vfj7-8cjw-p6xm (braces <=3.0.3, via vinext > vite-plugin-commonjs >
vite-plugin-dynamic-import > fast-glob > micromatch) has no patched
release, so the audit still reports one high advisory after this change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sdcarlson
sdcarlson requested a review from sykosyber as a code owner October 9, 2026 01:49
@sdcarlson
sdcarlson enabled auto-merge (squash) October 9, 2026 01:58
@sdcarlson sdcarlson changed the title deps: raise undici, sharp and source-map-js overrides past new advisories fix(deps): patch advisory overrides and remove vulnerable braces build dependency Oct 9, 2026
dependabot Bot and others added 3 commits October 21, 2026 05:16
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 8.3.0 to 8.3.3.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v8.3.3/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-version: 8.3.3
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
undici 7.29.1 (the previous override floor) is inside the vulnerable
range >=7.18.0 <7.30.1 of a high advisory published after this PR's
last CI run, so Dependency security fails again on a fresh audit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vite <=8.3.2 carries GHSA-587h-7wmj-h5pm (high). Neither this PR nor
#229 passes pnpm audit alone, so the vite bump lands here with the
override fixes. main only accepts squash merges, so #229 stays open
until Dependabot sees vite >=8.3.3 on main and closes it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sykosyber added a commit that referenced this pull request Oct 26, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

# Conflicts:
#	package.json
#	pnpm-lock.yaml
sykosyber added a commit that referenced this pull request Oct 26, 2026
Brings undici 7.30.1, sharp 0.35.5, source-map-js 1.2.2, vite 8.3.3 and
the braces removal so pnpm audit --audit-level high passes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sykosyber added a commit that referenced this pull request Oct 26, 2026
Brings undici 7.30.1, sharp 0.35.5, source-map-js 1.2.2, vite 8.3.3 and
the braces removal so pnpm audit --audit-level high passes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sykosyber

Copy link
Copy Markdown
Member

@sdcarlson, can you push the updated tip yourself? This PR is blocked until you do.

Since this ran green on Oct 9, two new high advisories have landed in main's graph:

A re-run of this head would fail Dependency security, and main is already red on that same job.

The fix is prepared as a fast-forward of a701cfd, on branch prep/deps/audit-fix (0a55809):

With these, pnpm audit --audit-level high reports 0 high/critical. 6 low/moderate findings remain, tracked in #16.

It has to be you who pushes it. The ruleset requires last-push approval, so if sykosyber pushes to your PR, nobody is left who can approve it.

git fetch origin prep/deps/audit-fix
git push origin origin/prep/deps/audit-fix:refs/heads/deps/audit-fix   # fast-forward

Once CI is green, sykosyber approves and squash-merges. That turns main's Dependency security green and unblocks the rest of the queue.

The prep/* branches for #209, #210, #212 and #215 each carry this updated #225 merge. That lets "Update branch" apply cleanly after this PR lands. Push them the same way, also as you, when it's their turn.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants