Skip to content

Reduce Relay to the supervised per-job workflow - #210

Open
sdcarlson wants to merge 6 commits into
mainfrom
codex/pilot-scope-simplification
Open

sdcarlson wants to merge 6 commits into
mainfrom
codex/pilot-scope-simplification

Conversation

@sdcarlson

Copy link
Copy Markdown
Contributor

Summary

Remove the internal agent runtime, planning, readiness scoring, and batch review paths. Keep Relay centered on per-job research and drafting, with human control over exact wording and consequential actions.

Checks

Local tests, lint, typecheck, build, public-copy checks, and browser tests passed. Four extension-browser cases remain unverified because Playwright Chromium could not start on Windows.

@sdcarlson
sdcarlson enabled auto-merge (squash) September 26, 2026 20:46

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

No actionable defects at 91689a26aa3d5fea53ce9cd03897df8d50909f9e.

Reviewed the current diff (main ff7e5aa...91689a2) and adjacent contracts for owner isolation, exact acceptance, stale writes, migration/rollback, gateway quotas, workflow permissions, and leftover paid-agent paths. The later ci.yml commit removes the deleted calibration matrix job, matching scripts/ci/run-integration.mjs; required status remains the aggregator CI check.

Inspected (static): schema/store (legacy tables kept, no DROP), GET/POST /api/outcomes (owner + version guards), deploy/security.mjs (plan-only weight removed; other routes still inherit the gateway), release config (no RELAY_AGENTS / OPENAI_API_KEY bindings), workspace accept/Inspect path, CLI stage/outcome (stale version still refused), agent-tool and connector leftovers (no remaining /api/drafts|plan|agents callers in TS/JS), workflow token (contents: read).

Not run: lint, typecheck, unit/integration/e2e, or any PR code. Human approval remains mandatory.

Open in Web View Automation 

Sent by Cursor Automation: RELAY pull request review

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

No actionable defects at 91689a26.

Independent re-review of the current head (main ff7e5aa...91689a2) after the prior assessment on this same SHA. Traced owner isolation, exact acceptance, stale writes, leftover paid-agent/planner routes, gateway quotas, schema/rollback, and workflow permissions.

Inspected (static only; tests not executed):

  • GET/POST /api/outcomes — getChatGPTUser plus owner=?; writes still version-match the job row and refuse on changes()=0.
  • Schema/store — legacy drafts/review_batches/choices/agent_*/refusals kept; no DROP.
  • Deleted /api/{agents,drafts,plan,preferences,readiness} — no remaining TS/JS callers; deploy/worker.mjs has no leftover Agents/planner path; remaining routes are workspace/applications/profile/outcomes.
  • deploy/security.mjs — plan-only weight removed; writes still reserve 10 work units; other routes inherit the gateway.
  • Workspace save still posts exact draft + version; Applications policy/Inspect UI remains; CLI is stage/context/brief/outcome/login.
  • ci.yml — contents: read; calibration dropped from the matrix to match run-integration.mjs; required status is still the aggregator CI job.
  • scripts/release/config.mjs — RELAY_AGENTS* bindings removed with the runtime.

Human approval remains mandatory.

Open in Web View Automation 

Sent by Cursor Automation: RELAY pull request review

@sykosyber

Copy link
Copy Markdown
Member

Left open. Updating onto current main conflicts. The cut is 117 files and still based on ff7e5aa0, before the design-system, credit, and release merges. Same-day relative to those merges. Needs a rebase. Not closed.

@sdcarlson
sdcarlson force-pushed the codex/pilot-scope-simplification branch from 91689a2 to 6379ca7 Compare October 9, 2026 01:47
sdcarlson and others added 3 commits October 8, 2026 18:49
…ries

pnpm audit --audit-level high now fails on main (and every PR) for
GHSA-rfgv-xxqx-mfg5 and GHSA-w293-vg96-wgc3 (undici <7.29.1),
GHSA-wq5f-xc86-pv6w (sharp <0.35.5) and GHSA-68fv-2mgg-jv7q
(source-map-js <1.2.2), all transitive. Raise the existing overrides to
the first patched versions.

GHSA-vfj7-8cjw-p6xm (braces <=3.0.3, via vinext > vite-plugin-commonjs >
vite-plugin-dynamic-import > fast-glob > micromatch) has no patched
release, so the audit still reports one high advisory after this change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sdcarlson
sdcarlson disabled auto-merge October 9, 2026 02:20

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No actionable defects at 04e3a00 (base 44905694).

Subsequent review after the Sept 26 assessments on 91689a26. Prior findings were none. This head rebases the cut onto current main and adds the undici/sharp/source-map-js overrides plus the vite-plugin-dynamic-import tinyglobby patch (merge 6379ca7 + a701cfd).

Inspected (static):

  • GET/POST /api/outcomes — getChatGPTUser plus owner=?; applications query is owner-bound; writes still version-match and refuse on changes()=0.
  • Schema/store — comments only on legacy drafts/review_batches/choices/agent_*/refusals; no DROP.
  • Deleted /api/{agents,drafts,plan,preferences,readiness} — no remaining TS/JS callers; CLI is stage/context/brief/outcome/login with version-bound stage/outcome.
  • Workspace save still posts exact draft + version; saveJobReview writes accepted_draft only for Ready; Inspect/policy remain on /applications.
  • deploy/security.mjs — plan-only weight removed; writes still reserve 10 work units; other routes inherit the gateway.
  • Release config — RELAY_AGENTS* / OPENAI_API_KEY bindings gone; Access, Turnstile, RELAY_PAUSE, artifact SHA remain.
  • ci.yml — contents: read; calibration dropped from the matrix to match run-integration.mjs; required status is still aggregator CI.

Not run: lint, typecheck, unit/integration/e2e, pnpm audit, or any PR code. Human approval remains mandatory.

Open in Web View Automation 

Sent by Cursor Automation: RELAY pull request review

@sykosyber

Copy link
Copy Markdown
Member

Blocked: the captain needs to choose between #215 and #210. Both PRs rewrite app/about/page.tsx and app/privacy/page.tsx: #210 changes the copy for the supervised-pilot scope, and #215 restyles the same pages for Atlas v2. Whichever merges second needs a manual resolve. I'm not picking one, because it's a product decision. Separately, this PR can't merge until #225 lands, and then it needs an update from prep/codex/pilot-scope-simplification, which has to be pushed by its author.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants