Skip to content

Re-express Relay design system in SyberLabs v2 (Atlas) - #215

Open
sdcarlson wants to merge 4 commits into
mainfrom
design/atlas-v2
Open

sdcarlson wants to merge 4 commits into
mainfrom
design/atlas-v2

Conversation

@sdcarlson

@sdcarlson sdcarlson commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

What changed

This PR is rebased onto #217, which applied design system v1. It keeps #217's structure, copy, --sy-* tokens and their aliases, self-hosted @fontsource fonts, app/lockup.tsx, skeleton loading, one-primary-per-screen rule and empty states, and re-expresses them in v2 (Atlas):

  • Tokens: v2 values. The page is ink #06051a with ink-2/ink-3 surfaces, text is vellum/mist/dim, hairlines are rgba, and status colours are live/warning/danger. --accent is the Relay accent #62e3d8. --signal and every focus ring use ice #90d8f0. Fields use radius 10; there are pill and panel radii, plus the solid gradient and glow tokens.
  • Buttons: .primary, .btn-primary and .application-primary are the gradient pill with a blue glow. .secondary, .btn, sheet filters, import tabs and badges are pills. The hard-coded #ffffff hovers and the veil rgba now use tokens.
  • Runtime bar is ink-2 at 74% with blur. The body gets the v2 starfield.
  • Lockup: the Relay sigil now follows "Relay" in Lockup. It is a static PNG rendered once by the kit.
  • Kit: the canonical kit, including its software-WebGL guard, is vendored unmodified in vendor/syber/ and lazy-loaded (separate chunks) by app/syber-atlas.tsx. It renders a still ambient exposure behind a heavy scrim on the first-job state and the about/privacy heroes, plus the 64px Relay sigil on first-job. The runtime workbench stays calm ink. Without fast WebGL2 (software renderers, CI), the kit hides the canvas and the CSS nebula shows instead.
  • Captcha page: inline v2 styles; the CSP is unchanged. The favicon uses v2 colours.
  • No duplicate font loading. Fonts come only from Apply the SyberLabs design system to Relay #217's @fontsource imports.

No class names, selectors, labels or product copy changed.

How verified

  • pnpm lint, pnpm typecheck, pnpm public-copy:check and pnpm build all pass.
  • pnpm test: 748/749 pass. The one failure is production-diagnostics process-group teardown, which fails identically on unmodified main in this sandbox and passes in CI.
  • Playwright add-job.spec.ts + workspace.spec.ts: 17/17 pass.
  • I captured screenshots at 1440×900 and 390×844 and reviewed them (stored locally): runtime (empty, first-job, selected job), tracker, applications, profile, about, privacy and captcha.

Migration / recovery

None. The change is CSS, static assets and presentational markup only.

🤖 Generated with Claude Code

https://claude.ai/code/session_014vkuqi5reSeZGWW7ywYhWq


Generated by Claude Code

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Review (head 3388923)

Scoped to the 17-file Atlas chrome reskin. Vendor kit is canvas/WebGL only (no fetch, storage, or credentials). Captcha verify, origin check, CSP, and Turnstile action are unchanged. No API, store, auth, migration, or workflow edits. Runtime-plant acceptance/import selectors and .review-col overflow contracts are intact.

Ran: tests/privacy-notice.test.mjs, tests/runtime-plant.test.mjs, tests/ui-copy.test.mjs — pass. Quality CI on this head is green.
Inspected, not executed here: tests/security.test.mjs (local env missing jose; Quality CI ran it). Browser e2e still pending.

One medium defect below. No auth, isolation, draft-acceptance, stale-write, migration, artifact-provenance, or workflow-permission defects found.

Human approval remains mandatory. This is not merge or deploy authority.

Open in Web View Automation 

Sent by Cursor Automation: RELAY pull request review

Comment thread app/about/page.tsx Resolved
Comment thread app/privacy/page.tsx Resolved

Copy link
Copy Markdown
Contributor Author

Addressed the Cursor findings on app/about/page.tsx and app/privacy/page.tsx in 941357d. AtlasAmbient now always mounts the kit's reduced-motion path, a single still exposure with no animation loop, on first-job, about and privacy, so no page runs the continuous 40k-particle loop.

Local verification on 3388923: lint, typecheck and public-copy passed. The full Playwright browser suite passed (operative 4/4, main 103/103), and after the still-exposure change on first-job, add-job.spec.ts passed 9/9 where 5 had timed out with the live plate.


Generated by Claude Code

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Review (head 941357d)

Delta from 3388923: AtlasAmbient always mounts the kit with reduced: true (one frame, no rAF loop). That fully addresses the prior About/Privacy live-plate findings. First-job now uses the same still path. Runtime bar pill padding on narrow screens is cosmetic.

Scoped to the 17-file Atlas chrome reskin. Vendor kit is canvas/WebGL only (no fetch, storage, or credentials). Captcha verifyToken, origin check, CSP, hostname, and data-action="relay_write" are unchanged. Gateway staticPath is unchanged (new lockup PNGs still go through usageGuard; no bypass). No API, store, auth, migration, or workflow edits. First-job submit/pending guards, privacy/about product copy, and runtime-plant acceptance/import / .review-col overflow contracts are intact. Overlay uses pointer-events: none and z-index: -1 inside isolation: isolate.

Ran: tests/privacy-notice.test.mjs, tests/runtime-plant.test.mjs, tests/ui-copy.test.mjs — 12/12 pass. Quality CI on this head is green.
Inspected, not executed here: tests/security.test.mjs (local env missing jose; Quality CI ran it). Integration (browser) was still pending at review time.

No new actionable defects. No auth, isolation, draft-acceptance, stale-write, migration, artifact-provenance, or workflow-permission defects found.

Human approval remains mandatory. This is not merge or deploy authority.

Open in Web View Automation 

Sent by Cursor Automation: RELAY pull request review

@sykosyber

Copy link
Copy Markdown
Member

Left open. This Atlas v2 branch is dirty against main after #217 (design system, squash 1cd67895). Same-day work, so I am not closing it. It needs a rebase onto that main.

@sdcarlson sdcarlson changed the title Re-skin Relay chrome to SyberLabs Design System v2 (Atlas) Re-express Relay design system in SyberLabs v2 (Atlas) Sep 27, 2026

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Review (head 92f203fe)

Rebase onto current main after #217. Prior About/Privacy live-plate findings stay fully addressed: AtlasAmbient always mounts the kit with reduced: true (one frame, no rAF loop) on first-job, about, and privacy.

Scoped to the 15-file Atlas chrome reskin. Vendor kit is canvas/WebGL only (no fetch, storage, cookies, or credentials). Captcha verifyToken, origin check, CSP, hostname, and data-action="relay_write" are unchanged (style + data-theme="dark" only). Gateway staticPath is unchanged; the new lockup PNG is a CSS url() sibling of the existing mark and still hashes into _next/static / assets. No API, store, auth, migration, or workflow edits. First-job submit/pending guards, privacy/about product copy, and runtime-plant acceptance/import / .review-col overflow contracts are intact. Overlay uses pointer-events: none and z-index: -1 inside isolation: isolate.

Ran: tests/privacy-notice.test.mjs, tests/runtime-plant.test.mjs, tests/ui-copy.test.mjs, tests/vite-config.test.mjs — pass. Quality CI on this head is green (lint/typecheck/unit/build). Integration api/cli/calibration/orchestration/production and CodeQL passed.
Inspected, not executed here: tests/security.test.mjs (local env missing jose; Quality CI ran it). Integration (browser) was still pending at review time.

No new actionable defects. No auth, isolation, draft-acceptance, stale-write, migration, artifact-provenance, or workflow-permission defects found.

Human approval remains mandatory. This is not merge or deploy authority.

Open in Web View Automation 

Sent by Cursor Automation: RELAY pull request review

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Review (head bbad378)

Delta since last review (92f203fe): merge of main only. Atlas files are unchanged. Prior About/Privacy live-plate findings stay fully addressed: AtlasAmbient still mounts the kit with reduced: true (one frame, no rAF loop) on first-job, about, and privacy.

Scoped to the 15-file Atlas chrome reskin. Vendor kit is canvas/WebGL only (no fetch, storage, cookies, or credentials). Captcha verifyToken, origin check, CSP, hostname, and data-action="relay_write" are unchanged (style + data-theme="dark" only). Gateway staticPath is unchanged; the lockup PNG is a CSS url() sibling of the existing mark and still hashes into _next/static / assets. No API, store, auth, migration, or workflow edits. First-job submit/pending guards, privacy/about product copy, and runtime-plant acceptance/import / .review-col overflow contracts are intact. Overlay uses pointer-events: none and z-index: -1 inside isolation: isolate.

Ran: tests/privacy-notice.test.mjs, tests/runtime-plant.test.mjs, tests/ui-copy.test.mjs, tests/vite-config.test.mjs — 13/13 pass. Quality CI on this head is green (lint/typecheck/unit/build). Integration api/cli/calibration/orchestration/production and CodeQL passed.
Inspected, not executed here: tests/security.test.mjs (local env missing jose / node_modules; Quality CI covered the related security suite). Integration (browser) was still pending at review time. Dependency security failed on this head; package.json / lockfile are main's merge and are not in this PR's unique diff.

No new actionable defects. No auth, isolation, draft-acceptance, stale-write, migration, artifact-provenance, or workflow-permission defects found.

Human approval remains mandatory. This is not merge or deploy authority.

Open in Web View Automation 

Sent by Cursor Automation: RELAY pull request review

Builds on #217: keeps its structure, copy, --sy-* tokens and aliases,
self-hosted @fontsource fonts, Lockup, skeleton loading, one-primary
rule and empty states, and changes the values and a few components:

- Tokens: v2 values (ink #06051a, ink-2/ink-3 surfaces, vellum/mist/dim
  text, rgba hairlines, live/warning/danger), Relay accent #62e3d8 for
  --accent, ice #90d8f0 for --signal and every focus ring, radius 10
  for fields, pill and panel radii, the solid gradient and glows.
- Buttons: .primary / .btn-primary / .application-primary become the
  gradient pill with a blue glow; .secondary, .btn, sheet filters,
  import tabs and badges become pills. Hard-coded #ffffff hovers and
  the veil rgba now use tokens.
- Runtime bar: ink-2 at 74% with blur. Body gets the v2 starfield.
- Lockup gains the Relay sigil (static PNG rendered once by the kit).
- The canonical kit (with its software-WebGL guard) is vendored
  unmodified in vendor/syber and lazy-loaded by app/syber-atlas.tsx: a
  still ambient exposure behind a heavy scrim on the first-job state and
  the about/privacy heroes, plus the 64px Relay sigil on first-job. The
  runtime workbench stays calm ink. Without fast WebGL2 the CSS nebula
  shows instead.
- Captcha page: inline v2 styles, CSP unchanged. Favicon in v2 colours.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014vkuqi5reSeZGWW7ywYhWq
…ries

pnpm audit --audit-level high now fails on main (and every PR) for
GHSA-rfgv-xxqx-mfg5 and GHSA-w293-vg96-wgc3 (undici <7.29.1),
GHSA-wq5f-xc86-pv6w (sharp <0.35.5) and GHSA-68fv-2mgg-jv7q
(source-map-js <1.2.2), all transitive. Raise the existing overrides to
the first patched versions.

GHSA-vfj7-8cjw-p6xm (braces <=3.0.3, via vinext > vite-plugin-commonjs >
vite-plugin-dynamic-import > fast-glob > micromatch) has no patched
release, so the audit still reports one high advisory after this change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sdcarlson
sdcarlson enabled auto-merge (squash) October 9, 2026 01:59
@sdcarlson
sdcarlson disabled auto-merge October 9, 2026 02:20

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review (head 48344708)

Delta since last review (bbad378): Atlas commit rewritten plus two lockfile commits — undici/sharp/source-map-js overrides, and braces removed by patching vite-plugin-dynamic-import@1.6.0 onto tinyglobby.

Prior About/Privacy live-plate findings stay fully addressed. AtlasAmbient always calls mount(..., { mode: 'ambient', reduced: true }) (app/syber-atlas.tsx line 18), so first-job, about, and privacy take one frame and do not start the rAF loop.

Scoped to Atlas chrome plus the lockfile/patch. Vendor kit is canvas/WebGL only (no fetch, storage, cookies, or credentials). Captcha verifyToken, origin check, CSP, hostname, and data-action="relay_write" are unchanged (style, data-theme="dark", wrapping <main> only). Gateway staticPath is unchanged; relay-sigil.png is a CSS url() sibling of the existing mark and still hashes into _next/static / assets. No API, store, auth, migration, or workflow edits. First-job submit/pending guards, privacy/about product copy, and runtime-plant acceptance/import / .review-col overflow contracts are intact. Overlay uses pointer-events: none and z-index: -1 inside isolation: isolate.

Ran: tests/privacy-notice.test.mjs, tests/runtime-plant.test.mjs, tests/ui-copy.test.mjs, tests/vite-config.test.mjs — 13/13 pass.
Inspected, not executed here: tests/security.test.mjs (local env has no jose / node_modules). Quality CI on this head is green (lint/typecheck/unit/build). Dependency security, CodeQL, and Integration api/cli/calibration/orchestration/production passed. Integration (browser) was still pending at review time.

No new actionable defects. No auth, isolation, draft-acceptance, stale-write, migration, artifact-provenance, or workflow-permission defects found.

Human approval remains mandatory. This is not merge or deploy authority.

Open in Web View Automation 

Sent by Cursor Automation: RELAY pull request review

@sykosyber

Copy link
Copy Markdown
Member

Blocked: the captain needs to choose between #215 and #210. Both PRs rewrite app/about/page.tsx and app/privacy/page.tsx: #210 changes the copy for the supervised-pilot scope, and #215 restyles the same pages for Atlas v2. Whichever merges second needs a manual resolve. I'm not picking one, because it's a product decision. Separately, this PR can't merge until #225 lands, and then it needs an update from prep/design/atlas-v2, which has to be pushed by its author.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants