Repository navigation
Conversation
There was a problem hiding this comment.
Stale comment
Review (head
3388923)Scoped to the 17-file Atlas chrome reskin. Vendor kit is canvas/WebGL only (no fetch, storage, or credentials). Captcha verify, origin check, CSP, and Turnstile action are unchanged. No API, store, auth, migration, or workflow edits. Runtime-plant acceptance/import selectors and
.review-coloverflow contracts are intact.Ran:
tests/privacy-notice.test.mjs,tests/runtime-plant.test.mjs,tests/ui-copy.test.mjs— pass. Quality CI on this head is green.
Inspected, not executed here:tests/security.test.mjs(local env missingjose; Quality CI ran it). Browser e2e still pending.One medium defect below. No auth, isolation, draft-acceptance, stale-write, migration, artifact-provenance, or workflow-permission defects found.
Human approval remains mandatory. This is not merge or deploy authority.
Sent by Cursor Automation: RELAY pull request review
|
Addressed the Cursor findings on Local verification on 3388923: lint, typecheck and public-copy passed. The full Playwright browser suite passed (operative 4/4, main 103/103), and after the still-exposure change on first-job, Generated by Claude Code |
There was a problem hiding this comment.
Stale comment
Review (head
941357d)Delta from
3388923:AtlasAmbientalways mounts the kit withreduced: true(one frame, no rAF loop). That fully addresses the prior About/Privacy live-plate findings. First-job now uses the same still path. Runtime bar pill padding on narrow screens is cosmetic.Scoped to the 17-file Atlas chrome reskin. Vendor kit is canvas/WebGL only (no
fetch, storage, or credentials). CaptchaverifyToken, origin check, CSP, hostname, anddata-action="relay_write"are unchanged. GatewaystaticPathis unchanged (new lockup PNGs still go throughusageGuard; no bypass). No API, store, auth, migration, or workflow edits. First-job submit/pending guards, privacy/about product copy, and runtime-plant acceptance/import /.review-coloverflow contracts are intact. Overlay usespointer-events: noneandz-index: -1insideisolation: isolate.Ran:
tests/privacy-notice.test.mjs,tests/runtime-plant.test.mjs,tests/ui-copy.test.mjs— 12/12 pass. Quality CI on this head is green.
Inspected, not executed here:tests/security.test.mjs(local env missingjose; Quality CI ran it). Integration (browser) was still pending at review time.No new actionable defects. No auth, isolation, draft-acceptance, stale-write, migration, artifact-provenance, or workflow-permission defects found.
Human approval remains mandatory. This is not merge or deploy authority.
Sent by Cursor Automation: RELAY pull request review
|
Left open. This Atlas v2 branch is dirty against main after #217 (design system, squash |
941357d to
92f203f
Compare
There was a problem hiding this comment.
Stale comment
Review (head
92f203fe)Rebase onto current
mainafter #217. Prior About/Privacy live-plate findings stay fully addressed:AtlasAmbientalways mounts the kit withreduced: true(one frame, no rAF loop) on first-job, about, and privacy.Scoped to the 15-file Atlas chrome reskin. Vendor kit is canvas/WebGL only (no
fetch, storage, cookies, or credentials). CaptchaverifyToken, origin check, CSP, hostname, anddata-action="relay_write"are unchanged (style +data-theme="dark"only). GatewaystaticPathis unchanged; the new lockup PNG is a CSSurl()sibling of the existing mark and still hashes into_next/static/assets. No API, store, auth, migration, or workflow edits. First-job submit/pending guards, privacy/about product copy, and runtime-plant acceptance/import /.review-coloverflow contracts are intact. Overlay usespointer-events: noneandz-index: -1insideisolation: isolate.Ran:
tests/privacy-notice.test.mjs,tests/runtime-plant.test.mjs,tests/ui-copy.test.mjs,tests/vite-config.test.mjs— pass. Quality CI on this head is green (lint/typecheck/unit/build). Integration api/cli/calibration/orchestration/production and CodeQL passed.
Inspected, not executed here:tests/security.test.mjs(local env missingjose; Quality CI ran it). Integration (browser) was still pending at review time.No new actionable defects. No auth, isolation, draft-acceptance, stale-write, migration, artifact-provenance, or workflow-permission defects found.
Human approval remains mandatory. This is not merge or deploy authority.
Sent by Cursor Automation: RELAY pull request review
There was a problem hiding this comment.
Stale comment
Review (head
bbad378)Delta since last review (
92f203fe): merge ofmainonly. Atlas files are unchanged. Prior About/Privacy live-plate findings stay fully addressed:AtlasAmbientstill mounts the kit withreduced: true(one frame, no rAF loop) on first-job, about, and privacy.Scoped to the 15-file Atlas chrome reskin. Vendor kit is canvas/WebGL only (no
fetch, storage, cookies, or credentials). CaptchaverifyToken, origin check, CSP, hostname, anddata-action="relay_write"are unchanged (style +data-theme="dark"only). GatewaystaticPathis unchanged; the lockup PNG is a CSSurl()sibling of the existing mark and still hashes into_next/static/assets. No API, store, auth, migration, or workflow edits. First-job submit/pending guards, privacy/about product copy, and runtime-plant acceptance/import /.review-coloverflow contracts are intact. Overlay usespointer-events: noneandz-index: -1insideisolation: isolate.Ran:
tests/privacy-notice.test.mjs,tests/runtime-plant.test.mjs,tests/ui-copy.test.mjs,tests/vite-config.test.mjs— 13/13 pass. Quality CI on this head is green (lint/typecheck/unit/build). Integration api/cli/calibration/orchestration/production and CodeQL passed.
Inspected, not executed here:tests/security.test.mjs(local env missingjose/node_modules; Quality CI covered the related security suite). Integration (browser) was still pending at review time. Dependency security failed on this head;package.json/ lockfile are main's merge and are not in this PR's unique diff.No new actionable defects. No auth, isolation, draft-acceptance, stale-write, migration, artifact-provenance, or workflow-permission defects found.
Human approval remains mandatory. This is not merge or deploy authority.
Sent by Cursor Automation: RELAY pull request review
Builds on #217: keeps its structure, copy, --sy-* tokens and aliases, self-hosted @fontsource fonts, Lockup, skeleton loading, one-primary rule and empty states, and changes the values and a few components: - Tokens: v2 values (ink #06051a, ink-2/ink-3 surfaces, vellum/mist/dim text, rgba hairlines, live/warning/danger), Relay accent #62e3d8 for --accent, ice #90d8f0 for --signal and every focus ring, radius 10 for fields, pill and panel radii, the solid gradient and glows. - Buttons: .primary / .btn-primary / .application-primary become the gradient pill with a blue glow; .secondary, .btn, sheet filters, import tabs and badges become pills. Hard-coded #ffffff hovers and the veil rgba now use tokens. - Runtime bar: ink-2 at 74% with blur. Body gets the v2 starfield. - Lockup gains the Relay sigil (static PNG rendered once by the kit). - The canonical kit (with its software-WebGL guard) is vendored unmodified in vendor/syber and lazy-loaded by app/syber-atlas.tsx: a still ambient exposure behind a heavy scrim on the first-job state and the about/privacy heroes, plus the 64px Relay sigil on first-job. The runtime workbench stays calm ink. Without fast WebGL2 the CSS nebula shows instead. - Captcha page: inline v2 styles, CSP unchanged. Favicon in v2 colours. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014vkuqi5reSeZGWW7ywYhWq
bbad378 to
48d0aeb
Compare
…ries pnpm audit --audit-level high now fails on main (and every PR) for GHSA-rfgv-xxqx-mfg5 and GHSA-w293-vg96-wgc3 (undici <7.29.1), GHSA-wq5f-xc86-pv6w (sharp <0.35.5) and GHSA-68fv-2mgg-jv7q (source-map-js <1.2.2), all transitive. Raise the existing overrides to the first patched versions. GHSA-vfj7-8cjw-p6xm (braces <=3.0.3, via vinext > vite-plugin-commonjs > vite-plugin-dynamic-import > fast-glob > micromatch) has no patched release, so the audit still reports one high advisory after this change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Review (head 48344708)
Delta since last review (bbad378): Atlas commit rewritten plus two lockfile commits — undici/sharp/source-map-js overrides, and braces removed by patching vite-plugin-dynamic-import@1.6.0 onto tinyglobby.
Prior About/Privacy live-plate findings stay fully addressed. AtlasAmbient always calls mount(..., { mode: 'ambient', reduced: true }) (app/syber-atlas.tsx line 18), so first-job, about, and privacy take one frame and do not start the rAF loop.
Scoped to Atlas chrome plus the lockfile/patch. Vendor kit is canvas/WebGL only (no fetch, storage, cookies, or credentials). Captcha verifyToken, origin check, CSP, hostname, and data-action="relay_write" are unchanged (style, data-theme="dark", wrapping <main> only). Gateway staticPath is unchanged; relay-sigil.png is a CSS url() sibling of the existing mark and still hashes into _next/static / assets. No API, store, auth, migration, or workflow edits. First-job submit/pending guards, privacy/about product copy, and runtime-plant acceptance/import / .review-col overflow contracts are intact. Overlay uses pointer-events: none and z-index: -1 inside isolation: isolate.
Ran: tests/privacy-notice.test.mjs, tests/runtime-plant.test.mjs, tests/ui-copy.test.mjs, tests/vite-config.test.mjs — 13/13 pass.
Inspected, not executed here: tests/security.test.mjs (local env has no jose / node_modules). Quality CI on this head is green (lint/typecheck/unit/build). Dependency security, CodeQL, and Integration api/cli/calibration/orchestration/production passed. Integration (browser) was still pending at review time.
No new actionable defects. No auth, isolation, draft-acceptance, stale-write, migration, artifact-provenance, or workflow-permission defects found.
Human approval remains mandatory. This is not merge or deploy authority.
Sent by Cursor Automation: RELAY pull request review
|
Blocked: the captain needs to choose between #215 and #210. Both PRs rewrite |


What changed
This PR is rebased onto #217, which applied design system v1. It keeps #217's structure, copy,
--sy-*tokens and their aliases, self-hosted@fontsourcefonts,app/lockup.tsx, skeleton loading, one-primary-per-screen rule and empty states, and re-expresses them in v2 (Atlas):#06051awith ink-2/ink-3 surfaces, text is vellum/mist/dim, hairlines are rgba, and status colours are live/warning/danger.--accentis the Relay accent#62e3d8.--signaland every focus ring use ice#90d8f0. Fields use radius 10; there are pill and panel radii, plus the solid gradient and glow tokens..primary,.btn-primaryand.application-primaryare the gradient pill with a blue glow..secondary,.btn, sheet filters, import tabs and badges are pills. The hard-coded#ffffffhovers and the veil rgba now use tokens.Lockup. It is a static PNG rendered once by the kit.vendor/syber/and lazy-loaded (separate chunks) byapp/syber-atlas.tsx. It renders a still ambient exposure behind a heavy scrim on the first-job state and the about/privacy heroes, plus the 64px Relay sigil on first-job. The runtime workbench stays calm ink. Without fast WebGL2 (software renderers, CI), the kit hides the canvas and the CSS nebula shows instead.@fontsourceimports.No class names, selectors, labels or product copy changed.
How verified
pnpm lint,pnpm typecheck,pnpm public-copy:checkandpnpm buildall pass.pnpm test: 748/749 pass. The one failure isproduction-diagnosticsprocess-group teardown, which fails identically on unmodifiedmainin this sandbox and passes in CI.add-job.spec.ts+workspace.spec.ts: 17/17 pass.Migration / recovery
None. The change is CSS, static assets and presentational markup only.
🤖 Generated with Claude Code
https://claude.ai/code/session_014vkuqi5reSeZGWW7ywYhWq
Generated by Claude Code