Repository navigation
Add researched context playbooks and a verified handoff exercise - #18
Conversation
There was a problem hiding this comment.
Stale comment
Review (docs-only)
No actionable defects on head
7303e65(still matchesrefs/pull/18/head). Documentation only: 9 Markdown files, no runtime, schema, migration, or workflow changes. Human approval remains mandatory.Relay-behavior claims that were checked against adjacent contracts match the current checkout:
- Packet shape and validation (
schema,job.key/job.version/job.url, nonemptyfacts, character limits) matchvalidatePacketinintegrations/connectors.mjs.- Claude path is a single Messages request, returns draft text only, and accepts only
end_turn— consistent withdraftClaudeand the playbook’s compaction-pause warning.- Exact-text acceptance, stale version reconciliation, imported Ready as evidence (not local acceptance), and “accepted ≠ submitted” match
REVIEW.md/ root README. Templates are explicitly notrelay.packet.v1imports and tell receivers not to rewrite identity/version to bypass a stale packet.- No OpenAI / Gemini / local-model connector; Grok Bot remains a command/file adapter, not xAI compaction.
Provider-doc spot-checks (opened pages, not live API calls) supported the named fields: OpenAI
context_management/compact_threshold//responses/compactand GPT-5.6 vs earlier cache controls; Claudecompact-2026-01-12/compact_20260112/pause_after_compaction; xAI/v1/responses/compactandchat.compact(); Gemini Interactions implicit vs Generate Content explicit caching (page updated 2026-09-02). Sampled source URLs resolved (including arXiv 2608.22752). Relative Markdown links in the changed files resolve.
AGENTS.mdanddocs/threat-model.mdare not in this repository. No prior review threads to reconcile.Ran:
git diff --staton2372771...7303e65; full read of the 9 changed files;validatePacket/draftClaudeanddb/schema.tsjob/acceptance fields; relative-link check;git ls-remotehead confirmation; selected official-doc fetches.Inspected only: existing
.github/workflows/grokcell.ymlpermissions (contents: read) — this PR does not touch workflows. Did not runpnpm test, apply migrations, or execute PR code.Sent by Cursor Automation: RELAY pull request review
There was a problem hiding this comment.
Stale comment
Review (subsequent push)
No actionable defects on head
a699662(still matchesrefs/pull/18/head). This push adds a fictional handoff fixture only. No runtime, schema, migration, or workflow files changed. The prior review on7303e65had no findings to re-check. Human approval remains mandatory.The new fixture matches the adjacent contracts I loaded:
packet.jsonpassesvalidatePacket:relay.packet.v1, nonempty facts (547 chars), integer version 4, andjobKey(url) === key. Extrajob.id/job.namematch the download shape inapp/connections.tsx. Seed jobs use differentexample.comkeys, so this identity does not collide.- The documented
grok-draftcommand matchesintegrations/relay.mjs: packet +draft.txt+ exclusive-create output, copiespacket.job, setsreviewRequired: true, and does not call a model.- For a
grok-botresult,draftFromResultaccepts only matchingjob.key+version+ URL identity and returns the exact trimmed sample paragraph. Version 5 or a different key is rejected. Packetdraftis empty;draft.txtis a separate reference; the checkpoint states no acceptance or submission. Relabeling a future version 5 packet is explicitly forbidden.- Relative Markdown links in the changed tree resolve (41 checked).
AGENTS.mdanddocs/threat-model.mdare not in this repository. No prior review threads to reconcile.Ran:
git ls-remotehead confirmation; full read of the 7-file delta; executedvalidatePacketandjobKeyon the example packet; relative-link check; contract read ofdraftFromResult,grok-draft, job/acceptance fields indb/schema.ts, and seed keys.Inspected only: first-commit docs (claims unchanged); existing
.github/workflows(untouched by this PR). Did not execute thegrok-draftCLI orpnpm test(this environment is Node 22 withoutnode_modules; the repo requires Node 24). Did not apply migrations or run PR code with secrets.Sent by Cursor Automation: RELAY pull request review
a699662 to
fc01c2b
Compare
There was a problem hiding this comment.
Review (subsequent push / rebase)
No actionable defects on head fc01c2ba1617bb29fbb3fcba49d0be2cc9666153 (still matches refs/pull/18/head). Documentation and a fictional fixture only: no runtime, schema, migration, or workflow files changed. Prior reviews on 7303e65 and a699662 had no findings to re-check. No prior inline threads. Human approval remains mandatory.
This head is a rewritten two-commit history onto e037ebf (CI/CD). The latest commit is the same fictional handoff exercise previously reviewed. Adjacent contracts still match:
packet.jsonpassesvalidatePacket:relay.packet.v1, nonempty facts (547 chars), integer version 4,jobKey(url) === key. Extrajob.id/job.namematch the download shape inapp/connections.tsx. Seed keys do not collide.- Documented
grok-draftargv matchesintegrations/relay.mjs: packet +draft.txt+ exclusive-create output, copiespacket.job, setsreviewRequired: true, no model call. - For a
grok-botresult,draftFromResultaccepts only matchingjob.key+version+ URL identity and returns the exact trimmed sample paragraph. Version 5 or a different key is rejected. Packetdraftis empty; checkpoint states no acceptance or submission. - Playbook claims remain scoped: Claude is one Messages call /
end_turn/ draft text only; no OpenAI, Gemini, or local-model connector; Grok Bot is a file adapter, not xAI compaction. Templates are notrelay.packet.v1imports. - Relative Markdown links in the changed tree resolve (44 checked).
AGENTS.md/docs/threat-model.mdare on the new base and were read; this PR does not weaken those controls.
Ran: git ls-remote head confirmation; full read of the 15-file PR and the 7-file latest-commit delta; executed real validatePacket + jobKey on the fixture; relative-link check; contract read of draftFromResult, grok-draft, job/acceptance fields, and seed keys.
Inspected only: existing .github/workflows (untouched; CI contents: read). Did not execute the grok-draft CLI or pnpm test (Node 22 here, no node_modules; repo requires Node 24). Did not apply migrations or run PR code with secrets.
Sent by Cursor Automation: RELAY pull request review
|
Merge cleanup inspected the failed Integration (production) job 101399741147 on fc01c2b, run 34001003131, including artifact 9979480944. The failure is scripts/ci/run-production.mjs:222: expected successful owner save 200, received 503. Artifact server log ends after the preceding intentional 403 origin rejection, without a logged successful save. This resembles the previously recorded #13 attempt-1 failure, but root cause is unconfirmed; the docs delta does not change runtime code. Keep the required check blocking until diagnosed or an explicitly recorded unchanged-head rerun passes; do not weaken the save assertion. I have not changed this approved PR head. |
<!-- CURSOR_AGENT_PR_BODY_BEGIN --> ## Problem and result Closes #8 Closes #9 Closes #19 `main` already includes protected CI/CD (#14), context playbooks (#18), session-expiry (#15 / #7), ChatGPT/Codex public-copy (#13), Apache 2.0 (#39 / #38), and tracker CSV (#11 / #17). This branch merges that tip and keeps the remaining unique trees: - Local-dev Node/port/sign-in, with a Windows-safe Node guard instead of Bash (#12 / #19) - Copy/paste draft handoffs, exact-acceptance actions, and dirty-navigation guards (#24) - Selected-job review history beyond the GET 200-event window (#8) - Assistant packets for valid jobs with `url: null` (#9) - Canonical public-copy listing for Tracker CSV (the #11 squash kept that note outside the maintained block) Head `4d8f007` merges `origin/main` (`256854b`, #11) into the previous landing. Conflict resolution kept `void test` wrappers, history/null-URL API coverage, and one Tracker CSV setup section. The changes-requested review is on superseded `9e307b9`. Independent preservation review of `8d6ba1a` retired the five original code findings. These merges do not restore them. Deferred, matching maintainer comments, and **not** in this PR: - Profile calibration loop (#26) - `shadcn` 4.20.1 (#32) - Production 503 diagnostics (#22 / draft #40) - Assistant research/next-task handoff (#37 / #41) — stacked on landed #13, not this consolidation - Unused UI-kit cut / competing review-loop draft (#42) Keep #16 open: remaining development-tool advisories. Keep #21 open until post-merge Pages verification. Keep #22 open. Cloudflare hosting (#3), two-account isolation (#4), recruiting (#5), backup rehearsal (#6), and Grok Bot VM command review (#20) still need human/environment work. ## Evidence - Local on `4d8f007`: `pnpm lint`, `pnpm typecheck`, `pnpm test` (98 passed), `pnpm public-copy:check`, `pnpm build`, `pnpm test:api`, `pnpm test:e2e` (6 passed), `pnpm test:production` passed. - GitHub CI on `4d8f007` ([run 34003847782](https://github.com/SyberLabs/relay/actions/runs/34003847782)): quality, API, browser, production, CodeQL, dependency-security, and bundled agent contracts were running or already green after this merge; required `CI` still needs the remaining jobs. - User-visible proof: copy/paste packet, Windows-safe `scripts/ensure-node.mjs`, Load earlier review history, null-URL packets. CSV import and ChatGPT/Codex prepare now come from `main`. - Security, data migration, and rollback impact: no new D1 migration. React trio stays at 19.2.8. CI Vinext still uses ephemeral ports when `RELAY_CI_STATE` is set. Production integration keeps the original request sequence. ## Review - [ ] One issue owns this scope; unrelated changes are separate. This is an explicit integration PR covering the remaining open merge train. - [x] Tests exercise the changed behavior, including failure paths (including compiled Workspace continuation and history-after-expiry regressions). - [x] No credentials, personal applications, or private research are included. - [x] Agent findings from the `9e307b9` review remain addressed. - [ ] A maintainer other than the author will approve. **@sdcarlson must approve the latest push** (`4d8f007`); prior reviews do not cover this merge commit. - [x] Public capabilities, integration limits and lead-engineer credit match `docs/public-copy.json`; run `pnpm public-copy:check` and follow `docs/PUBLIC-COPY.md` when these change. After merge, close the superseded feature PRs (#12, #24) as landed here rather than squash-merging them separately. #11, #13, #15, and #39 are already merged. #26 and #32 stay closed as deferred. #40, #41, and #42 stay on their own tracks. <!-- CURSOR_AGENT_PR_BODY_END --> <div><a href="https://cursor.com/agents/bc-3877d527-b5e4-46d7-8c5f-573418309ece?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a href="https://cursor.com/background-agent?bcId=bc-3877d527-b5e4-46d7-8c5f-573418309ece&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: sykosyber <sykosyber@users.noreply.github.com>


Relay needs a durable guide for handing job research and reviewed drafts between assistants without losing evidence, job identity, or acceptance state.
Adds 21 primary sources checked September 5, 2026; provider-specific playbooks; task/checkpoint templates; and twelve proposed model evaluation cases. A fictional native packet, evidence bundle, sample paragraph, and checkpoint make the first exercise concrete. Experimental research and API capabilities are distinguished from implemented Relay features.
Validation: all local Markdown links resolve; git diff whitespace checks pass; all 47 existing local tests pass. The real grok-draft file adapter preserved job identity and exact text, marked review required, and refused overwrite. The generated result passed matching-job validation and was rejected for stale and wrong-job targets.
No application source, dependencies, schema, or workflows changed. The example paragraph is manually authored. No model quality benchmark, paid provider call, browser journey, or submission was performed. The initial docs-only automated review found no actionable defects; the added example requires review on the latest head.