Repository navigation
Add ChatGPT and Codex draft handoffs and shared public-copy maintenance - #13
Conversation
Signed-off-by: Seth Carlson <66243744+sdcarlson@users.noreply.github.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
There was a problem hiding this comment.
Stale comment
Reviewed 1a29eb8 (base
2372771).AGENTS.mdanddocs/threat-model.mdare not in the tree. No prior automation threads to reconcile. The latest push only makes the public-copy XSS test case-insensitive; it does not change product behavior.Checked: selected-job packet export;
assistantResultkeeps Relay job identity/version (model fields discarded);draftFromResultbinds chatgpt/codex on id+key+version+url;applyLoadedDraftstill requires matching session/version/visible draft; CLI writes usewxand refuse existing outputs; Codex temp dir is mode-restricted and removed; workflows arecontents: read,persist-credentials: false, SHA-pinned; no migrations in this PR. Loading a handoff only stages editor text. Acceptance remains the explicit Ready save. Human approval is still required.Ran vs inspected: Inspected the PR diff plus adjacent
validatePacket,draftFromResult,applyLoadedDraft, and workspace save/accept. Reproduced the websitehrefsink with a localrender()call (no secrets, no PR scripts as a privileged job). Did not re-run the full suite or a browser handoff. CI oncdd00cawas green (Relay checks, CodeQL).One actionable defect below. Everything else in the handoff/acceptance path looked correctly fail-closed.
Sent by Cursor Automation: RELAY pull request review
Signed-off-by: Seth Carlson <66243744+sdcarlson@users.noreply.github.com>
There was a problem hiding this comment.
Stale comment
Reviewed f9062af (base
2372771).AGENTS.mdanddocs/threat-model.mdare still absent. Prior automation thread on websitehrefscheme checks is fully addressed.Fix verification:
render()now requiresrepositoryandleadProfileto behttps:URLs ongithub.comwith no credentials before buildingguide. The previous triggerrender({...copy, repository: 'javascript:alert(1)'}, 'website')throws. The same check rejectsdata:, non-GitHub hosts, and embedded userinfo. The new public-copy test covers those cases.Checked (delta + contracts): selected-job packet export;
assistantResultkeeps Relay job identity/version (model fields discarded);draftFromResultbinds chatgpt/codex on id+key+version+url;applyLoadedDraftstill requires matching session/version/visible draft; save/accept still needs an explicit Ready save (accepted_draftonly then); CLI writes usewxand refuse existing outputs; Codex temp dir is removed after use; workflows arecontents: read,persist-credentials: false, SHA-pinned; no migrations in this PR.Ran vs inspected: Inspected the latest push (
1a29eb8...f9062af) plus adjacentvalidatePacket,draftFromResult,applyLoadedDraft, and workspace save/accept. Re-rantests/public-copy.test.mjs(5 passed) and reproduced the oldjavascript:case plus host/credential rejects via localrender()(no secrets, no privileged PR-script job). Did not re-run the full suite or a browser ChatGPT handoff. CI on this head is green (Relay checks, CodeQL).No new actionable defects. Human approval remains mandatory.
Sent by Cursor Automation: RELAY pull request review
Signed-off-by: Seth Carlson <66243744+sdcarlson@users.noreply.github.com>
There was a problem hiding this comment.
Stale comment
Reviewed 9e7ee29 (base
2372771).AGENTS.mdanddocs/threat-model.mdare present. Prior automation thread on websitehrefscheme checks remains fully addressed.This push integrates protected delivery and identity (#14), adds assistant browser journeys, and names the canonical CI public-copy gate. Handoff/acceptance contracts are unchanged from
f9062af.Fix verification:
render()still requiresrepositoryandleadProfileto be credential-lesshttps:URLs ongithub.combefore buildingguide. Localrender({...copy, repository: 'javascript:alert(1)'}, 'website')throws. The same check rejectsdata:, non-GitHub hosts, and embedded userinfo.Checked (delta + contracts):
- Access JWT is RS256 with issuer/audience/exp/iat; incoming
oai-*and Access client headers are stripped; workspace requires humansub+ email; service tokens may call/readyzonly.- Gateway authenticates before
ASSETSor the app.workers.devand preview URLs are off;run_worker_firstis on. The test JWKS fixture is not in the release artifact.- Release accepts only a successful
ci.ymlpush on this repository'smain; artifact SHA and file checksums must match; a newer main commit is refused. Rollback needs prior successfulrelay-releaseevidence and identicaldrizzle/vs current main; it does not apply migrations.- Workflows use
contents: read(plus scoped deploy/security writes),persist-credentials: false, and SHA-pinned actions. PR jobs do not receive deploy secrets. No database migration is in this PR.- Selected-job packet export;
assistantResultkeeps Relay job identity/version;draftFromResultbinds chatgpt/codex on id+key+version+url;applyLoadedDraftstill requires matching session/version/visible draft. Loading only stages editor text. Acceptance remains an explicit Ready save. CLI writes usewx.Ran vs inspected: Inspected
f9062af...9e7ee29plus adjacentaccess/handler/release scripts,validatePacket,draftFromResult, andapplyLoadedDraft. Re-rantests/public-copy.test.mjs(5 passed) and reproduced the URL rejects via localrender()(no secrets, no privileged PR-script job). Did not re-run the full suite or a signed-in ChatGPT conversation. CI on this head is green (Quality, api/browser/production integration, dependencies, templates, CodeQL, required CI).No new actionable defects. Human approval remains mandatory.
Sent by Cursor Automation: RELAY pull request review
|
Reconciled this branch with merged #14 using a merge commit, preserving the public-copy CI check, peer-reviewed workflow/test changes and current dependencies. The only tree change is retaining main README documentation; canonical public-copy validation passes. Prior runtime test results remain applicable to the unchanged application tree; fresh hosted CI now runs against current main. Still requires @sykosyber approval. Keep #21 open for post-merge external-copy verification. |
There was a problem hiding this comment.
Stale comment
Reviewed d749011 (base
e037ebf).AGENTS.mdanddocs/threat-model.mdare present. Prior automation thread on websitehrefscheme checks remains fully addressed.This push merges current
main(#14) then drops a duplicated development-workflow README line. The resulting tree is identical to last-reviewed 9e7ee29 (860ebb9). No application, workflow, or contract files changed.Fix verification:
render()still requiresrepositoryandleadProfileto be credential-lesshttps:URLs ongithub.combefore buildingguide. Localrender({...copy, repository: 'javascript:alert(1)'}, 'website')throws. The same check rejectsdata:, non-GitHub hosts, and embedded userinfo.Checked (delta + unchanged contracts):
- Selected-job packet export;
assistantResultkeeps Relay job identity/version (model fields discarded);draftFromResultbinds chatgpt/codex on id+key+version+url;applyLoadedDraftstill requires matching session/version/visible draft. Loading only stages editor text. Acceptance remains an explicit Ready save (accepted_draftonly then).- CLI writes use
wxand refuse existing outputs; Codex temp dir is removed after use.- Workflows vs main add only
pnpm public-copy:checkto the quality job. Jobs staycontents: read(plus scoped deploy/security writes),persist-credentials: false, SHA-pinned. No database migration in this PR.Ran vs inspected: Inspected
9e7ee29...d749011(empty tree delta after the README duplicate revert) plus adjacentvalidatePacket,draftFromResult,applyLoadedDraft, and workspace save/accept. Re-rantests/public-copy.test.mjs(5 passed) and reproduced the URL rejects via localrender()(no secrets, no privileged PR-script job). Did not re-run the full suite or a signed-in ChatGPT conversation. Hosted CI on this head was still in progress at review time (Quality, browser, CodeQL pending; api/production/templates/dependencies already green). Prior head9e7ee29with this same tree was green.No new actionable defects. Human approval remains mandatory.
Sent by Cursor Automation: RELAY pull request review
There was a problem hiding this comment.
Stale comment
Reviewed da35222 (base
e0f69c9).AGENTS.mdanddocs/threat-model.mdare present. Prior automation thread on websitehrefscheme checks remains fully addressed.This push merges current
main(#18) into the handoff branch. Versus last-reviewed d749011, application, workflow, and contract files are unchanged. The tree delta is the #18context-management/docs plus a README sentence linking to them. The merge kept the public-copy markers, ChatGPT/Codex sections, and a single development-workflow line.Fix verification:
render()still requiresrepositoryandleadProfileto be credential-lesshttps:URLs ongithub.combefore buildingguide. Localrender({...copy, repository: 'javascript:alert(1)'}, 'website')throws. The same check rejectsdata:, non-GitHub hosts, and embedded userinfo.Checked (delta + unchanged contracts):
- Selected-job packet export;
assistantResultkeeps Relay job identity/version;draftFromResultbinds chatgpt/codex on id+key+version+url;applyLoadedDraftstill requires matching session/version/visible draft. Loading only stages editor text. Acceptance remains an explicit Ready save.- CLI writes use
wxand refuse existing outputs; Codex temp dir is removed after use.- Workflows vs main add only
pnpm public-copy:checkto the quality job. Jobs staycontents: read(plus scoped deploy/security writes),persist-credentials: false, SHA-pinned. No database migration in this PR.Ran vs inspected: Inspected
d749011...da35222(README + context-management only) plus adjacentvalidatePacket,draftFromResult,applyLoadedDraft, and workspace save/accept. Re-rantests/public-copy.test.mjs(5 passed) and reproduced the URL rejects via localrender()(no secrets, no privileged PR-script job). Did not re-run the full suite or a signed-in ChatGPT conversation. Hosted CI on this head: Quality (includespublic-copy:check), api/production integration, dependencies, and CodeQL are green; browser integration and Security/CodeQL were still pending at review time.No new actionable defects. Human approval remains mandatory.
Sent by Cursor Automation: RELAY pull request review
|
Final cleanup gate on da35222: every hosted check and automatic review passed. An actual squash-merge attempt was rejected by GitHub: waiting on code owner review from sykosyber. Requested that review; no bypass or rule change was made. This PR is otherwise ready against main e0f69c9. Public-copy owner retains #21 post-merge verification. |
sykosyber
left a comment
There was a problem hiding this comment.
Partner Extra High review of da35222a573852ecae50108fafe57daae64ce71b.
Prior website href finding is addressed: render() requires repository and leadProfile to be credential-less https: URLs on github.com before building guide. Selected-job packet export strips extra fields. assistantResult keeps Relay job identity/version (reviewRequired: true; model fields discarded). draftFromResult binds chatgpt/codex on id+key+version+url. Loading stages editor text only; acceptance remains an explicit Ready save. Codex temp dir is mode 0600 and removed; CLI writes use wx. Workflows add pnpm public-copy:check to the quality job and stay contents: read on PRs. No database migration.
Required CI is green on this head. Keep #21 open until post-merge external copy/Pages verification. This approval is for this commit only and does not merge or deploy.
|
Updated against main 431b207 after PR15 merged, preserving the approved handoff delta and incorporating the landed session protections. New head 8beb207. Typecheck and all 77 unit tests passed. Fresh hosted checks requested automatically; please renew latest-head approval after they pass. #21 remains open for external verification. |
There was a problem hiding this comment.
Reviewed 8beb207 (base 431b207). AGENTS.md and docs/threat-model.md are present. Prior automation thread on website href scheme checks remains fully addressed.
This push merges current main (#15 stale-refresh / 401 expiry) into the handoff branch. Versus last-reviewed da35222, the unique PR tree is unchanged. Application, workflow, and contract files added by this PR are the same 21-file set; the merge did not rewrite handoff or public-copy code.
Fix verification: render() still requires repository and leadProfile to be credential-less https: URLs on github.com before building guide. Local render({...copy, repository: 'javascript:alert(1)'}, 'website') throws. The same check rejects data:, non-GitHub hosts, and embedded userinfo.
Checked (delta + unchanged contracts):
- Selected-job packet export;
assistantResultkeeps Relay job identity/version;draftFromResultbinds chatgpt/codex on id+key+version+url;applyLoadedDraftstill requires matching session/version/visible draft. Loading only stages editor text. Acceptance remains an explicit Ready save. - Merged refresh (
editorForJobs/reconcileEditor) keeps a same-version loaded draft and marks conflict when the server version moves under a dirty editor; it does not accept or reset application state. - CLI writes use
wxand refuse existing outputs; Codex temp dir is removed after use. - Workflows vs main add only
pnpm public-copy:checkto the quality job. Jobs staycontents: read(plus scoped deploy/security writes),persist-credentials: false, SHA-pinned. No database migration in this PR.
Ran vs inspected: Inspected da35222...8beb207 (merge of #15 only) plus adjacent validatePacket, draftFromResult, applyLoadedDraft, and workspace save/accept. Re-ran tests/public-copy.test.mjs (5 passed) and reproduced the URL rejects via local render() (no secrets, no privileged PR-script job). Did not re-run the full local suite or a signed-in ChatGPT conversation. Hosted CI on this head: Quality (includes public-copy:check), api/browser integration, dependencies, templates, and CodeQL are green. Production integration failed at scripts/ci/run-production.mjs:222 with 503 !== 200 on the first-owner save after the untrusted-origin 403 succeeded; the worker log has no matching POST. That path is unchanged by this PR’s unique files and passed on da35222; treated as a local-wrangler flake, not a handoff/acceptance defect.
No new actionable defects. Human approval remains mandatory.
Sent by Cursor Automation: RELAY pull request review
Keep remaining unique trees (tracker CSV, local-dev Node guard, copy/paste handoffs, selected-job history, and null-URL packets) on top of the landed ChatGPT/Codex public-copy and Apache 2.0 license. Restore the ChatGPT wording spacing from main. Co-authored-by: sykosyber <sykosyber@users.noreply.github.com>
<!-- CURSOR_AGENT_PR_BODY_BEGIN --> ## Problem and result Closes #8 Closes #9 Closes #19 `main` already includes protected CI/CD (#14), context playbooks (#18), session-expiry (#15 / #7), ChatGPT/Codex public-copy (#13), Apache 2.0 (#39 / #38), and tracker CSV (#11 / #17). This branch merges that tip and keeps the remaining unique trees: - Local-dev Node/port/sign-in, with a Windows-safe Node guard instead of Bash (#12 / #19) - Copy/paste draft handoffs, exact-acceptance actions, and dirty-navigation guards (#24) - Selected-job review history beyond the GET 200-event window (#8) - Assistant packets for valid jobs with `url: null` (#9) - Canonical public-copy listing for Tracker CSV (the #11 squash kept that note outside the maintained block) Head `4d8f007` merges `origin/main` (`256854b`, #11) into the previous landing. Conflict resolution kept `void test` wrappers, history/null-URL API coverage, and one Tracker CSV setup section. The changes-requested review is on superseded `9e307b9`. Independent preservation review of `8d6ba1a` retired the five original code findings. These merges do not restore them. Deferred, matching maintainer comments, and **not** in this PR: - Profile calibration loop (#26) - `shadcn` 4.20.1 (#32) - Production 503 diagnostics (#22 / draft #40) - Assistant research/next-task handoff (#37 / #41) — stacked on landed #13, not this consolidation - Unused UI-kit cut / competing review-loop draft (#42) Keep #16 open: remaining development-tool advisories. Keep #21 open until post-merge Pages verification. Keep #22 open. Cloudflare hosting (#3), two-account isolation (#4), recruiting (#5), backup rehearsal (#6), and Grok Bot VM command review (#20) still need human/environment work. ## Evidence - Local on `4d8f007`: `pnpm lint`, `pnpm typecheck`, `pnpm test` (98 passed), `pnpm public-copy:check`, `pnpm build`, `pnpm test:api`, `pnpm test:e2e` (6 passed), `pnpm test:production` passed. - GitHub CI on `4d8f007` ([run 34003847782](https://github.com/SyberLabs/relay/actions/runs/34003847782)): quality, API, browser, production, CodeQL, dependency-security, and bundled agent contracts were running or already green after this merge; required `CI` still needs the remaining jobs. - User-visible proof: copy/paste packet, Windows-safe `scripts/ensure-node.mjs`, Load earlier review history, null-URL packets. CSV import and ChatGPT/Codex prepare now come from `main`. - Security, data migration, and rollback impact: no new D1 migration. React trio stays at 19.2.8. CI Vinext still uses ephemeral ports when `RELAY_CI_STATE` is set. Production integration keeps the original request sequence. ## Review - [ ] One issue owns this scope; unrelated changes are separate. This is an explicit integration PR covering the remaining open merge train. - [x] Tests exercise the changed behavior, including failure paths (including compiled Workspace continuation and history-after-expiry regressions). - [x] No credentials, personal applications, or private research are included. - [x] Agent findings from the `9e307b9` review remain addressed. - [ ] A maintainer other than the author will approve. **@sdcarlson must approve the latest push** (`4d8f007`); prior reviews do not cover this merge commit. - [x] Public capabilities, integration limits and lead-engineer credit match `docs/public-copy.json`; run `pnpm public-copy:check` and follow `docs/PUBLIC-COPY.md` when these change. After merge, close the superseded feature PRs (#12, #24) as landed here rather than squash-merging them separately. #11, #13, #15, and #39 are already merged. #26 and #32 stay closed as deferred. #40, #41, and #42 stay on their own tracks. <!-- CURSOR_AGENT_PR_BODY_END --> <div><a href="https://cursor.com/agents/bc-3877d527-b5e4-46d7-8c5f-573418309ece?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a href="https://cursor.com/background-agent?bcId=bc-3877d527-b5e4-46d7-8c5f-573418309ece&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: sykosyber <sykosyber@users.noreply.github.com>
Closes #37. Users can now select and edit one job's research and specify the next drafting task inside the existing Prepare for ChatGPT/Codex downloads. Research stays separate from candidate facts, optional fields clear on job changes, oversized context is rejected, and returned drafts retain explicit review and stale-version checks. No migration, dependencies, provider service, or submission behavior changes. Reconciled onto current main007e0ae after #13, #36 and #42 merged. Canonical copy/paste, exact editor checks, selected-job packet creation and history remain intact. Production remains blocked by owner setup in #3 and the normal staging/peer production approval gates. Validation: lint, typecheck, 99 unit tests, public-copy check, build, API suite, all 6 Chromium journeys (context returns by paste and file), and compiled production/gateway smoke passed locally. High-severity dependency audit passed; inherited development-tool esbuild advisories remain (one moderate via drizzle-kit, one low via Wrangler), with no dependency changes in this PR. A fictional two-model smoke trial ran one history/focused/checkpoint condition each for gpt-5.4-mini and gpt-5.5. All six used supported facts without invented qualifications or submission claims. One draft included an internal review note; a prompt refinement and one repeat corrected it. The committed report records limitations: not blinded, no repeated benchmark, no model ranking/cost claim, and no native compaction test. Recovery: revert this UI/prompt change; stored job data and packet schemas are unchanged. Real-user validation remains separate from these fictional checks. Latest headfe73858 is rebased onto main007e0ae with an unchanged context diff. Local lint/types/99 unit tests/build pass; fresh integration and hosted checks are running. Earlier production503 evidence remains in #22; this change does not claim a fix. Final peer approval and green current-head CI are required.


Users can prepare wording in ChatGPT or their signed-in Codex CLI, then return it to the selected RELAY job for explicit review. Adds prompt downloads, local prompt/draft packaging and
codex-run; returned drafts remain tied to job identity/version and never grant acceptance or send an application. Seth Carlson is correctly credited as lead engineer.Public descriptions now have one canonical file, guarded section rendering and a required CI check. The project, organization and Seth profile READMEs plus syberlabs.space share maintained RELAY copy. External pages currently show the accurate awaiting-review state; their installed 15-minute workflows begin rendering from main after this merges, preserving unrelated content and explicitly rebuilding GitHub Pages.
Dependency: Merge #14 first. This branch integrates its stable aa3f2f4 foundation, retains canonical CI/security/dependency updates, removes the temporary duplicate CI/CodeQL workflows and folds public-copy validation into the canonical quality job. Related owner ticket: #21; keep it open until post-merge external sync and Pages verification complete.
Validation on the combined branch:
Limitations: The signed-in ChatGPT conversation was not exercised; its browser return test uses a fixture. This is an explicit local prompt/file integration, not a hosted ChatGPT app or remote MCP connection. Existing CLI/account policies apply. This change adds no database migration. Production application deployment remains a separate approval and acceptance process. Setup and evidence are in integrations/OPENAI.md and docs/OPENAI-RELEASE.md.
Hosted validation: all required jobs passed on head
9e7ee2978d9c58c3295ccffd46f1efde8efa3239, CI run 34000454434, attempt 2. Attempt 1 returned an unexpected 503 during the compiled production save check; its failure artifact is retained. One rerun passed without code changes. The cause is unconfirmed and has been handed to the delivery/QA owner; no assertion, timeout or application code was weakened. Independent peer approval is still required; merge #14 first.