Skip to content

Land remaining open PRs and in-repo issue fixes - #36

Merged
sdcarlson merged 6 commits into
mainfrom
cursor/land-open-work-9ece
Sep 6, 2026
Merged

sdcarlson merged 6 commits into
mainfrom
cursor/land-open-work-9ece

Conversation

@sykosyber

@sykosyber sykosyber commented Sep 6, 2026 •

Copy link
Copy Markdown
Member

Problem and result

Closes #8
Closes #9
Closes #19

main already includes protected CI/CD (#14), context playbooks (#18), session-expiry (#15 / #7), ChatGPT/Codex public-copy (#13), Apache 2.0 (#39 / #38), and tracker CSV (#11 / #17). This branch merges that tip and keeps the remaining unique trees:

Head 4d8f007 merges origin/main (256854b, #11) into the previous landing. Versus the tree verified at 4b81fe0 / 8d6ba1a, this head only changes three files: ChatGPT wording spacing, the #11 README note outside the public-copy block, and a single Tracker CSV setup section. Conflict resolution kept void test wrappers, history/null-URL API coverage, and did not restore profile or diagnostic code.

The changes-requested review is on superseded 9e307b9. Independent preservation review of 8d6ba1a retired the five original code findings. The later 4b81fe0 review also retired the diagnostic and expanded-profile objections.

Deferred, matching maintainer comments, and not in this PR:

Keep #16 open: remaining development-tool advisories. Keep #21 open until post-merge Pages verification. Keep #22 open. Cloudflare hosting (#3), two-account isolation (#4), recruiting (#5), backup rehearsal (#6), and Grok Bot VM command review (#20) still need human/environment work.

Evidence

  • Local on 4d8f007: pnpm lint, pnpm typecheck, pnpm test (98 passed), pnpm public-copy:check, pnpm build, pnpm test:api, pnpm test:e2e (6 passed), pnpm test:production passed.
  • GitHub CI on 4d8f007 (run 34003847782): all 9 checks passed, including required CI, quality, API, browser, production, CodeQL, dependency-security, and bundled agent contracts.
  • User-visible proof: copy/paste packet, Windows-safe scripts/ensure-node.mjs, Load earlier review history, null-URL packets. CSV import and ChatGPT/Codex prepare now come from main.
  • Security, data migration, and rollback impact: no new D1 migration. React trio stays at 19.2.8. CI Vinext still uses ephemeral ports when RELAY_CI_STATE is set. Production integration keeps the original request sequence.

Review

  • One issue owns this scope; unrelated changes are separate. This is an explicit integration PR covering the remaining open merge train.
  • Tests exercise the changed behavior, including failure paths (including compiled Workspace continuation and history-after-expiry regressions).
  • No credentials, personal applications, or private research are included.
  • Agent findings from the 9e307b9 review remain addressed.
  • A maintainer other than the author will approve. @sdcarlson must approve the latest push (4d8f007); the changes-requested review is on superseded 9e307b9.
  • Public capabilities, integration limits and lead-engineer credit match docs/public-copy.json; run pnpm public-copy:check and follow docs/PUBLIC-COPY.md when these change.

After merge, close the superseded feature PRs (#12, #24) as landed here rather than squash-merging them separately. #11, #13, #15, and #39 are already merged. #26 and #32 stay closed as deferred. #40, #41, and #42 stay on their own tracks. Existing feature PRs stay open until this replacement actually merges.

Open in Web Open in Cursor 

Replay unique trees from ChatGPT/Codex public-copy (#13), tracker CSV plus session expiry (#11/#15), local-dev Node/port/sign-in with a Windows-safe Node guard (#12/#19), copy/paste draft handoffs (#24), and the profile calibration loop (#26). Bump shadcn to 4.20.1 (#32).

Keep selected-job review history retrievable beyond the global 200-event window, allow assistant packets for valid jobs without a posting URL, and make compiled production failures dump status, body, and process output without retrying saves.

Closes #7
Closes #8
Closes #9
Closes #17
Closes #19
Closes #22

Co-authored-by: sykosyber <sykosyber@users.noreply.github.com>
@sykosyber
sykosyber requested a review from sdcarlson as a code owner September 6, 2026 00:40

Copy link
Copy Markdown
Contributor

Bounded QA on head 9e307b92447aeff6fdce98bc696d9bb20181fe06:

Merge blocker — frozen installation fails before application tests. CI run 34001917590, quality job reports ERR_PNPM_OUTDATED_LOCKFILE: shadcn is 4.20.1 in package.json and 4.18.0 in pnpm-lock.yaml. The integration jobs also fail at setup; browser/API/production passes cannot be claimed from this run. Regenerate and commit the matching lockfile with the intended compatible version, retain --frozen-lockfile, then run the required gates.

Issue #19 preservation check passed: the Windows guard is byte-identical to the tested correction (1326aec3dff5427a67e1bb86f4be8f687b05bef7), and ensure-node/predev/prestart all use Node. Direct execution from an isolated exact-head checkout passes on Windows Node v24.19.0 without Bash. Keep #19 open until the change actually lands.

This is a scoped guard/setup check, not approval of the full integration diff or its new migration.

Copy link
Copy Markdown
Contributor

Additional bounded preservation review at 9e307b92447aeff6fdce98bc696d9bb20181fe06 found merge-blocking regressions. These results come from the focused PR24/PR15 preservation reviewer; they are separate from this task's Windows guard check.

  1. P1, workspace mutation continuation (lines 215–226): the caller mutationIsLive guard was removed. Executing the actual compiled callbacks with the prior four-microtask expiry interleaving produced gets=2, signedOut=false, jobs=[restored private]. Restore the latest PR15 guard and its actual-callback regression (Ignore stale workspace responses and clear private state on sign-out #7).
  2. P1, history reader (lines 133–156): delayed history JSON applies after expiry without epoch validation. The callback reproduction restored private events and the old cursor while signedOut=true. Guard the response across both awaits and add an expiry regression (Keep every selected job review event retrievable #8).
  3. P1, refresh continuation (lines 165–177): the latest caller refreshIsLive fix from PR15 8102c81 / PR11 5beb10a is absent. The owning correction task reports reproduced CSV-expiry interleavings; this reviewer confirmed the missing guard but did not rerun that newer harness. Preserve the fix and tests.
  4. P2, navigation (lines 322–329): new /profile and /review links bypass dirty-editor confirmation. Source-traced, not browser-replayed. If those destinations stay in scope, protect them with the same cancel/confirm behavior as job/filter navigation.
  5. Build blocker (line 595): ChevronRight remains rendered but its import was removed. Direct source finding; build has not reached this step because installation already fails.

Keep the existing reviewed PR24 behavior intact. Recheck the corrected exact head, required CI, and peer review before merging. The profile feature and migration were outside this bounded review; none of these checks grants overall approval.

@sdcarlson sdcarlson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes on exact head 9e307b9. This consolidation drops tested session-expiry protections and cannot yet replace the existing PRs.

  1. Restore the Workspace.run caller mutationIsLive check immediately after processMutation outcome handling and its actual-callback regression from PR15. The preservation review reproduced two GETs and private jobs restored after another request expired the session.
  2. Preserve the Workspace.refresh caller refreshIsLive check and tests/refresh-expiry.test.mjs from PR15 8102c81 / PR11 5beb10a. I reproduced synchronous CSV unauthorized expiry between the helper result and caller continuation: the regression fails without this guard and passes all 20 interleavings with it.
  3. The new history reader also needs a captured session epoch checked after asynchronous work before writing events/cursors. The preservation review executed the actual callback and reproduced an old response restoring private history after expiry.
  4. The new /profile and /review links bypass the existing dirty-editor navigation confirmation; preserve cancel/confirm behavior if these features remain in scope.
  5. Restore the ChevronRight import still used by Workspace, and reconcile package.json / pnpm-lock.yaml (shadcn 4.20.1 versus 4.18.0) without weakening frozen installation or other CI gates.

Please retain the existing PRs until a corrected replacement passes required checks and receives review. This PR also reintroduces previously deferred PR26 features and migration 0003, so that expanded scope needs an explicit decision and review before this can be considered a clean base. The smaller corrected PR11/13/15 remain available for protected merge independently.

@sdcarlson

Copy link
Copy Markdown
Contributor

Additional issue22 review on unchanged head 9e307b9, confirmed against source after CI-owner investigation:

  • scripts/ci/run-production.mjs inserts a new waitForHealth loop (up to 120 seconds) between the intentionally rejected origin request and the valid owner save. That changes the timing of the failing sequence and can hide the intermittent failure rather than explain it. The live-reload setting also changes runtime conditions without an established cause. Preserve the original request sequence while collecting failure evidence.
  • scripts/ci/production-diagnostics.mjs labels every non-JSON 503 as runtime-503, but deploy/handler.mjs itself returns plain-text Service unavailable with status 503 on configuration failures. The label therefore cannot identify the source. Report the observed status/body without unsupported attribution.
  • The failure-body read has no deadline; use bounded diagnostics and ensure process output is drained during cleanup.

Do not close #22 based on this implementation or one passing run. The CI owner is preparing failure-only diagnostics separately; coordinate before incorporating them. These findings add to the existing requested changes, with no changes to this PR branch from me.

cursoragent and others added 2 commits September 6, 2026 00:53
…landing PR.

Fold the current #15/#11 continuation checks and regressions, keep history loads from applying after expiry, and match the lockfile to shadcn 4.18.0. Remove the deferred profile calibration loop and the production-diagnostics changes that were rejected for #22.

Co-authored-by: sykosyber <sykosyber@users.noreply.github.com>
Fold the unique #39 tree: official LICENSE text, package.json Apache-2.0 identifier, and README licensing while keeping grokcell MIT attribution.

Co-authored-by: sykosyber <sykosyber@users.noreply.github.com>
@sdcarlson

Copy link
Copy Markdown
Contributor

Review progress for exact head 8d6ba1a: the independent preservation reviewer reports that all five original code findings are addressed in source (mutation caller guard, refresh caller guard, history epoch protection, dirty navigation, and ChevronRight import). It executed the two tracked regression modules against that exact Git source: 13 tests passed, including the 20 synchronous CSV-expiry interleavings. This evidence is from that reviewer, not a new local run by me.

Those five findings are retired for this head. This is not overall approval: the separate production-diagnostics concerns in my later comment, dependency/CI integration, and the expanded feature/migration scope still need their respective review. Existing requested changes should not be interpreted as claiming the five repaired defects remain present. Coordinate with the originating task before replacing the smaller PRs.

Keep the landing-branch workspace extras (history pagination, tracker
import, dirty navigation, exact-acceptance UX) on top of #15's session
expiry guards. Refresh tests keep the extra stubs and history-epoch
cases required by that Workspace.

Co-authored-by: sykosyber <sykosyber@users.noreply.github.com>
@sdcarlson

Copy link
Copy Markdown
Contributor

Further verified review update: 4b81fe0 has an identical tree to 8d6ba1a. I checked the narrowed tree locally: typecheck, lint, all 98 unit tests and public-copy check pass. The CSV implementation, workspace-refresh helper, assistant handoff/CLI/public-copy scripts, and editor helper match their reviewed source PRs. No profile feature, migration, or production-test changes remain. The earlier diagnostic and expanded-profile objections are therefore retired as well.

Main has now advanced again: #13 merged as a25aafe. Please reconcile this branch with current main and preserve the exact reviewed implementation so final checks/review can evaluate a mergeable head. Do not restore deferred profile or diagnostic code. Existing feature PRs remain open until a tested replacement is actually merged. #22 remains a separate diagnostic investigation; #40 owns its fix.

cursoragent and others added 2 commits September 6, 2026 01:22
Keep remaining unique trees (tracker CSV, local-dev Node guard, copy/paste
handoffs, selected-job history, and null-URL packets) on top of the landed
ChatGPT/Codex public-copy and Apache 2.0 license. Restore the ChatGPT
wording spacing from main.

Co-authored-by: sykosyber <sykosyber@users.noreply.github.com>
Keep remaining unique trees (local-dev Node guard, copy/paste handoffs,
selected-job history, and null-URL packets). Deduplicate the Tracker CSV
setup section introduced by the #11 squash.

Co-authored-by: sykosyber <sykosyber@users.noreply.github.com>

@sdcarlson sdcarlson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve exact head 4d8f007 after final integration review. All findings from my prior change request are addressed: both session caller guards and actual-callback regressions are retained, delayed history checks epoch across awaits, deferred profile/navigation/migration work is absent, icon and frozen dependency graph are corrected. The problematic production diagnostics were removed; #22 remains separate.

Verified locally on this exact head: typecheck, oxlint, 98 unit tests, public-copy check, release build and all six Chromium journeys pass. Hosted required CI, API/browser/production integration, CodeQL, dependency security and agent contracts all pass. Reviewed source preserves the approved CSV and assistant implementation and exact PR24 editor helper; history remains owner-scoped and null-URL handoffs remain tied to source identity/version. No new migration or production request-sequence changes.

This supersedes the old requested changes. The user's clean-base instruction authorizes this reviewed integration and closure of redundant PR12/24 after verified merge. Production deployment and external copy verification remain separate tasks.

@sdcarlson
sdcarlson merged commit 7cfec26 into main Sep 6, 2026
9 checks passed
@sdcarlson
sdcarlson deleted the cursor/land-open-work-9ece branch September 6, 2026 01:27
@sykosyber

Copy link
Copy Markdown
Member Author

Reconciled with current main. Mergeable head is 4d8f007ea45b6968d9645bc3723c1c4d684490cb (includes #13 a25aafe, #39 a42b8e7, and #11 256854b).

Versus the tree you verified at 4b81fe0 / 8d6ba1a, this head only changes three files: ChatGPT wording spacing in app/connections.tsx, the #11 README note outside the public-copy block, and a single Tracker CSV setup section in integrations/README.md (the squash merge had duplicated that heading). No profile routes, migration 0003, or production-diagnostics code.

Local on 4d8f007: lint, typecheck, 98 unit tests, public-copy check, build, API, 6 Chromium e2e, production. Hosted run 34003847782: all 9 checks passed, including required CI and production.

#12 and #24 stay open until this replacement actually merges. #22 / #40 remain separate. Protected merge still needs your approval of this latest push; the changes-requested review is on superseded 9e307b9.

@sdcarlson

Copy link
Copy Markdown
Contributor

Post-merge main run34003929975 failed before API tests because its chosen temporary port43619 was already occupied. Preserved artifact9980337301: api-server.log explicitly says Error: Port43619 is already in use in Vite httpServerStart. This is distinct from the production503 investigation; no API assertion ran or failed. Retrying that failed infrastructure job once unchanged, without weakening port checks or API tests.

sdcarlson added a commit that referenced this pull request Sep 6, 2026
The unused generated UI kit added dependencies and maintenance work
without serving Relay screens. This PR now removes that kit, its unused
helper/hook and Next configuration, and the unused Tailwind pipeline.
Runtime history, session guards, CSV, assistant handoffs and copy/paste
remain exactly as merged in #36. It also restores the historical PR24
evidence accidentally omitted during consolidation, with original
commit/test-count limits intact.

The original review-loop fixes are already on main through #15/#36; this
final delta does not replace their implementations. No database
migration or deployment change.

Validation against main 7cfec26: typecheck, lint, frozen offline
lockfile validation, all98 unit tests, release build and six browser
journeys pass. The prior combined API run passed before choosing the
unchanged main runtime; fresh hosted API/production/security checks are
required on this pushed head. Dependencies were removed without
disabling audit or CI gates.

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Seth Carlson <sdcarlson@users.noreply.github.com>
sdcarlson added a commit that referenced this pull request Sep 6, 2026
Closes #37.

Users can now select and edit one job's research and specify the next
drafting task inside the existing Prepare for ChatGPT/Codex downloads.
Research stays separate from candidate facts, optional fields clear on
job changes, oversized context is rejected, and returned drafts retain
explicit review and stale-version checks. No migration, dependencies,
provider service, or submission behavior changes.

Reconciled onto current main007e0ae after #13, #36 and #42 merged.
Canonical copy/paste, exact editor checks, selected-job packet creation
and history remain intact. Production remains blocked by owner setup in
#3 and the normal staging/peer production approval gates.

Validation: lint, typecheck, 99 unit tests, public-copy check, build,
API suite, all 6 Chromium journeys (context returns by paste and file),
and compiled production/gateway smoke passed locally. High-severity
dependency audit passed; inherited development-tool esbuild advisories
remain (one moderate via drizzle-kit, one low via Wrangler), with no
dependency changes in this PR.

A fictional two-model smoke trial ran one history/focused/checkpoint
condition each for gpt-5.4-mini and gpt-5.5. All six used supported
facts without invented qualifications or submission claims. One draft
included an internal review note; a prompt refinement and one repeat
corrected it. The committed report records limitations: not blinded, no
repeated benchmark, no model ranking/cost claim, and no native
compaction test.

Recovery: revert this UI/prompt change; stored job data and packet
schemas are unchanged. Real-user validation remains separate from these
fictional checks.

Latest headfe73858 is rebased onto main007e0ae with an unchanged context
diff. Local lint/types/99 unit tests/build pass; fresh integration and
hosted checks are running. Earlier production503 evidence remains in
#22; this change does not claim a fix. Final peer approval and green
current-head CI are required.
sdcarlson added a commit that referenced this pull request Sep 6, 2026
<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
## Problem and result

Related to #22. Does **not** close #22. Issue 22 remains unresolved.

The compiled production integration test can return 503 on the valid
owner-A save immediately after the intentional cross-origin 403. This PR
only adds failure-only diagnostics and reliable process-group teardown
so the next failure can be distinguished from an application response.
It does not change production runtime, retries, health polls, CI
workflows, or dependencies.

CI has already captured a Wrangler ProxyWorker synthesized body (`Your
worker restarted mid-request...`, `text/plain; charset=UTF-8`,
`retry-after: 0`, parent exit/signal null). That is not evidence of an
actual restart. No runtime fix is included.

The process-group fixture now installs the SIGTERM handler before
publishing `grandchild=`, and flushes `after-term` in the write callback
before exit, so Quality cannot default-kill the leader and drop that
line.

Quality on head `dda4090` (run 34003902709) failed `pnpm lint` with 12
oxlint errors in `tests/production-diagnostics.test.mjs`: 10 un-awaited
`test()` registrations and 2 unary minuses on `ChildProcess.pid`
(`number | undefined`). The aggregator `CI` job failed because Quality
failed. This revision matches the existing `void test()` style and
narrows pids before group `SIGKILL`. Helper `3d65c2d5` is unchanged.

This branch includes current `main` (`7cfec26`, including #36) merged
into the diagnostic history. Reviewed diagnostic commit `3d65c2d5` is an
ancestor.

## Evidence

- Exact head: `7b1f4cc3a7d9b82f20cc5e240e544acfb90d0d9f`
- `pnpm lint`: oxlint exit 0
- `pnpm typecheck`: `tsc --noEmit` exit 0
- `pnpm test`: 108 passed, 0 failed
- `pnpm build`: vinext build complete
- `pnpm test:production` (once): PASS (built app rendering/assets,
signed identity, persistence, tenant isolation, forged headers, request
origin, exact acceptance and stale-write integrity)
- GitHub run 34004136177 on this head: Quality, CI aggregator, and
remaining required jobs succeeded
- User-visible proof: none; CI diagnostic only, fictional records and
locally generated tokens
- Security, data migration, and rollback impact: no schema or runtime
auth change from the diagnostic work. Request headers and authentication
JWTs are not printed. CodeQL alert 4 was reviewed/dismissed as used in
tests; query/gates remain enabled.

## Review

- [x] One issue owns this scope; unrelated changes are separate.
- [x] Tests exercise the changed behavior, including failure paths.
- [x] No credentials, personal applications, or private research are
included.
- [ ] Agent findings are fixed or answered with evidence.
- [ ] A maintainer other than the author will approve.

Diagnostics alone must not close #22. Independent review is separate. No
merge or approval from this agent.
<!-- CURSOR_AGENT_PR_BODY_END -->

<div><a
href="https://cursor.com/agents/bc-1517975b-d6f5-491d-94fa-652e8df741a2?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/background-agent?bcId=bc-1517975b-d6f5-491d-94fa-652e8df741a2&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Seth Carlson <sdcarlson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants