Skip to content

Fix Beautify Time Codes preview after inserting new subtitle lines #12280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niksedk merged 1 commit into from
Jul 8, 2026
+15 −12
Merged

Fix Beautify Time Codes preview after inserting new subtitle lines #12280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions src/ui/Features/Tools/BeautifyTimeCodes/BeautifyTimeCodesViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,9 @@ private void UpdatePreview()
return;
}

// Build a Subtitle and run the full libse beautifier — it reads the profile
// directly from Configuration.Settings.BeautifyTimeCodes.
var subtitle = new Subtitle();
foreach (var p in _allSubtitles.Select(p => p.Paragraph!).OrderBy(p => p.StartTime.TotalMilliseconds))
{
subtitle.Paragraphs.Add(new Paragraph(p));
}
// Build a Subtitle from the current row values and run the full libse
// beautifier — it reads the profile directly from Configuration.Settings.BeautifyTimeCodes.
var subtitle = BuildSubtitleFromRows();

var beautifier = new Core.Forms.TimeCodesBeautifier(subtitle, _frameRate, new List<double>(), _shotChanges);
beautifier.Beautify();
Expand Down Expand Up @@ -595,11 +591,7 @@ private void Ok()
_timerUpdatePreview.Stop();

// Apply final beautification to commit the result back to _allSubtitles
var subtitle = new Subtitle();
foreach (var p in _allSubtitles.Select(p => p.Paragraph!).OrderBy(p => p.StartTime.TotalMilliseconds))
{
subtitle.Paragraphs.Add(new Paragraph(p));
}
var subtitle = BuildSubtitleFromRows();

var beautifier = new Core.Forms.TimeCodesBeautifier(subtitle, _frameRate, new List<double>(), _shotChanges);
beautifier.Beautify();
Expand Down Expand Up @@ -628,6 +620,17 @@ public List<SubtitleLineViewModel> GetBeautifiedSubtitles()
return new List<SubtitleLineViewModel>(_allSubtitles);
}

private Subtitle BuildSubtitleFromRows()
{
var subtitle = new Subtitle();
foreach (var p in _allSubtitles.Select(p => p.ToParagraph()).OrderBy(p => p.StartTime.TotalMilliseconds))
{
subtitle.Paragraphs.Add(p);
}

return subtitle;
}

internal void OnKeyDown(KeyEventArgs e)
{
if (e.Key == Key.Escape)
Expand Down