Fix Beautify Time Codes preview after inserting new subtitle lines#12280
Merged
niksedk merged 1 commit intoJul 8, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After opening a subtitle and inserting a new subtitle line, Beautify Time Codes could open with an empty beautified preview and 0 detected changes.
Cause & Fix
Beautify Time Codes built its working
Subtitlefrom each row's backingParagraphviaParagraph!.That works for rows loaded from a subtitle file, but newly inserted rows may only have the current
SubtitleLineViewModelvalues populated. In that case, relying onParagraph!can prevent the beautifier preview from being built correctly.The fix builds the working
SubtitlewithToParagraph()instead. This is the appropriate conversion path because it creates aParagraphfrom the row's current start time, end time, text, and related subtitle fields.The shared helper is used by both preview generation and final apply so both paths use the same input source.
Screenshots
2026-07-09-before.mp4
2026-07-09-after.mp4
Testing
Tested on Windows 11 x64 (local Release build).
Verified both full-subtitle beautify and selected-lines beautify.