Skip to content

Show automatic Warp/Jump choice on the system course button - #292

Merged
netniV merged 8 commits into
STFC-Mod:devfrom
Guffawaffle:feature/warp-action-label
Sep 27, 2026
Merged

netniV merged 8 commits into
STFC-Mod:devfrom
Guffawaffle:feature/warp-action-label

Conversation

@Guffawaffle

@Guffawaffle Guffawaffle commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

The system card's SET COURSE label does not show whether automatic confirmation will choose regular warp or instant jump. Show WARP or JUMP using the same resolver as auto-confirm, including ship-specific overrides. Ask restores the native localized wording, and the label refreshes while the card stays open. Timer and click behavior remain native; toll and wormhole buttons retain their wording. Uses the existing screen update dispatcher without adding a detour.

Updated against current dev, preserving its localized display-name matching and confirmation precedence. Checked invocation and field access now live in il2cpp/il2cpp_checked.h and reuse IL2CppClassHelper::GetMethodInfo and GetField. The checked layer retains reference-argument validation and managed-exception handling; existing unchecked callers are unchanged. Unity object lifetime and label ownership remain feature-specific.

Validation: Windows release build, production-header IL2CPP fixture, workflow lint and diff checks passed. The fixture checks reference/null argument forwarding, rejection of incompatible/value/byref arguments and static methods, managed exceptions, Boolean unboxing and field contracts; wired into Windows and both macOS CI builds. Earlier feature smoke confirmed live WARP/JUMP/Ask changes on Windows and WARP display on ARM Mac. The current cleanup has not had a new in-game smoke; updated cross-platform CI runs after this push.

Uses the shared IL2CPP runtime mechanics from #304 beneath the checked reference-only invocation adapter. The adapter retains its argument validation and throwing failure policy.

The existing class-lookup guards are separated into #305; land that dependency alongside #304.

@netniV netniV left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a conflict that needs resolving, and I'm not entirely sure if some of the methods in warp_action_label.cc are actually elsewhere within the il2cpp code handlers we have.

@Guffawaffle
Guffawaffle requested a review from netniV September 25, 2026 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants