Repository navigation
Show automatic Warp/Jump choice on the system course button - #292
Merged
Merged
Conversation
netniV
requested changes
Sep 19, 2026
netniV
left a comment
Collaborator
There was a problem hiding this comment.
There is a conflict that needs resolving, and I'm not entirely sure if some of the methods in warp_action_label.cc are actually elsewhere within the il2cpp code handlers we have.
netniV
approved these changes
Sep 27, 2026
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The system card's SET COURSE label does not show whether automatic confirmation will choose regular warp or instant jump. Show WARP or JUMP using the same resolver as auto-confirm, including ship-specific overrides. Ask restores the native localized wording, and the label refreshes while the card stays open. Timer and click behavior remain native; toll and wormhole buttons retain their wording. Uses the existing screen update dispatcher without adding a detour.
Updated against current dev, preserving its localized display-name matching and confirmation precedence. Checked invocation and field access now live in
il2cpp/il2cpp_checked.hand reuseIL2CppClassHelper::GetMethodInfoandGetField. The checked layer retains reference-argument validation and managed-exception handling; existing unchecked callers are unchanged. Unity object lifetime and label ownership remain feature-specific.Validation: Windows release build, production-header IL2CPP fixture, workflow lint and diff checks passed. The fixture checks reference/null argument forwarding, rejection of incompatible/value/byref arguments and static methods, managed exceptions, Boolean unboxing and field contracts; wired into Windows and both macOS CI builds. Earlier feature smoke confirmed live WARP/JUMP/Ask changes on Windows and WARP display on ARM Mac. The current cleanup has not had a new in-game smoke; updated cross-platform CI runs after this push.
Uses the shared IL2CPP runtime mechanics from #304 beneath the checked reference-only invocation adapter. The adapter retains its argument validation and throwing failure policy.
The existing class-lookup guards are separated into #305; land that dependency alongside #304.