Skip to content

Add fleet OPC highlights and mining ETA indicators on Windows and macOS - #294

Draft
Guffawaffle wants to merge 22 commits into
STFC-Mod:devfrom
Guffawaffle:feature/opc-indicators
Draft

Guffawaffle wants to merge 22 commits into
STFC-Mod:devfrom
Guffawaffle:feature/opc-indicators

Conversation

@Guffawaffle

@Guffawaffle Guffawaffle commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Adds OPC highlighting and ETA/SAFE information to deployed-fleet widgets. Feature preferences remain off by default; the independent [patches].opcindicatorhooks installation switch defaults to true. Installed callbacks read the current preferences, restore their own hidden UI when disabled, and preserve native behavior when metadata or a hook family is unavailable.

Merges the corrected fleet-notification parent (#268) and current dev alignment. Resolution checks full method/field contracts and duplicate native addresses before installation. Mining-node limits use the actual IMiningSlot.AmountMined and Amount getters, including typed invocation and unknown-data handling.

Validation: exact-head Windows release build (37.422s), all 11 maintained TOML examples, existing arrival and OPC cache fixtures, and three independent review lanes. The six Windows client270 detour windows fit their measured native method extents. Native mining-progress inspection confirms the chosen values.

Live testing of this exact artifact, pooled-widget cleanup and partial installation, Mac native extent/runtime qualification, and inherited #268 runtime gaps remain open. This is not a runtime-qualified release.

@Guffawaffle
Guffawaffle force-pushed the feature/opc-indicators branch from 25a7366 to 2a83b0d Compare September 28, 2026 00:00
@Guffawaffle

Guffawaffle commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor Author

Hook/feature alignment follow-up for #313

Follow-up to #313: keep hook installation independent of feature enablement, with default-enabled compatibility switches under [patches] and feature checks inside the installed hooks.

Two installation paths need separation: inherited fleet-notification hooks from #268, and this PR's OPC hooks. installOpcIndicatorHooks, the installer early return, and individual hook-family resolution/installation depend on [ui].highlight_opc_fleets / fleet_hud_opc_eta. Install compatible supported families behind an independent [patches] switch; decide display behavior inside callbacks and restore custom visuals when disabled. Keep metadata/platform/partial-install guards. Correct #268 first and carry its notification fix here. Dependency chain: #253 → #268 → #294.

Updated at 0927907: corrected #268 parent, independent default-true OPC installation, current preference cleanup and typed unique method contracts. Removed nonexistent mining properties in favor of actual IMiningSlot AmountMined/Amount getters; native progress semantics agree. Exact Windows release build and existing fixtures/examples pass; three review lanes clear of confirmed defects. Windows and Mac CI are queued; proceeding without waiting. Exact-artifact UI/pooling/partial-install smoke and Mac native/runtime qualification remain open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants