Skip to content

fix: preserve system warp destination after zooming out - #273

Draft
Guffawaffle wants to merge 10 commits into
STFC-Mod:devfrom
Guffawaffle:fix/planned-system-warp
Draft

Guffawaffle wants to merge 10 commits into
STFC-Mod:devfrom
Guffawaffle:fix/planned-system-warp

Conversation

@Guffawaffle

@Guffawaffle Guffawaffle commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

Fixes primary-action warp after selecting a system and zooming out until its popup disappears. Previously, the dismissed context could submit an invalid destination and leave the ship showing WARPING 00m 00s without moving.

For hidden galaxy popups, recover the destination from the selected fleet's matching planned course and submit its explicit position and node ID. Native navigation still handles eligibility, confirmations, cooldown and responses.

Recovery is limited to an unused ordinary system-warp plan whose fleet, origin, path and selected position agree. Invalid or stale data rejects the action. Special travel continues through its normal popup flow.

Uses the shared IL2CPP runtime invocation boundary already in dev through merged #292 when reading resolved virtual getters. Enum widths, value identity, and navigation signature checks remain feature-specific.

The existing class-lookup guards are also in dev through merged #292.

@Guffawaffle

Copy link
Copy Markdown
Contributor Author

This fails if you switch ships after zooming out. You'll still be the 00m:00s result and it never leaves destination. Converting to draft until I can address that additional repro.

@Guffawaffle
Guffawaffle marked this pull request as draft September 18, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant