Repository navigation
fix: preserve system warp destination after zooming out - #273
Draft
Guffawaffle wants to merge 10 commits into
Draft
Guffawaffle wants to merge 10 commits into
Guffawaffle wants to merge 10 commits into
Conversation
Contributor
Author
|
This fails if you switch ships after zooming out. You'll still be the 00m:00s result and it never leaves destination. Converting to draft until I can address that additional repro. |
Guffawaffle
marked this pull request as draft
September 18, 2026 09:30
# Conflicts: # xmake.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes primary-action warp after selecting a system and zooming out until its popup disappears. Previously, the dismissed context could submit an invalid destination and leave the ship showing
WARPING 00m 00swithout moving.For hidden galaxy popups, recover the destination from the selected fleet's matching planned course and submit its explicit position and node ID. Native navigation still handles eligibility, confirmations, cooldown and responses.
Recovery is limited to an unused ordinary system-warp plan whose fleet, origin, path and selected position agree. Invalid or stale data rejects the action. Special travel continues through its normal popup flow.
Uses the shared IL2CPP runtime invocation boundary already in dev through merged #292 when reading resolved virtual getters. Enum widths, value identity, and navigation signature checks remain feature-specific.
The existing class-lookup guards are also in dev through merged #292.