[anth-volk]

Fixes #61

Part of #53, which tracks the end state and closes with the last of the fix pull requests stacked on this one.

What this does

Ruff selects every rule (ALL), configured as the simulation API and the Public API configure it. 16.1 · 8 in the plan; stacked on #52 (16.1 · 7, making the PR description check required, is a manual step and has no pull request). Anthony decided the design on round 1: mirror both services instead of ratcheting the ignore list.

• select = ["ALL"], with the services' four global ignores. COM812 and ISC001 conflict with ruff format. D203 and D213 conflict with D211 and D212, which the configuration keeps; they apply once the D family leaves the temporary list. E501 is no longer ignored, as in both services.

• CPY (copyright notices) stays off, with its reason in pyproject.toml. Ruff 0.16, which uv.lock pins here, checks CPY001, while the Ruff 0.15 both services run keeps it in preview, so neither enforces it.

• Two more preview rules stay enforced here. ISC004 (all 108 of the ISC findings) and PLR0917 (5 of the 75 PLR findings) are also stable in Ruff 0.16 but only preview rules in the services' Ruff 0.15, so this repository enforces them and the services do not. They stay enforced; the stacked pull requests fix their findings.

• Per-file ignores as in both services, each registered as a ruff per-file-ignore rule. These are the registry guide's file-level exceptions. The existing guard checks that each pattern exists with those codes, that it covers only files that may take an exception, and that every pattern has a rule:

  Rule	Pattern	Codes
  emitter.quality.tests-ruff-exemptions	**/tests/**	ANN ARG001 ARG002 ARG005 D1 DTZ001 DTZ011 INP001 N802 PLC0415 PLR2004 S101 S105 S106 S108 S603 S607 S608 SLF001 T201 TID253
  emitter.quality.unittest-ruff-exemptions	scripts/rules/tests/**	PT
  emitter.quality.command-line-scripts-ruff-exemptions	scripts/**	DTZ011 S603 S607 T201
  emitter.quality.tools-ruff-exemptions	tools/**	N999 S603 T201
  emitter.quality.installed-checks-ruff-exemptions	tools/{check-installed,installed-smoke,installed-interface-smoke}.py	PLC0415 S101

  The test codes are the Public API's 20 plus the simulation API's S108. The comment and the rule statement now explain each of them, including INP001 and TID253. There are no Python files under .github, so there is no .github/** entry. The root conftest.py is not under tests, and the rules tool allows no exception at the root, so the fix pull requests change its code instead.

• namespace-packages lists scripts, tools and the two Alembic directories, which have no __init__.py on purpose (INP001), as both services list theirs.

• flake8-tidy-imports and flake8-type-checking, as in both services (round 2):

  • banned-module-level-imports lists the modules imported only inside the function that needs them: the telemetry and Hugging Face service modules, which their entry points import only when create_module runs, and the Hub client's HfApi and CommitOperationAdd, which huggingface/service/hub.py imports only in the functions that build them. TID253 refuses these at module level outside tests, and PLC0415 accepts their in-function imports, which removes 4 findings.
  • runtime-evaluated-base-classes lists sqlalchemy.orm.DeclarativeBase, so TC never moves an import that a model's Mapped[...] annotation needs at runtime.
  • The new rule emitter.quality.runtime-evaluated-models-resolve registers tests/test_runtime_evaluated_annotations.py, adapted from the services' tests of the same name. It checks that every model in microcosm_emitter resolves, as Ruff resolves bases, to a listed base; that the resolution handles each kind of base; and that every mapper configures. The file is added to guard_test_globs.

• The families not fixed yet are ignored until the pull requests stacked on this one fix them. On round 2's head, 79b468a, 1,593 findings remained in 26 families; with this head's import settings, 1,589. They are listed in ignore under a "Not fixed yet" comment, grouped as the stacked pull requests fix them. Each pull request removes its group, and the last leaves only the permanent ignores:

  1. exception messages and raising (469): EM 240, TRY 227, RSE 2 — Fix Ruff's exception-raising findings (EM, RSE, TRY) #58;
  2. docstrings (458): D 458;
  3. typing-only imports, annotations and in-function imports (180): TC 80, ANN 79, PLC 21;
  4. broad excepts, security findings, prints and private access (131): BLE 61, S 42, T20 22, SLF 6;
  5. smaller rules (262): ISC 108, PT 72, RET 16, ARG 14, PTH 10, E 9, SIM 9, RUF 6, FBT 6, C4 4, PERF 3, PLW 3, A 2;
  6. complexity (89): PLR 75, C90 14.

• emitter.quality.ruff-lint describes ALL, the permanent ignores, the registered per-file ignores and, until the stacked pull requests land, the families not fixed yet.

• The README's development section says how Ruff is configured.

Removed in round 1: the ruff-ignores guard and its comparison with the base branch, with its tests and fixtures; the ratcheted emitter.quality.ruff-families-not-yet-fixed rule, with its baseline and the downgrade naming #54; and the test that each listed family still had findings. The rules tool, the registry guide and every workflow are as on the base branch. #54 is closed as not planned.

Test-first record

Commit	Result
3578e12 The Ruff configuration and its rules	Configuration and registration only, so no red step. ruff check . and ruff format --check . (Ruff 0.16.10 from uv.lock) pass; all five guards pass, also with GITHUB_BASE_REF=main.
79b468a The rules tool as on the base branch	The guards and ruff check . pass.
7235422 Test the model bases (round 2)	Red: of the three new tests, test_every_model_base_is_listed_for_ruff fails, listing all 10 models (both declarative bases resolve to the unlisted sqlalchemy.orm.DeclarativeBase); the other two pass.
bef4f36 The two settings, the rule and the wording	Green: the three tests pass. ruff check . and ruff format --check . pass. The guards pass against main and against #52's branch. A probe file confirms that TID253 refuses the banned imports at module level and that PLC0415 accepts them inside a function.

Before round 1's design was replaced, its commits were tested as recorded in their messages (37a3005, 0b85710, 30aea27, e5ff693, 87f903d, d259a7b, 106f3f5); their code is gone from this head. Only the three new tests were run, by node ID; no command ran a test directory or suite.

CI

No workflow, trigger or script changes. The new tests run in ci.yml's existing tests job (pytest -m "not collector"), which needs no new environment variable or secret. With no [rule.downgrade] left in the registry, the "Check the rules registry" step's issue lookup has nothing to look up, as on the base branch.

Release

The fragment is changelog.d/ruff-select-all.changed.md, a patch bump: merging releases the next patch version of both distributions. There are no source changes, so the wheels are unchanged.

🤖 Generated with Claude Code