[anth-volk]

Fixes #68

Part of #53.

What this does

The fifth of the pull requests stacked on #55 that fix the Ruff findings #55 leaves ignored: the 261 findings here (262 on #55) in the smaller-rule families, after which only C90 and PLR stay on the temporary list. Stacked on #67. Behaviour is unchanged in package code; some tests become stricter.

• ISC004 (108): implicit string concatenations inside lists, tuples and sets are wrapped in parentheses (Ruff's fix), which keeps each value. I read each one for a missing comma between two items; none looked like one. This rule is stable in Ruff 0.16 and a preview rule in the services' Ruff 0.15 (Select every Ruff rule, configured as the simulation API and the Public API configure it #55).
• Tests (PT, 72):
  • PT018 (58): one assert per condition.
  • PT011 (9): pytest.raises gets a match= for the message the code raises on that path.
  • PT006 (3): tuple parametrize names.
  • PT017 (2): pytest.raises instead of asserting inside an except block.
• Equivalent rewrites:
  • RET501, RET502, RET503 (15): an explicit return None.
  • SIM105 (6): contextlib.suppress, with the same exception types.
  • SIM102, SIM117: combined if and with statements.
  • C408, C416, C419, C420: comprehensions. C419 makes the Hugging Face module's shutdown all(...) a generator, which stops at the first worker still running. That has the same result, because wait only acquires and releases a lock, and once one worker's wait has used up the deadline, the rest would be non-blocking.
  • PERF401 (3), RUF005 (4), RUF022, RUF036, RUF059, FBT003.
  • E501 (9, plus 15 lines that ISC004's parentheses pushed past 88 columns): wrapped. Three docstrings were rewrapped or reworded, and the Python inside two test scripts' strings was rewrapped; those tests pass.
  • 9 of the 10 PTH findings: the pathlib equivalent where it is exact.
• 15 # noqa, each with its reason above it (20 before round 1):
  • ARG002 ×12 and ARG001: signatures fixed by their callers (redirect_request, SQLAlchemy's TypeDecorator, the ServiceModule protocol, the ReleaseChangePolicy type).
  • A002 ×2: overrides of log_message(format).
• Round 1 removed five suppressions:
  • _run_files_to_commit takes run_files and at_shutdown as keyword-only arguments, as its sibling methods do (FBT001).
  • The fake collector builds its socket path with str(Path(directory) / "tls.sock"), which gives the same string as os.path.join (PTH118).
  • CollectorDelivery passes _http_post and huggingface_token directly instead of through lambdas (PLW0108). I checked every test that replaces either function on the collector module: each does so before it builds a delivery. The one that replaces huggingface_token afterwards builds no further delivery.
• Renames: one unused unpacked name in a test (_errors). Two test-local parameters are now keyword-only; both are only passed by keyword.
• Ruff no longer ignores these families, and no # noqa in the tree is unused (RUF100).

A helper agent made these changes from a brief I gave it, with the decisions above. I reviewed every package-code change. Of the 68 changed Python files, 24 differ only in layout or docstrings; 12 package modules and 32 test and tool files have code changes.

Test-first record

There is no red step, since nothing changes behaviour in package code.

Commit	Result
eb82bc2 The fixes	ruff check ., ruff format --check . and the five guards pass. The 63 test functions whose code changed pass by node ID (164 cases), including every match=, the two rewrapped scripts and the keyword-only changes. The changed helper in tests/test_collector_contract.py needs the pinned collector, so CI's collector job runs it.
Merge of #67's round 1, and the fragment	ruff check . and ruff format --check . pass.

Review round 1:

Commit	Result
ab2efa5 Five suppressions dropped, and the fragment's count	ruff check ., ruff format --check . and the guards pass. The one test that uses the fake collector's TLS upload socket passes by node ID. Ruff prints no invalid-noqa warning since the merge of #67's fix.

No other test was run; CI runs them.

CI

No workflow, trigger or script changes, and no environment variable or secret is read differently.

Release

The fragment is changelog.d/ruff-smaller-rules.changed.md. With #65's added fragment below it in the stack, merging releases a minor version (0.12.0); on its own this fragment would give a patch bump.

🤖 Generated with Claude Code