[anth-volk]

Fixes #53

Fixes #70

What this does

The last of the pull requests stacked on #55. It fixes the 82 findings left on this branch in C90 and PLR (89 on #55). Ruff then ignores only COM812, ISC001, D203, D213 and CPY, plus the registered per-file ignores, as #53's end state requires, so it closes #53. Stacked on #69. Ruff keeps its default limits, as the simulation API and the Public API do. Behaviour is unchanged.

• Complexity (C901, PLR0911, PLR0912, PLR0915): long functions are split into private helpers in the same module, keeping the order of side effects, the exception handlers around the same calls, and the early returns' results:
  • the host runtime's run (_initialize_modules, _start_workers, _serve, _shut_down, _send_reply);
  • the Hugging Face release writer's apply_release_change (_attempt_release_change, _read_head_state, _release_order, _checked_record, _changed_record, _commit_violations, _commit_release_record, and three private dataclasses);
  • the Hugging Face module's query (an exactly equivalent table of command handlers) and its delivery (_deliver_leased, with private dataclasses for a delivery's work and a job's result);
  • the interface's release-record parser, wire_value, the sanitizer, bundles, hub, submissions client, collector delivery, telemetry lifecycle and Orrery upload;
  • in tests, the fake collector's request handler, now a module-level class, and the longest tests.
• Argument counts (PLR0913, PLR0917):
  • Grouped where every caller is in this repository: lease renewal settings become a LeaseRenewal dataclass, which HeldLeases and the submissions delivery take, plus a few test helpers.
  • 15 # noqa, each with its reason above the def:
    • published signatures other code relies on: EmitterClient.start, add_build and LocalTelemetryEmitter.start;
    • the standard library's redirect_request;
    • constructors and queue methods that tests call with their arguments by name: ServiceRuntime, HuggingFaceModule, CollectorSubmissionClient, stage_run_files, enqueue_job, claim_job and finish_job. These could be grouped if those tests change too;
    • four pytest test functions, whose fixtures and parametrized values pytest passes by name.
• PLR2004 (18): named constants. HTTP statuses use http.HTTPStatus members throughout, as core/auth.py already does. core/http_status.py defines the retryable client errors and is_permanent_client_error once, for the submissions client and the telemetry collector delivery; the submissions client's RETRYABLE_STATUSES keeps its name (round 1).
• PLR0124: value == value and abs(value) != inf becomes math.isfinite(value), which is the same for floats.
• C90 and PLR leave the ignore list, which now holds only the permanent ignores. The README and emitter.quality.ruff-lint no longer mention a temporary list.

Two helper agents made these changes from a brief I gave them, one for package code and one for tests, with the rules above. Their refactors were checked with Ruff, and with the tests they changed. CI's test jobs check the package refactors.

Test-first record

There is no red step, since nothing changes behaviour.

Commit	Result
bbfc9cf The fixes (committed as work in progress), and the temporary list emptied	ruff check . and ruff format --check . pass with only the permanent ignores.
06b1d2c Merge of #69's round 1	Two conflicts, where #69 changed code this branch had moved into helpers: _run_files_to_commit's callers now pass its flags by keyword inside _deliver_leased, and the fake collector's socket path uses pathlib in _add_tls_upload_server. Every test function that changed passes by node ID (24 cases), and so does every test that builds the refactored fake collector (25 cases).
ce1fce5, 45208ba The fragment, and the wording without the temporary list	tools/bump-version.py --check passes; the five guards pass with GITHUB_BASE_REF=main.

Review round 1:

Commit	Result
291c23f Tests of two refactored branches	An unknown Hugging Face hand-over command raises ValueError; a 403 to the events request makes only that run local with collector_authorization_rejected, keeps its events and asks the collector nothing more. Red: each failed when its branch was changed in a scratch copy (the command answered; the 403 handled as another client error). Green: both pass.
30d26bd The review's other points	The stage and hand_over test helpers raise TypeError for an option they don't read. The four test suppressions say they are pytest test functions. _ReleaseOrder stays frozen with a read-only mapping, and the commit message uses a copy. One shared client-error check, and HTTPStatus members. ruff check ., ruff format --check . and the guards pass; the 23 tests that call the two helpers and the two new tests pass (27 cases).

No other test was run locally: the package refactors are left to CI's test jobs.

CI

No workflow, trigger or script changes, and no environment variable or secret is read differently.

Release

The fragment is changelog.d/ruff-complexity.changed.md. With #65's added fragment below it in the stack, merging releases a minor version (0.12.0); on its own this fragment would give a patch bump.

🤖 Generated with Claude Code