Fix dispel border toggles breaking the debuffs and dispels indicators - #7
Open
KharchenkoDmitriy wants to merge 1 commit into
Open
Fix dispel border toggles breaking the debuffs and dispels indicators#7KharchenkoDmitriy wants to merge 1 commit into
KharchenkoDmitriy wants to merge 1 commit into
Conversation
Author
|
There was also thikness slider issue Included the fix |
Retail's HandleIndicators applies "showDispelBorder" (debuffs) and "showDispelFrameBorder" (dispels) together with the thickness when an indicator is created; the Cata/Wrath, Mists and Vanilla/TBC copies only called SetThickness, so the dispel-type border came back on at every indicator (re)creation - the first group after a reload, a layout switch - regardless of the setting. Ported retail's block to the three files. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011YngV4VgYFwrPdgvWYVz7p
KharchenkoDmitriy
force-pushed
the
fix/dispel-border-refresh
branch
from
September 1, 2026 05:44
6cbd3d2 to
2108c39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Show dispel-type border" (debuffs) and "Show frame border" (dispels) checkbuttons fire UpdateIndicators with setting == "checkbutton", but neither UnitButton_*.lua's UpdateIndicators had a branch for them, so both fell through to the catch-all:
For debuffs that clobbers the dispellableByMe filter, so ticking the box silently hid every debuff the player cannot dispel. For dispels it is worse: indicatorBooleans["dispels"] holds the filter table, so replacing it with a boolean makes the next aura update error out on indicatorBooleans["dispels"]["dispellableByMe"] and the whole indicator stops working. Neither toggle actually reached the border it names.
Handle both explicitly instead:
Applied to all flavors: UnitButton.lua, UnitButton_Cata_Wrath.lua, UnitButton_Mists.lua and UnitButton_Vanilla.lua (also used by TBC).