Skip to content

Fix dispel border toggles breaking the debuffs and dispels indicators #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KharchenkoDmitriy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix dispel border toggles breaking the debuffs and dispels indicators #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions RaidFrames/UnitButton_Cata_Wrath.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,12 +228,26 @@ local function HandleIndicators(b)
P.Size(indicator, t["size"][1], t["size"][2])
end
end
-- update thickness
-- update thickness (+ dispel border on/off for debuffs, "off" = 0 thickness)
--! same as retail UnitButton.lua: without this the dispel-type border came back on every time the
--! indicators were (re)created - first group after a reload, layout switch - whatever the setting.
if t["thickness"] then
indicator:SetThickness(t["thickness"])
if t["indicatorName"] == "debuffs" then
if indicator.SetBorder then
local on = t["showDispelBorder"] ~= false
indicator:SetBorder(on and t["thickness"] or 0)
end
elseif t["indicatorName"] == "dispels" then
if indicator.SetFrameBorderThickness then
indicator:SetFrameBorderThickness(t["thickness"])
indicator:SetFrameBorderEnabled(t["showDispelFrameBorder"] == true)
end
else
indicator:SetThickness(t["thickness"])
end
end
-- update border
if t["border"] then
if t["border"] and indicator.SetBorder then
indicator:SetBorder(t["border"])
end
-- update height
Expand Down
20 changes: 17 additions & 3 deletions RaidFrames/UnitButton_Mists.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,12 +249,26 @@ local function HandleIndicators(b)
P.Size(indicator, t["size"][1], t["size"][2])
end
end
-- update thickness
-- update thickness (+ dispel border on/off for debuffs, "off" = 0 thickness)
--! same as retail UnitButton.lua: without this the dispel-type border came back on every time the
--! indicators were (re)created - first group after a reload, layout switch - whatever the setting.
if t["thickness"] then
indicator:SetThickness(t["thickness"])
if t["indicatorName"] == "debuffs" then
if indicator.SetBorder then
local on = t["showDispelBorder"] ~= false
indicator:SetBorder(on and t["thickness"] or 0)
end
elseif t["indicatorName"] == "dispels" then
if indicator.SetFrameBorderThickness then
indicator:SetFrameBorderThickness(t["thickness"])
indicator:SetFrameBorderEnabled(t["showDispelFrameBorder"] == true)
end
else
indicator:SetThickness(t["thickness"])
end
end
-- update border
if t["border"] then
if t["border"] and indicator.SetBorder then
indicator:SetBorder(t["border"])
end
-- update height
Expand Down
20 changes: 17 additions & 3 deletions RaidFrames/UnitButton_Vanilla.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,12 +214,26 @@ local function HandleIndicators(b)
P.Size(indicator, t["size"][1], t["size"][2])
end
end
-- update thickness
-- update thickness (+ dispel border on/off for debuffs, "off" = 0 thickness)
--! same as retail UnitButton.lua: without this the dispel-type border came back on every time the
--! indicators were (re)created - first group after a reload, layout switch - whatever the setting.
if t["thickness"] then
indicator:SetThickness(t["thickness"])
if t["indicatorName"] == "debuffs" then
if indicator.SetBorder then
local on = t["showDispelBorder"] ~= false
indicator:SetBorder(on and t["thickness"] or 0)
end
elseif t["indicatorName"] == "dispels" then
if indicator.SetFrameBorderThickness then
indicator:SetFrameBorderThickness(t["thickness"])
indicator:SetFrameBorderEnabled(t["showDispelFrameBorder"] == true)
end
else
indicator:SetThickness(t["thickness"])
end
end
-- update border
if t["border"] then
if t["border"] and indicator.SetBorder then
indicator:SetBorder(t["border"])
end
-- update height
Expand Down