No frames are shown when accept party in combat

[KharchenkoDmitriy]

Solo Frames are unmounted when you accept party
And if you are in combat party frames mount only after combat is finished
It result is a state when you dont see any frames until you finished combat

Not critical, but pretty annoying
Can make a PR for Classic version (+wrath, MoP and Cata)

[NeeRgY]

Good question, I'd have to take a look at it.

But if you've already figured it out, feel free to create a PR, and I'll take a look at it.

[KharchenkoDmitriy]

Created a PR
#6
The solution generated by AI, but the logic it applies sound reasonable
Instead of relying on register/unregister, instead it applies visibility with condition (like ElvUI does)

P.S. There is a regression issue for this fix, I'll investigate
P.S.2 Looks like the issue was the packaging script changes on next screenshots are the fix for that

And AI for some reason deceded to add another option for Wrath aniversary, not sure if it make sense, just drop it here if its usefull

[NeeRgY]

Moved from #7

The problem is that the setting to disable it never applies (tested on TBC)
Made a fix (by AI)

So I took a look at both, and both can be fixed. But unfortunately, I have to tweak PR #6 a bit. The problem is that if I implement it that way, I’ll break the Retail version, since everything is in one file for Retail, Classic, etc.
I’m going to get started on implementing all of this now, but a little differently than you did.

[KharchenkoDmitriy]

Sure, you can implement in any way you like
I've created PR just to give a hint on where to look into as I anyway make a fix locally to play until next release)

[NeeRgY]

Thanks! Yeah, I found all of that, and everything looks right :)
But if I insert it from PR6 like that, I'll mess up all the fixes for Retail.
I'll release a new version tonight (r277.9.8.3) with the fixes. Feel free to test it out and let me know again if everything worked out :)

[NeeRgY]

I just released a new version. Please try it out in the latest version to see if everything works as it should^^

[KharchenkoDmitriy]

tested on TBC
party combat bug:

[reproduced]:

1. got invited before combat
2. start combat
3. accept invitation
4. frames disapeared

[working]:

1. started combat
2. got invited and accepted
3. frames are updated properly

So it can be two reasons that reproduce it:

• getting invited before combat (less probable)
• first time (after each reload) you got a party it still have unregistred frames but after you leave parte they are still there and loaded once you are again in party

the dispel border:
mostly the same issue
first time after reload, its enabled no matter the option in config
once get into party first time, it got reset in "enabled" state
next time got into a party it work as configured

Retested my local fixes - the same issues

[KharchenkoDmitriy]

Updated PRs, to fix the findings
Tested, after reload both bugs are gone
Also added another PR for release build script fix

[NeeRgY]

All right, I'll go over everything again and see how I can incorporate it.
I also received a few LUA error reports for TBC on Discord. I'll fix those as well.

[KharchenkoDmitriy]

For Lua errors take a look on release script PR, it corrupt tbc classic package when built (replacing ]== is the issue)

[NeeRgY]

So, I'll be releasing an update later with some fixes for TBC. I played TBC myself again and noticed in the code that my retail fixes had broken a lot of things in TBC. I've tried to fix those issues now.
I think the new version should fix quite a few things and get everything working again.
If anything is still not working after that, feel free to let me know.

[KharchenkoDmitriy]

wow , I didnt know targeted spell was such a thing, feels so much better now
Dispell debuffs looks good now

[KharchenkoDmitriy]

as for combat bug, still frames disapear when i leave party in combat

[NeeRgY]

Can you turn on the debug console while that's happening?
And then send me whatever shows up there?

[KharchenkoDmitriy]

10:39:21 GroupTypeChanged: solo
10:39:21 F.UpdateLayout("solo") DELAYED
10:39:21 PermissionChanged
10:39:27 F.UpdateLayout("solo")
10:39:27 UpdateLayout: layout: default  which: nil
10:39:27 UpdateIndicators:  nil nil nil nil nil
10:39:27   -> NO FULL UPDATE: only reset custom indicator tables