Skip to content

git: Track images in git lfs #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nv-jakob wants to merge 1 commit into
base: main
Choose a base branch
from
Open

git: Track images in git lfs #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0

# Images and PDFs are tracked by default.
*.gif filter=lfs diff=lfs merge=lfs -text
*.pdf filter=lfs diff=lfs merge=lfs -text
*.svg filter=lfs diff=lfs merge=lfs -text
*.png filter=lfs diff=lfs merge=lfs -text
*.jpeg filter=lfs diff=lfs merge=lfs -text

# Exceptions for small files.
deps/cloudxr/webxr_client/public/*.svg -filter -diff -merge text
Comment on lines +1 to +12

@coderabbitai coderabbitai Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Search for .jpg files in the repository (case-insensitive glob)
fd -e jpg -e JPG -e Jpg . || true
echo "---"
# Also check git status to see if any .jpg files are tracked
git ls-files '*.jpg' '*.JPG' 2>/dev/null | head -20 || true

Repository: NVIDIA/IsaacTeleop

Length of output: 216

🏁 Script executed:

#!/bin/bash
set -euo pipefail

jpgs=(
  "docs/source/_static/isaac-teleop-hero.jpg"
  "docs/source/_static/isaaclab.jpg"
)

for f in "${jpgs[@]}"; do
  echo "== $f =="
  if [ -f "$f" ]; then
    echo "size(bytes): $(wc -c < "$f")"
    echo "first_lines:"
    head -n 5 "$f" | sed 's/^/  /'
    if head -n 1 "$f" | rg -q "git-lfs.github.com/spec/v1"; then
      echo "LFS_pointer: yes"
    else
      echo "LFS_pointer: no"
    fi
  else
    echo "missing"
  fi
done

# If git-lfs is available, show status for these files (non-fatal if not)
if command -v git-lfs >/dev/null 2>&1; then
  echo "== git lfs ls-files (filtered) =="
  git lfs ls-files | rg -n "isaac-teleop-hero\.jpg|isaaclab\.jpg" || true
else
  echo "git-lfs not available in this environment"
fi

Repository: NVIDIA/IsaacTeleop

Length of output: 4363

Add *.jpg to Git LFS tracking in .gitattributes

.gitattributes tracks *.jpeg but not *.jpg; the repo contains docs/source/_static/isaac-teleop-hero.jpg and docs/source/_static/isaaclab.jpg, and they are not Git LFS pointers, so they’ll remain regular Git blobs. Add a *.jpg filter=lfs diff=lfs merge=lfs -text rule to match *.jpeg.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.gitattributes around lines 1 - 12, The .gitattributes currently tracks
*.jpeg but not *.jpg; add a rule matching *.jpg with the same LFS attributes to
ensure files like docs/source/_static/isaac-teleop-hero.jpg and isaaclab.jpg are
stored as LFS pointers. Update the .gitattributes by adding a line analogous to
the existing "*.jpeg filter=lfs diff=lfs merge=lfs -text" entry (i.e., "*.jpg
filter=lfs diff=lfs merge=lfs -text") so both extensions are handled
consistently.

Binary file modified docs/source/_static/cloudxr-run-output.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/source/_static/cloudxr-web-client-howto.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/source/_static/cloudxr_accept_cert_accepted.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/source/_static/cloudxr_accept_cert_not_private.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/source/_static/full-body-replay.gif
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion docs/source/_static/hardware-req-01.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion docs/source/_static/hardware-req-02.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion docs/source/_static/hardware-req-03.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion docs/source/_static/hardware-req-04.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion docs/source/_static/isaac-teleop-architecture.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/source/_static/isaacros.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading