Skip to content

git: Track images in git lfs#669

Open
nv-jakob wants to merge 1 commit into
mainfrom
jakob/git-lfs
Open

git: Track images in git lfs#669
nv-jakob wants to merge 1 commit into
mainfrom
jakob/git-lfs

Conversation

@nv-jakob

@nv-jakob nv-jakob commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Configured Git LFS tracking for image and PDF files to improve repository performance and file management.

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR adds a .gitattributes configuration file to enable Git LFS (Large File Storage) tracking for common binary assets—specifically .gif, .pdf, .svg, .png, and .jpeg files. The configuration includes an exception for small SVG files under deps/cloudxr/webxr_client/public/ to prevent unnecessary LFS attribute handling for that subset.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately describes the main change: adding a .gitattributes file to configure Git LFS tracking for image and PDF formats.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jakob/git-lfs

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.gitattributes:
- Around line 1-12: The .gitattributes currently tracks *.jpeg but not *.jpg;
add a rule matching *.jpg with the same LFS attributes to ensure files like
docs/source/_static/isaac-teleop-hero.jpg and isaaclab.jpg are stored as LFS
pointers. Update the .gitattributes by adding a line analogous to the existing
"*.jpeg filter=lfs diff=lfs merge=lfs -text" entry (i.e., "*.jpg filter=lfs
diff=lfs merge=lfs -text") so both extensions are handled consistently.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 8ae84000-ca6c-421c-b2a1-69e5237d05e0

📥 Commits

Reviewing files that changed from the base of the PR and between 7c59db3 and c33a62d.

⛔ Files ignored due to path filters (11)
  • docs/source/_static/cloudxr-run-output.png is excluded by !**/*.png
  • docs/source/_static/cloudxr-web-client-howto.png is excluded by !**/*.png
  • docs/source/_static/cloudxr_accept_cert_accepted.png is excluded by !**/*.png
  • docs/source/_static/cloudxr_accept_cert_not_private.png is excluded by !**/*.png
  • docs/source/_static/full-body-replay.gif is excluded by !**/*.gif
  • docs/source/_static/hardware-req-01.svg is excluded by !**/*.svg
  • docs/source/_static/hardware-req-02.svg is excluded by !**/*.svg
  • docs/source/_static/hardware-req-03.svg is excluded by !**/*.svg
  • docs/source/_static/hardware-req-04.svg is excluded by !**/*.svg
  • docs/source/_static/isaac-teleop-architecture.svg is excluded by !**/*.svg
  • docs/source/_static/isaacros.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • .gitattributes

Comment thread .gitattributes
Comment on lines +1 to +12
# SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0

# Images and PDFs are tracked by default.
*.gif filter=lfs diff=lfs merge=lfs -text
*.pdf filter=lfs diff=lfs merge=lfs -text
*.svg filter=lfs diff=lfs merge=lfs -text
*.png filter=lfs diff=lfs merge=lfs -text
*.jpeg filter=lfs diff=lfs merge=lfs -text

# Exceptions for small files.
deps/cloudxr/webxr_client/public/*.svg -filter -diff -merge text

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Search for .jpg files in the repository (case-insensitive glob)
fd -e jpg -e JPG -e Jpg . || true
echo "---"
# Also check git status to see if any .jpg files are tracked
git ls-files '*.jpg' '*.JPG' 2>/dev/null | head -20 || true

Repository: NVIDIA/IsaacTeleop

Length of output: 216


🏁 Script executed:

#!/bin/bash
set -euo pipefail

jpgs=(
  "docs/source/_static/isaac-teleop-hero.jpg"
  "docs/source/_static/isaaclab.jpg"
)

for f in "${jpgs[@]}"; do
  echo "== $f =="
  if [ -f "$f" ]; then
    echo "size(bytes): $(wc -c < "$f")"
    echo "first_lines:"
    head -n 5 "$f" | sed 's/^/  /'
    if head -n 1 "$f" | rg -q "git-lfs.github.com/spec/v1"; then
      echo "LFS_pointer: yes"
    else
      echo "LFS_pointer: no"
    fi
  else
    echo "missing"
  fi
done

# If git-lfs is available, show status for these files (non-fatal if not)
if command -v git-lfs >/dev/null 2>&1; then
  echo "== git lfs ls-files (filtered) =="
  git lfs ls-files | rg -n "isaac-teleop-hero\.jpg|isaaclab\.jpg" || true
else
  echo "git-lfs not available in this environment"
fi

Repository: NVIDIA/IsaacTeleop

Length of output: 4363


Add *.jpg to Git LFS tracking in .gitattributes

.gitattributes tracks *.jpeg but not *.jpg; the repo contains docs/source/_static/isaac-teleop-hero.jpg and docs/source/_static/isaaclab.jpg, and they are not Git LFS pointers, so they’ll remain regular Git blobs. Add a *.jpg filter=lfs diff=lfs merge=lfs -text rule to match *.jpeg.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.gitattributes around lines 1 - 12, The .gitattributes currently tracks
*.jpeg but not *.jpg; add a rule matching *.jpg with the same LFS attributes to
ensure files like docs/source/_static/isaac-teleop-hero.jpg and isaaclab.jpg are
stored as LFS pointers. Update the .gitattributes by adding a line analogous to
the existing "*.jpeg filter=lfs diff=lfs merge=lfs -text" entry (i.e., "*.jpg
filter=lfs diff=lfs merge=lfs -text") so both extensions are handled
consistently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant