Skip to content

fix(style): the Explorer's address row wears the sidebar colour (#306) - #307

Merged
Maxaubert merged 2 commits into
mainfrom
fix/306-address-row-colour
Oct 7, 2026
Merged

Maxaubert merged 2 commits into
mainfrom
fix/306-address-row-colour

Conversation

@Maxaubert

Copy link
Copy Markdown
Owner

Closes #306

What

  • The Explorer's address row (back, forward, up, refresh, the address field, the preview toggle and search, across the whole window) is painted --p-side, the sidebar colour the places panel, the project tree and the Settings rail wear since fix(style): a plain Colours heading; the Explorer sidebar wears the sidebar colour (#302) #303. Its bottom hairline stays. Over an opened file, .browse-viewer-toolbar wears the same colour. Still one coat per pixel: the row is its own grid cell, nothing under it paints.
  • The address field's fill and edge are now stepped off the ROW's ground (--p-side-flat) instead of the page's. MEASURED before the change: the field sat at 1.01:1 against the new row on every dark style (it was a step off the page, the row a step off it the other way), so only its edge gave it a shape. Near-black is still judged by the page (nearBlackField(bg, text, row)), so Aurora and Void keep their quiet field. Light styles keep the 9% control step, now off the row.
  • The archive crumb icon's knockout follows the field (--p-field), which it sits on.
  • Version 0.92.1 -> 0.92.2. CLAUDE.md: the fix(style): a plain Colours heading; the Explorer sidebar wears the sidebar colour (#302) #303 sidebar rule extended with this.

Why

Owner, 2026-10-07, after the address-row mockup: "yes make this the same color as the sidebar".

Gates

  • npm run typecheck: clean
  • npm run lint: 0 errors (7 existing warnings)
  • npx vitest run: 2528 passed, 2 skipped (170 files); new unit tests: the field stands off the row on every shipped style, near-black judged by the page
  • e2e, one at a time: sidebarGround (extended: on Void, Paper, Aurora and Glacier the address row's ground equals the places panel's and the Settings rail's and differs from the list's, the hairline is kept and the field is not the row's colour; the new checks FAIL on main's CSS, 12 failures), seeThrough (already measures one coat on the Explorer address bar and the viewer's), panelsAlign, addressField (Void/Paper fill checks now measured against the row), searchPopup, settingsLook: all green
  • npm run e2e:terminal: 17 scenarios green, 553 checks (helpPanel in that list matches no scenario on main either)
  • Screenshots looked at: .e2e/shots/address-row-{aurora,new-void,paper}.png

The project tab's file view has no address row of its own; a folder shown there is the same folder browser, so it follows.

May conflict trivially with open PR #305 in browse.css.

🤖 Generated with Claude Code

https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t
@Maxaubert
Maxaubert merged commit 7153b3f into main Oct 7, 2026
3 checks passed
@Maxaubert
Maxaubert deleted the fix/306-address-row-colour branch October 7, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explorer: the address row wears the sidebar colour

1 participant