Repository navigation
fix(style): the Explorer's address row wears the sidebar colour (#306) - #307
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t
This was referenced Oct 7, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #306
What
--p-side, the sidebar colour the places panel, the project tree and the Settings rail wear since fix(style): a plain Colours heading; the Explorer sidebar wears the sidebar colour (#302) #303. Its bottom hairline stays. Over an opened file,.browse-viewer-toolbarwears the same colour. Still one coat per pixel: the row is its own grid cell, nothing under it paints.--p-side-flat) instead of the page's. MEASURED before the change: the field sat at 1.01:1 against the new row on every dark style (it was a step off the page, the row a step off it the other way), so only its edge gave it a shape. Near-black is still judged by the page (nearBlackField(bg, text, row)), so Aurora and Void keep their quiet field. Light styles keep the 9% control step, now off the row.--p-field), which it sits on.Why
Owner, 2026-10-07, after the address-row mockup: "yes make this the same color as the sidebar".
Gates
npm run typecheck: cleannpm run lint: 0 errors (7 existing warnings)npx vitest run: 2528 passed, 2 skipped (170 files); new unit tests: the field stands off the row on every shipped style, near-black judged by the pagesidebarGround(extended: on Void, Paper, Aurora and Glacier the address row's ground equals the places panel's and the Settings rail's and differs from the list's, the hairline is kept and the field is not the row's colour; the new checks FAIL on main's CSS, 12 failures),seeThrough(already measures one coat on the Explorer address bar and the viewer's),panelsAlign,addressField(Void/Paper fill checks now measured against the row),searchPopup,settingsLook: all greennpm run e2e:terminal: 17 scenarios green, 553 checks (helpPanelin that list matches no scenario on main either).e2e/shots/address-row-{aurora,new-void,paper}.pngThe project tab's file view has no address row of its own; a folder shown there is the same folder browser, so it follows.
May conflict trivially with open PR #305 in
browse.css.🤖 Generated with Claude Code
https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t