Repository navigation
feat(style): a preview button that shows its state, a quiet search, and an icon on every tab (#308) - #309
Merged
Conversation
…nd an icon on every tab (#308) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #308
What
BrowseIcon.tsxPreviewGlyph,FolderBrowser.tsx): the pane icon's right column is solid while the preview is open and empty while it is hidden. No accent and no background in any state; hover and focus as Back and Refresh.aria-pressedand the name "Preview pane" are unchanged. It is the only preview toggle in the app.browse.css,FolderBrowser.tsx): the accent rule for[data-active]is gone, so it stays grey while the popup is up and while the list shows a search.data-activestays as a mark for tests.TabKindIcon.tsx,TabStrip.tsx): every tab shows what it holds. Explorer tabs (pinned or not, Downloads-style included) get a folder, project tabs code brackets, Settings a gear. Solid on the active tab, lines on the rest, in the tab's own ink. The solid code tile's brackets are cut out with a mask, so glass and the agent's Full fill show through. This replaces the small folder-coloured glyph that only Explorer tabs had. The pin and the close button are unchanged, and the Full indicator's brain slot is still on project tabs.Why
Owner, 2026-10-07, choosing from
research/prism/2026-10-06-new-themes/toolbar-options.html: "A3 and C2". Before that: "i dont like the look of the buttons being colored ... default icons per type of page explorer, project and settings".Gates
npm run e2e:terminal: 553 checks, all passed.toolbarIconsscenario against main'ssrcand it failed 169 checks: the accent preview and search buttons, no glyph state, and no icons on project and Settings tabs.Note
This may conflict with the open PRs #305 and #307 in
BrowseToolbar.tsx/browse.css.🤖 Generated with Claude Code
https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t