Skip to content

fix(style): Void is black in the sidebar and tab bar too (#313) - #315

Merged
Maxaubert merged 3 commits into
mainfrom
fix/313-void-black
Oct 7, 2026
Merged

Maxaubert merged 3 commits into
mainfrom
fix/313-void-black

Conversation

@Maxaubert

Copy link
Copy Markdown
Owner

Closes #313.

Owner, 2026-10-07, of Settings > Appearance > Colours on Void (Background #000000, Sidebar and tab bar colour #070707): "make void fully black for both of these".

What changed

  • Void's panel is #000000 (themes/catalogue.json): the sidebar, title bar, tab strip, active tab, Explorer places panel and Settings rail are now the black of the ground. Nothing else in Void moves: its raised step (#0f0f10, menus), line (#151516), faint edges (still drawn, so panels stay apart), selection tints and the address field are unchanged, and every other theme is untouched.
  • A saved edit the theme has caught up with is no edit (theme.ts, withoutOwn): Prism already drops a colour put back to the theme's own when it is WRITTEN, but a draft already in storage was never re-judged. At load (and on a storage event from another window) each draft colour that now equals the theme's own is dropped, and the settled draft is written back. So the owner's hand-set #000000 on Void now opens with no Reset link and Save changes not lit. An edit that still differs stays an edit. The chrome check is shared with withColour (chromeIsOwn).
  • Tests: theme.voidBlack.test.ts (Void's panel tokens are black, edges/menus/selection still off the black, Void is the only theme whose panel is its ground, withoutOwn pure cases, and a store reload with the owner's draft reading as no edit). The sidebarGround e2e now asserts Void's places panel and list are EQUAL (both rgb(0, 0, 0)), keeps "differs" on Paper, Aurora and Glacier, and saves a settled Settings shot per theme (sidebar-ground-settings-<style>.png).
  • Version 0.92.1 -> 0.92.2. CLAUDE.md: the Settings: a plain Colours section title; the Explorer sidebar wears the sidebar colour #302 sidebar rule now names Void as the all-black exception, with the owner's words.

Gates

  • typecheck: clean. lint: 0 errors (7 existing warnings).
  • unit: 2534 passed, 2 skipped (172 files).
  • e2e, one at a time: sidebarGround 14/14, styleColours 43/43, themeWall 46/46 (one earlier run failed its frame-time check at 56ms after Orchid, a see-through theme, not Void; two reruns passed at 49ms), themeLooks 6/6, settingsLook 189/189, seeThrough 26/26, addressField 23/23, e2e:terminal 553 checks, 0 failures.
  • Looked at the Explorer and Settings on Void: all black, panels separated by the faint hairlines, address field and buttons visible, no Reset, Save changes not lit.

Note

Open PR #307 checks Void's address row against the places panel; with both landed those are the same black, so its Void expectation will need updating.

🤖 Generated with Claude Code

https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t

Maxaubert and others added 3 commits October 7, 2026 04:40
Void's panel colour (sidebar, title bar, tab bar) is #000000, its ground,
by the owner's word. A saved draft colour the theme has since caught up
with is dropped at load, so a hand-set black on Void is no edit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t
Owner, 2026-10-07, of the drive tiles on Void: "these dont look great on void
its too much of a contrast". A sidebar that is black or near it sets
data-side=black on the root, and the tiles, chips, hover and track take about
half the step there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t
Keeps both sides: main's address row in the sidebar colour (#306) and
Void's all-black panel. Void's row is now #000000, so the field test and
the sidebarGround e2e expect that and skip row !== list for Void.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t
@Maxaubert
Maxaubert merged commit b00e559 into main Oct 7, 2026
3 checks passed
@Maxaubert
Maxaubert deleted the fix/313-void-black branch October 7, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Void: the sidebar and tab bar are black too

1 participant