feat: use independent Core plan toggles across agents - #503
Conversation
Model: gpt-6
Model: gpt-6
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 913978b46d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const KIMI_STATIC_CONFIG_OPTIONS: AcpConfigOptionSummary[] = [ | ||
| { ...createPlanModeConfigOption(false), options: [] }, | ||
| { | ||
| id: 'mode', | ||
| name: 'Mode', | ||
| category: 'mode', | ||
| id: 'permission_mode', |
There was a problem hiding this comment.
Ship the Kimi runtime before exposing its new config IDs
For a builtin Kimi config without an authoritative capability cache, these static options drive the chat/onboarding selection, but this commit leaves apps/cli/src/agent/kimi-runtime-manifest.json unchanged at the old 0.39.1-lody.f255222661c9 artifact. Since the Kimi submodule is isolated and Lody launches only that checksummed artifact, updating its gitlink does not make plan_mode or permission_mode available; a fresh session can therefore offer Plan + YOLO and then send configuration IDs the installed wrapper does not advertise, so the requested mode will not take effect. Update the runtime manifest and checksum in this change, or withhold the new static Kimi options until that artifact is available.
AGENTS.md reference: AGENTS.md:L68-L70
Useful? React with 👍 / 👎.
* fix: keep Grok plan review interactive under Always Approve Model: gpt-6 * chore: update Grok submodule to merged plan review Model: gpt-6
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 47074038c6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| : undefined; | ||
|
|
||
| const DEEPSEEK_HARNESS_CONFIG_OPTIONS: AcpConfigOptionSummary[] = [ | ||
| { ...createPlanModeConfigOption(false), options: [] }, |
There was a problem hiding this comment.
Hide Plan when the selected DSH preset lacks it
For a fresh or otherwise unprobed DeepSeek Harness target, this provisional static table always exposes plan_mode, even after the user selects the minimal agent_preset. That preset's runtime composition removes the Plan service, but selector construction does not vary these static options by the selected preset, so the UI retains and dispatches a usable-looking Plan value that the resulting agent cannot apply. Make the provisional capability depend on the selected preset, or withhold Plan until an authoritative probe confirms the service.
Useful? React with 👍 / 👎.
* fix: integrate Grok YOLO permission fallback Model: gpt-6 * docs: link Grok permission fallback pull requests Model: gpt-6 * chore: pin merged Grok permission fallback Model: gpt-6 --------- Co-authored-by: Leeeon233 <leeeon233@gmail.com>
Related issue
Refs #133
Problem / pressure
Kimi's combined Plan/permission selector prevents Plan and YOLO from being selected together. Lody also treats Codex's
collaboration_modevocabulary as the shared planning interface.Summary
Use Core's
plan_mode: booleanacross Codex, Kimi, Grok, and supported DSH presets while leaving Claude's permission-based Plan unchanged. Translate historical selections at read/dispatch boundaries, preserve explicit boolean choices, and turn Plan off for the next execution turn without changing permissions. Add a draft Spec and a decision note.Dependencies: Core #5, Codex #34, Grok #13, DSH #12, and Kimi #8. All five submodule PRs are merged, and this PR pins their default-branch merge commits. Claude was already current. The six submodule source trees are identical to the previously tested versions.
Keep this PR in draft until Core and the wrapper releases are available, and the published Kimi managed-runtime checksum is added. The local preview artifact is not a production runtime update.
Before / after
Test plan
pnpm checkpassed in full.pnpm formatran andpnpm run docs checkpassed; see the decision note for detailed results.Context handoff
Instructions for reviewing agents
Authoring context