fix: integrate Grok YOLO permission fallback and remove Auto - #533
Conversation
Model: gpt-6
Model: gpt-6
Model: gpt-6
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 817082a6b1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1 +1 @@ | |||
| Subproject commit f3f59e1a4528e5e201b24eccb4b3548987bbcc67 | |||
| Subproject commit c962338e3e6e68858e0bf92e9671a84b9a07e055 | |||
There was a problem hiding this comment.
Confirm effective YOLO before auto-approving requests
When a managed Grok policy refuses to enable YOLO, the adapter still records the requested always-approve value locally because _x.ai/yolo_mode_changed has no acknowledgement; the new handler then trusts that optimistic value and automatically selects allow_once or even persistent allow_always for requests the runtime left interactive. This bypasses the policy's approval boundary, so interception must depend on confirmed effective YOLO state or leave the request interactive when confirmation is unavailable.
AGENTS.md reference: AGENTS.md:L132-L134
Useful? React with 👍 / 👎.
Related issue
Refs #503
#503 is a stack dependency (independent Plan mode), not an issue to close. Companion adapter PR: LodyAI/acp-extension-grok#15.
Problem / pressure
Grok can still emit tool permission requests while Always Approve is selected. Forwarding these to Lody can expose a pending approval UI before the host responds, and Auto remains selectable despite lacking a reliable acknowledgement contract.
Summary
allow_once, thenallow_always.This PR targets
feat/independent-plan-mode(#503), preserving Core 0.1.1 and explicit Plan approval. The companion Grok PR #15 is merged; this PR pins its merge commitc962338e. Merge #503 before this integration.Before / after
Test plan
pnpm --dir packages/acp-extension-grok run buildpassed syntax checks.git diff --checkpassed.pnpm run docs checkpassed with existing AGENTS-size warnings.pnpm checkandpnpm formatwere attempted but this nested worktree has no root node_modules (tsgoandprettiermissing respectively).Context handoff
Instructions for reviewing agents
Authoring context