fix: keep Grok plan review interactive under Always Approve - #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Refs #133
Problem / pressure
Grok plan review uses a mode-switch permission decision. Lody's Always Approve policy previously approved every non-question request, which would silently approve the new plan review.
Summary
Keep Grok
switch_modedecisions interactive, including requests already waiting when Always Approve is enabled. Update the Grok submodule to acp-extension-grok#14, which bridges native plan content, approval, and optional revision feedback through existing ACP/Core contracts. Document the draft intent and rollout dependency.This PR is stacked on #503 (
feat/independent-plan-mode). Merge the companion adapter PR and ship it with a compatible host.Before / after
Test plan
pnpm checkpassed, including public boundary checks.pnpm formatcompleted; unrelated formatting was restored.pnpm run docs checkandgit diff --checkpassed.Context handoff
Instructions for reviewing agents
Authoring context