Skip to content

fix: keep Grok plan review interactive under Always Approve - #511

Merged
lodystage[bot] merged 2 commits into
feat/independent-plan-modefrom
feat/grok-plan-review
Sep 8, 2026
Merged

fix: keep Grok plan review interactive under Always Approve#511
lodystage[bot] merged 2 commits into
feat/independent-plan-modefrom
feat/grok-plan-review

Conversation

@Leeeon233

Copy link
Copy Markdown
Contributor

Related issue

Refs #133

Problem / pressure

Grok plan review uses a mode-switch permission decision. Lody's Always Approve policy previously approved every non-question request, which would silently approve the new plan review.

Summary

Keep Grok switch_mode decisions interactive, including requests already waiting when Always Approve is enabled. Update the Grok submodule to acp-extension-grok#14, which bridges native plan content, approval, and optional revision feedback through existing ACP/Core contracts. Document the draft intent and rollout dependency.

This PR is stacked on #503 (feat/independent-plan-mode). Merge the companion adapter PR and ship it with a compatible host.

Before / after

Before After
Native Grok plan review is ignored or could be automatically approved by the host. Plan content is displayed and implement/revise/abandon remains an explicit user decision, including under YOLO.

Test plan

  • Full pnpm check passed, including public boundary checks.
  • pnpm format completed; unrelated formatting was restored.
  • All 13 host permission tests and 51 Grok tests passed.
  • Grok build/typecheck and ACP SDK schema validation passed.
  • pnpm run docs check and git diff --check passed.
  • No live authenticated Grok turn or runtime publication.

Context handoff

Instructions for reviewing agents

  • Review focus: Check that new and queued Grok mode-switch requests remain interactive while ordinary tool approvals retain their current policy.
  • Decisions to challenge: The wrapper uses standard ACP plan, permission, and optional elicitation messages instead of adding a Core-specific approval RPC.
  • Plausible failures / evidence gaps: The new wrapper must ship with a compatible host; authenticated runtime behavior was not exercised end to end.

Authoring context

  • User goal / directives: Complete Grok plan-content and approval integration and open new pull requests.
  • Constraints / non-goals: Preserve the shared boolean Plan switch and independent permission setting; leave other providers unchanged.
  • Risk-bearing decisions: Exclude all Grok switch-mode decisions from Always Approve and retain explicit approval even for empty plans.
  • Destructive or irreversible behavior: No data migrations or cleanup; this changes request routing and a submodule pointer only.
  • Deliberately not done or tested: Runtime publication and live authenticated Grok execution are deferred to rollout validation.
  • Unknowns / confidence: Deterministic tests and full repository checks passed; deployment compatibility requires coordinating both PRs.

@lodystage
lodystage Bot marked this pull request as ready for review September 8, 2026 09:24
@lodystage
lodystage Bot merged commit 4707403 into feat/independent-plan-mode Sep 8, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant