Skip to content

Complete the reviewed Pebrel crate and compatibility migration - #947

Merged
Kuddev merged 12 commits into
mainfrom
review/owned-prs-integrated-20261111
Nov 16, 2026
Merged

Kuddev merged 12 commits into
mainfrom
review/owned-prs-integrated-20261111

Conversation

@Kuddev

@Kuddev Kuddev commented Nov 11, 2026

Copy link
Copy Markdown
Owner

Finish the reviewed Pebrel namespace migration from #927 and #928, based on the merged source-root gate #926. All original PR heads remain in the ancestry. Internal crates, paths and build commands use Pebrel names; legacy persisted data and protocol inputs remain readable.

The final review fixes interrupted/concurrent legacy data adoption by sharing settings migration's non-replacing file publication. Windows sync credential compatibility stays in one adapter, bringing platform cfg to 458/459 without a budget change. Historical PR review also recovers #801's missing native mouse-fixture keybinding initialization. The OpenCode bridge now uses the supported macOS 26 runner after GitHub rejected its retired macOS 14 configuration.

The combined diff is one completed identity migration, with 4,122 locally counted source lines and 1,800 changed/moved files. Its crate/path/import updates must resolve together. Use the existing maintainer-authorized size-exempt allowance below the unchanged 5,000-line ceiling; the GitHub file inventory is authoritative. Individual source reviews and tests are recorded on #926, #927 and #928.

Validation:

  • 346 script tests: 330 passed, 16 skipped.
  • Six production directory tests and 107 settings tests passed. The partial-directory and dangling-symlink regressions failed before the fix; settings tests cover interrupted and concurrent publication.
  • 18 Node notification-bridge tests passed.
  • Locked offline workspace metadata, formatting, architecture against 34795c0b, naming and whitespace checks passed.
  • Cargo.lock comparison after normalizing workspace names found unchanged versions, sources, checksums and dependency edges.
  • Full native CI on this final head is required before merge. The opt-in real-desktop mouse fixture was restored but not executed locally.

Merge with the existing administrator authorization after required checks pass, retaining ancestry so #927 and #928 are marked merged together.

The session registry and agent-detection overrides were still resolved
under the old Nebula directory, outside the startup migration. They now
live in the Pebrel data directory and are copied once from the old
location when missing. Imported fonts are also read from Nebula\fonts.

New writes use Pebrel names: sync secrets, the default theme key, backup
and workspace export extensions, and the environment variables the app
reads. Old names stay readable everywhere. Parsers also accept PEBREL|
titles and pebrel-hook envelopes; emitters keep the old markers so other
installed versions still receive them.
@Kuddev Kuddev added the size-exempt 维护者批准 1501–5000 行完整模块 PR / Reviewed size exception; max 5000 lines, other checks apply label Nov 11, 2026
@github-actions github-actions Bot added the size/XL >1500 行,需拆分 / must be split label Nov 11, 2026

@Kuddev Kuddev left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source review is complete. The final integration retains the reviewed #927 and #928 heads, fixes the data-adoption defects reproduced during review, restores #801's missing native-fixture setup, and replaces the rejected macOS 14 runner configuration.

The existing size exception is scoped to the atomic workspace namespace migration: local count 4,122 changed source lines, below the unchanged 5,000 ceiling. Architecture, 330 script tests (16 skipped), 107 settings tests, six directory tests and 18 Node bridge tests passed locally. Full native validation is running on this final commit.

The maintainer explicitly authorized administrator merging of self-authored PRs. This records the source review; GitHub cannot record an author approval. Merge is conditional on all final-head required checks passing.

@Kuddev
Kuddev changed the base branch from main to fix/pty-cell-size-startup-20261113 November 14, 2026 12:42
@Kuddev
Kuddev changed the base branch from fix/pty-cell-size-startup-20261113 to main November 16, 2026 02:46
@Kuddev
Kuddev merged commit b4e3497 into main Nov 16, 2026
26 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XL >1500 行,需拆分 / must be split size-exempt 维护者批准 1501–5000 行完整模块 PR / Reviewed size exception; max 5000 lines, other checks apply

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant