Skip to content

Write Pebrel names for stored data and keep reading the Nebula ones - #928

Merged
Kuddev merged 10 commits into
mainfrom
rename/3-compat-20261109
Nov 16, 2026
Merged

Kuddev merged 10 commits into
mainfrom
rename/3-compat-20261109

Conversation

@Kuddev

@Kuddev Kuddev commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

Use Pebrel names for new persisted settings, exports and environment readers while preserving legacy input compatibility. Shell-title and hook parsers accept both names; emitters keep their original markers so concurrently installed older clients continue receiving events.

Review fixes in 90df0ab9:

  • Reuse settings migration's non-replacing publication for AI session and agent-override files, preserving concurrent destination writes and symlinks.
  • Fill missing files in a partially adopted directory and report enumeration errors. Failed adoption retries on next process startup.
  • Group Windows sync credential names and fallback reads in one adapter; platform cfg is 458 against the unchanged 459 budget.

Validation on reviewed stack 9b299921:

  • Before the fix, partial-directory and dangling-symlink regressions failed; after it, all six directory tests passed.
  • All 107 settings tests passed, including publication failure and concurrent-destination tests.
  • 346 script tests: 330 passed, 16 skipped. Architecture, formatting and naming/whitespace checks passed.
  • Local Rust validation used standalone production modules; native CI covers the complete application and Windows-specific code.

This branch includes reviewed #926 and #927. The final integration will retain their commit ancestry and merge only after its required CI passes.

A `moved <old-root> <new-root>` record lets a whole root be renamed
without counting as a removed root. Against the base, every base source
file under the old root must reappear at the same relative path, the old
root must be gone, and allowances keep their base value and base size.

Records whose old root is no longer in the base do nothing and print a
removal notice, so the record cannot remap later PRs after the rename
lands.
The gate diffed each changed file with only its new path, so Git could
not pair a moved file with its old path and every line of it counted as
added. Moving a crate directory replayed every existing identifier.

List changes with rename detection and diff renamed files with both
paths, so only lines the move edits are checked. Added text in a moved
file is still rejected and reported under its new path.
Moving a source directory rewrites the notice line that names both the
adapted path and its upstream project, which the name check rejected.
Only in THIRD-PARTY-NOTICES, a trailing "derives from <Name>" is removed
before the check; the rest of the line and every other file are still
checked.
@github-actions github-actions Bot added the size/XL >1500 行,需拆分 / must be split label Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

This pull request changes 3998 source lines (default limit 1500, hard limit 5000; docs, lockfiles and assets excluded). Organize each PR around a complete, independently verifiable module. Split along cohesive boundaries when needed.

本 PR 改动 3998 行源码(默认门槛 1500,硬上限 5000,不计文档、lockfile、资源)。每个 PR 应以完整、可独立验证的功能模块为主;需要拆分时按职责边界拆分。

Maintainers may approve individual PRs up to 5000 lines with size-exempt. The hard ceiling and all other checks still apply. / 维护者可用 size-exempt 批准不超过 5000 行的个别 PR;硬上限及其他检查仍须满足。

The Rust test parses the same budget file and rejected any record with
three fields. It now accepts moved records and checks that the new root
is declared and the old root is gone; base-relative coverage stays with
check_architecture.py.
@Kuddev
Kuddev force-pushed the rename/3-compat-20261109 branch from 161912b to 9a4e3e3 Compare November 9, 2026 19:01
@Kuddev
Kuddev force-pushed the rename/3-compat-20261109 branch from 9a4e3e3 to 89ea178 Compare November 9, 2026 19:05
The session registry and agent-detection overrides were still resolved
under the old Nebula directory, outside the startup migration. They now
live in the Pebrel data directory and are copied once from the old
location when missing. Imported fonts are also read from Nebula\fonts.

New writes use Pebrel names: sync secrets, the default theme key, backup
and workspace export extensions, and the environment variables the app
reads. Old names stay readable everywhere. Parsers also accept PEBREL|
titles and pebrel-hook envelopes; emitters keep the old markers so other
installed versions still receive them.
@Kuddev
Kuddev force-pushed the rename/3-compat-20261109 branch from 89ea178 to 53a369a Compare November 9, 2026 19:08
@Kuddev
Kuddev marked this pull request as ready for review November 11, 2026 07:09
@Kuddev

Kuddev commented Nov 11, 2026

Copy link
Copy Markdown
Owner Author

The reviewed branch is retained in #947's commit ancestry. Final integration CI runs there against main, including the migration fixes and the supported macOS bridge runner. Redundant native runs on this intermediate head were cancelled; they are not counted as passing validation. Merge #947 only after its required checks pass, which will incorporate this PR without rewriting its history.

@Kuddev
Kuddev merged commit 9b29992 into main Nov 16, 2026
5 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XL >1500 行,需拆分 / must be split

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant