Repository navigation
Write Pebrel names for stored data and keep reading the Nebula ones - #928
Conversation
A `moved <old-root> <new-root>` record lets a whole root be renamed without counting as a removed root. Against the base, every base source file under the old root must reappear at the same relative path, the old root must be gone, and allowances keep their base value and base size. Records whose old root is no longer in the base do nothing and print a removal notice, so the record cannot remap later PRs after the rename lands.
The gate diffed each changed file with only its new path, so Git could not pair a moved file with its old path and every line of it counted as added. Moving a crate directory replayed every existing identifier. List changes with rename detection and diff renamed files with both paths, so only lines the move edits are checked. Added text in a moved file is still rejected and reported under its new path.
Moving a source directory rewrites the notice line that names both the adapted path and its upstream project, which the name check rejected. Only in THIRD-PARTY-NOTICES, a trailing "derives from <Name>" is removed before the check; the rest of the line and every other file are still checked.
|
This pull request changes 3998 source lines (default limit 1500, hard limit 5000; docs, lockfiles and assets excluded). Organize each PR around a complete, independently verifiable module. Split along cohesive boundaries when needed. 本 PR 改动 3998 行源码(默认门槛 1500,硬上限 5000,不计文档、lockfile、资源)。每个 PR 应以完整、可独立验证的功能模块为主;需要拆分时按职责边界拆分。 Maintainers may approve individual PRs up to 5000 lines with |
The Rust test parses the same budget file and rejected any record with three fields. It now accepts moved records and checks that the new root is declared and the old root is gone; base-relative coverage stays with check_architecture.py.
161912b to
9a4e3e3
Compare
9a4e3e3 to
89ea178
Compare
The session registry and agent-detection overrides were still resolved under the old Nebula directory, outside the startup migration. They now live in the Pebrel data directory and are copied once from the old location when missing. Imported fonts are also read from Nebula\fonts. New writes use Pebrel names: sync secrets, the default theme key, backup and workspace export extensions, and the environment variables the app reads. Old names stay readable everywhere. Parsers also accept PEBREL| titles and pebrel-hook envelopes; emitters keep the old markers so other installed versions still receive them.
89ea178 to
53a369a
Compare
|
The reviewed branch is retained in #947's commit ancestry. Final integration CI runs there against main, including the migration fixes and the supported macOS bridge runner. Redundant native runs on this intermediate head were cancelled; they are not counted as passing validation. Merge #947 only after its required checks pass, which will incorporate this PR without rewriting its history. |
Use Pebrel names for new persisted settings, exports and environment readers while preserving legacy input compatibility. Shell-title and hook parsers accept both names; emitters keep their original markers so concurrently installed older clients continue receiving events.
Review fixes in
90df0ab9:Validation on reviewed stack
9b299921:This branch includes reviewed #926 and #927. The final integration will retain their commit ancestry and merge only after its required CI passes.