Repository navigation
Rename the workspace crates and their directories to pebrel - #927
Conversation
A `moved <old-root> <new-root>` record lets a whole root be renamed without counting as a removed root. Against the base, every base source file under the old root must reappear at the same relative path, the old root must be gone, and allowances keep their base value and base size. Records whose old root is no longer in the base do nothing and print a removal notice, so the record cannot remap later PRs after the rename lands.
The gate diffed each changed file with only its new path, so Git could not pair a moved file with its old path and every line of it counted as added. Moving a crate directory replayed every existing identifier. List changes with rename detection and diff renamed files with both paths, so only lines the move edits are checked. Added text in a moved file is still rejected and reported under its new path.
Moving a source directory rewrites the notice line that names both the adapted path and its upstream project, which the name check rejected. Only in THIRD-PARTY-NOTICES, a trailing "derives from <Name>" is removed before the check; the rest of the line and every other file are still checked.
|
This pull request changes 3662 source lines (default limit 1500, hard limit 5000; docs, lockfiles and assets excluded). Organize each PR around a complete, independently verifiable module. Split along cohesive boundaries when needed. 本 PR 改动 3662 行源码(默认门槛 1500,硬上限 5000,不计文档、lockfile、资源)。每个 PR 应以完整、可独立验证的功能模块为主;需要拆分时按职责边界拆分。 Maintainers may approve individual PRs up to 5000 lines with |
The Rust test parses the same budget file and rejected any record with three fields. It now accepts moved records and checks that the new root is declared and the old root is gone; base-relative coverage stays with check_architecture.py.
ba035b2 to
2550c7f
Compare
2550c7f to
45c84eb
Compare
Kuddev
left a comment
There was a problem hiding this comment.
Reviewed the complete namespace migration and the merge with current main. No blocking source issue remains. Latest startup geometry and titlebar fixes are preserved, and normalized lockfile dependency graphs match.
Local validation: 330 script tests passed / 16 skipped; architecture, formatting, locked metadata, naming and whitespace passed. The existing size exception is appropriate for the atomic crate/path/import change (3,428 locally counted source lines; final GitHub count remains authoritative). No threshold is raised.
The maintainer has authorized administrator merging of self-authored PRs after required checks pass. GitHub cannot record an author approval; this comment records the completed source review and the authorization. Merge remains conditional on the final head's required CI.
|
The reviewed branch is retained in #947's commit ancestry. Final integration CI runs there against main, including the migration fixes and the supported macOS bridge runner. Redundant native runs on this intermediate head were cancelled; they are not counted as passing validation. Merge #947 only after its required checks pass, which will incorporate this PR without rewriting its history. |
Rename the nine internal workspace source roots and their Rust package/import references from
nebulatopebrel. Build commands, CI paths and architecture declarations follow the new names; stored data, protocol identifiers and compatibility environment inputs keep their existing behavior.The workspace rename is atomic: package names, paths and all cross-crate imports must resolve together. The reviewed local diff counts 3,428 source lines, below the existing 5,000-line absolute ceiling. The maintainer-authorized
size-exemptexception applies only to this cohesive namespace migration; no budgets or counting exclusions change.Review incorporated current main fixes, including window startup geometry, titlebars, Markdown reload, matrix parsing, recycle-bin handling and detached hook events. Cargo.lock comparison after normalizing only workspace package names confirms unchanged dependency versions, sources, checksums and dependency edges.
Validation on
0cc8c6af: