Avoid import-time crash from new NativeEventEmitter(Wallet) - #67
Merged
Merged
Conversation
MegaManSec
force-pushed
the
pr/jr-14-12361e0
branch
2 times, most recently
from
February 16, 2026 18:56
888ecc3 to
b510e3c
Compare
JakubKorytko
requested changes
Sep 29, 2026
JakubKorytko
left a comment
JakubKorytko
left a comment
Member
There was a problem hiding this comment.
fixes the iOS crash when the module isn't linked, but introduces a regression on Android. LGTM when addressed
Member
|
@MegaManSec, could you sign and rebase the last commit? I will re-approve but it lost its signature |
(cherry picked from commit 12361e0b98e92611e94a6b46d2bb95692acbfb77)
MegaManSec
force-pushed
the
pr/jr-14-12361e0
branch
from
September 29, 2026 20:38
161adb2 to
3ca1c0b
Compare
Member
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.