Skip to content

Avoid import-time crash from new NativeEventEmitter(Wallet) #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JakubKorytko merged 2 commits into from
Sep 30, 2026
Merged

Avoid import-time crash from new NativeEventEmitter(Wallet) #67

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e3e170
Avoid import-time crash from new NativeEventEmitter(Wallet)
MegaManSec Feb 3, 2026
3ca1c0b
Make addListener a no-op when module is not linked
MegaManSec Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,15 @@ function getModuleLinkingRejection() {
return Promise.reject(new Error(`Failed to load Wallet module, make sure to link ${PACKAGE_NAME} correctly`));
}

const eventEmitter = new NativeEventEmitter(Wallet);
let eventEmitter: NativeEventEmitter | undefined;

function addListener(event: string, callback: (data: onCardActivatedPayload) => void): EmitterSubscription {
if (!Wallet) {
// eslint-disable-next-line no-console
console.warn(`[${PACKAGE_NAME}] Wallet module is not linked, addListener has no effect`);
return {remove: () => undefined} as EmitterSubscription;
}
eventEmitter ??= new NativeEventEmitter(Wallet);
return eventEmitter.addListener(event, callback);
}

Expand Down
Loading