Make addCardToAppleWallet fail consistently when module is not linked - #62
Merged
Merged
Conversation
MegaManSec
force-pushed
the
pr/jr-13-6f8ad2a
branch
from
February 16, 2026 18:52
221b913 to
9ab0f4e
Compare
(cherry picked from commit 6f8ad2aa92a14a3999fb5f2852b9b6ac1fdb1f9f)
MegaManSec
force-pushed
the
pr/jr-13-6f8ad2a
branch
from
February 16, 2026 18:56
9ab0f4e to
c1e4e64
Compare
JakubKorytko
approved these changes
Sep 29, 2026
JakubKorytko
left a comment
JakubKorytko
left a comment
Member
There was a problem hiding this comment.
Tested on iOS and Android (release builds, RN 0.81), linked and unlinked.
Linked: behavior unchanged on both platforms.
Unlinked on iOS: main resolves addCardToAppleWallet to 'error' silently, this PR rejects with the linking error as intended.
Note that on iOS the library currently crashes when unlinked (new NativeEventEmitter() requires a non-null argument), so this only takes effect together with #67. Android is unaffected (addCardToAppleWallet rejects as not available). LGTM.
Member
|
thanks! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.