chore(config): migrate APM stats encoder to typed configuration - #2266
Conversation
Binary Size Analysis (Agent Data Plane)Baseline: c07a446 · Comparison: 1abf698 · diff ✅ Binary size difference within thresholdChanges by Module
Detailed Symbol Changes |
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (5)Experiments configured
Bounds Checks: ✅ Passed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
There was a problem hiding this comment.
More details
The typed migration preserves the effective APM stats environment, shared flush timeout, zero-timeout 10 ms floor, and MessagePack metadata path; no diff-only behavioral regression was identified. The focused Rust tests and checks could not execute because the sandbox cannot fetch the uncached hyper-http-proxy git dependency.
🤖 Datadog Autotest · Commit 216cf33 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
2e72291 to
197bef2
Compare
There was a problem hiding this comment.
More details
The typed cutover preserves peer-tag controls, fallback environments, hostname enrichment, and encoder flush timing through the existing source-to-model paths. Local behavioral execution was blocked by unavailable pinned Rust and Git dependencies, so confidence rests on direct parity inspection.
🤖 Datadog Autotest · Commit 4109999 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
## Summary Migrate the Datadog APM Stats encoder to typed traces and shared configuration. The encoder now receives the resolved environment and flush timeout directly, while raw deserialization and legacy smoke-test ownership are removed. ## Change Type - [x] Non-functional (chore, refactoring, docs) ## How did you test this PR? - `make fmt` - `make check-docs` - `make check-clippy` - `make check-all` - `cargo check -p saluki-components -p agent-data-plane -p datadog-agent-config-overlay-model --tests` ## References - Progresses #2169 - Progresses #2193 ff0b440

Summary
Migrate the Datadog APM Stats encoder to typed traces and shared configuration. The encoder now receives the resolved environment and flush timeout directly, while raw deserialization and legacy smoke-test ownership are removed.
Change Type
How did you test this PR?
make fmtmake check-docsmake check-clippymake check-allcargo check -p saluki-components -p agent-data-plane -p datadog-agent-config-overlay-model --testsReferences