chore(config): migrate APM stats transform to typed config - #2265
Conversation
Binary Size Analysis (Agent Data Plane)Baseline: 14fb28f · Comparison: 8db85b8 · diff ✅ Binary size difference within thresholdChanges by Module
Detailed Symbol Changes |
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (5)Experiments configured
Bounds Checks: ✅ Passed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
62ba99f to
68de52c
Compare
There was a problem hiding this comment.
More details
The migration preserves the APM Stats inputs: resolved Datadog defaults keep span-kind computation and peer-tag aggregation enabled, explicit false values propagate, and environment/hostname fallback behavior is equivalent. Runtime execution was unavailable because the sandbox could not fetch the uncached hyper-http-proxy dependency, so confidence is based on the diff and configuration translation paths.
🤖 Datadog Autotest · Commit 68de52c · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
0c58809 to
7f36fef
Compare
d8f4844 to
ef23127
Compare
2e72291 to
197bef2
Compare
ce847d7 to
dead4ad
Compare
lucastemb
left a comment
There was a problem hiding this comment.
Looks good. Definitely think it's much cleaner now 👍
There was a problem hiding this comment.
More details
The typed stats path preserves the legacy true defaults, peer-tag and environment values, and environment-provider hostname fallback. The apparent OTTL changes are byte-identical to the base branch and merge cleanly.
🤖 Datadog Autotest · Commit 5d63aca · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
## Summary Migrate the APM Stats transform to the resolved typed traces configuration. The transform now receives typed stats, peer-tag, environment, and hostname inputs, and the legacy APM configuration adapter is removed. ## Change Type - [x] Non-functional (chore, refactoring, docs) ## How did you test this PR? - `make fmt` - `make check-docs` - `make check-clippy` - `make check-all` - APM Stats tests: 38 passed - `cargo check -p saluki-components -p agent-data-plane --tests` ## References - Progresses #2169 - Progresses #2193 c07a446

Summary
Migrate the APM Stats transform to the resolved typed traces configuration. The transform now receives typed stats, peer-tag, environment, and hostname inputs, and the legacy APM configuration adapter is removed.
Change Type
How did you test this PR?
make fmtmake check-docsmake check-clippymake check-allcargo check -p saluki-components -p agent-data-plane --testsReferences