chore(config): migrate OTTL transform to typed configuration - #2263
Conversation
Binary Size Analysis (Agent Data Plane)Baseline: 2ce0908 · Comparison: fff36a0 · diff ✅ Binary size difference within thresholdChanges by Module
Detailed Symbol Changes |
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (5)Experiments configured
Bounds Checks: ❌ Failed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
055b852 to
1005c62
Compare
There was a problem hiding this comment.
More details
The migration consistently routes OTTL transform settings through the typed traces configuration, whose loader tests cover defaults, valid modes, invalid modes, unknown fields, file translation, and environment transport. No diff-only behavioral regression was found; focused Rust execution could not start because the sandbox could not fetch the pinned git dependency.
🤖 Datadog Autotest · Commit 0cb1e76 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
fedf507 to
dad25ce
Compare
d8f4844 to
ef23127
Compare
ae32e61 to
5e2ad06
Compare
There was a problem hiding this comment.
Ignore this: LGTM. Only thing is I believe we no longer I just realized that this was addressed by the previous PR. I reviewed it from newest -> oldest. 😓deny_unknown_fields. If that's something we care about preserving, we would need to update the SalukiOnly::OttlTransformConfig to contain that.
There was a problem hiding this comment.
More details
Production-shaped OTTL filter and transform YAML preserved statement ordering, error modes, defaults, and malformed-input rejection through the typed configuration boundary.
📊 Validated against 8 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 5a5aeaa · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
## Summary Migrate the OTTL span transform processor to the typed traces configuration. The processor now receives typed error-mode and transform-statement values, and its raw configuration adapter is removed. ## Change Type - [x] Non-functional (chore, refactoring, docs) ## How did you test this PR? - `make fmt` - `make check-docs` - `make check-clippy` - `make check-all` - OTTL transform tests: 24 passed - `cargo check -p agent-data-plane --tests` ## References - Progresses #2169 - Progresses #2193 14fb28f

Summary
Migrate the OTTL span transform processor to the typed traces configuration. The processor now receives typed error-mode and transform-statement values, and its raw configuration adapter is removed.
Change Type
How did you test this PR?
make fmtmake check-docsmake check-clippymake check-allcargo check -p agent-data-plane --testsReferences