feat(workspace): guide tonight's first bridge on map and player - #946
Draft
seonghobae wants to merge 1 commit into
Draft
feat(workspace): guide tonight's first bridge on map and player#946seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
Name the earliest labeled bridge so the room can open the turn on the map or hear it from the player. Fail closed on intro, verse, pre-chorus, chorus, outro, tag, pickup, stop, and handoff labels, and keep Hear behind a real seek callback.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product outcome
Name tonight's first labeled bridge so the room can catch the turn. The workspace action opens the matching map section. The player exposes Hear only when its owning playback surface supplies a seek callback.
Design authority: workspace next-action pattern in
docs/design-system/component-contract.md. Distinct from intro #943, chorus #939, pickup #916, stop #934, and labeled handoff #937.Exact current identity
develop@acdbea6344fe1231c39535b575f4de35e4c607c9.4d13986d.feat/workspace-first-bridge-turn.Delivered contract
resolveFirstBridgeselects the earliest labeledbridgewith a bounded positive-length rehearsal window.intro,verse,pre-chorus,chorus,outro,tag,pickup,stop, andhandoff.Openscrolls the renderer-owned song-structure cell. Reduced motion usesbehavior: "auto".Hearruns only whenonPlayFromSecondsexists and receives the exact bridge second.Security Notes
autoscroll, callback-only Hear gating, player sparse/malformed section summaries, and Korean form-label localization.Dependency ownership
Canonical JavaScript dependency-security owner remains #783. This branch has no lockfile, PDF.js, Nanoid, Undici, or vulnerability-suppression delta. Inherited npm HIGH findings must not be suppressed here.
Merge gate
Keep Draft until one unchanged resulting exact head has repository CI/build/release/security/SAST/SBOM/supply-chain gates terminal-success, exact required owned coverage, fresh central coverage/OpenCode/Noema/Strix evidence, zero valid unresolved findings, a qualifying independent non-author last-push approval, and ordinary protected-branch acceptance without bypass.
Queued, pending, skipped-required, cancelled, failed, predecessor-head, protected-base, self/author, model-only, or administrative-bypass evidence is non-passing. Do not self-approve.