Add co-president letterhead PDF exports - #134
Merged
Merged
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
approverOnly+requireApproveron every route). PDFs on the club letterhead are built on demand and never stored. Downloads are rate limited and sent withno-store.lib/documents/letterhead.ts, shared with the templates. The template PDFs are byte-identical after the refactor.Checklist
npm run typecheck,npm run lint,npm run format:checkandnpm run buildpassnpm run db:generate) — none.env.example,.env.local.example,deploy/docker-compose.ymlandkomodo/deploy-context.mjs— nonerequireAdmin/requireApproverTesting Evidence
Samples below are rendered from fake data through the real report code.
The Access Request sample includes a fake exec missing an access card. They're left out of the table and the signature names; only the Exports page names them.