Skip to content

winterm: some refactoring and cleaning up - #28

Open
Sebastiaan van Stijn (thaJeztah) wants to merge 3 commits into
Azure:masterfrom
thaJeztah:refactor_and_linting
Open

Sebastiaan van Stijn (thaJeztah) wants to merge 3 commits into
Azure:masterfrom
thaJeztah:refactor_and_linting

Conversation

@thaJeztah

Copy link
Copy Markdown
Contributor

Tried to group changes in logical commits for easier review

John Starks (@jstarks) Kevin Parsons (@kevpar) ptal 🤗

@dolmen

Copy link
Copy Markdown

Please move the first 3 commits in a separate PR as they can be merged instantly. The later about winterm require more domain knowledge so its bad to have the first 3 blocked.

@thaJeztah Sebastiaan van Stijn (thaJeztah) changed the title Fix various linting issues, some refactoring and cleaning up winterm: some refactoring and cleaning up Jul 3, 2023
@thaJeztah

Copy link
Copy Markdown
Contributor Author

makes sense; moved the first 3 commits to #39

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants