Repository navigation
winterm: some refactoring and cleaning up - #28
Open
Sebastiaan van Stijn (thaJeztah) wants to merge 3 commits into
Open
Sebastiaan van Stijn (thaJeztah) wants to merge 3 commits into
Sebastiaan van Stijn (thaJeztah) wants to merge 3 commits into
Conversation
|
Please move the first 3 commits in a separate PR as they can be merged instantly. The later about winterm require more domain knowledge so its bad to have the first 3 blocked. |
Contributor
Author
|
makes sense; moved the first 3 commits to #39 |
Sebastiaan van Stijn (thaJeztah)
force-pushed
the
refactor_and_linting
branch
from
July 3, 2023 14:33
4eb94b0 to
e9eb7f9
Compare
This was referenced Oct 6, 2026
Sebastiaan van Stijn (thaJeztah)
force-pushed
the
refactor_and_linting
branch
from
October 6, 2026 22:06
e9eb7f9 to
2c7f73c
Compare
Sebastiaan van Stijn (thaJeztah)
marked this pull request as draft
October 7, 2026 12:34
Sebastiaan van Stijn (thaJeztah)
force-pushed
the
refactor_and_linting
branch
2 times, most recently
from
October 13, 2026 17:37
f19ddc7 to
5d4309e
Compare
Sebastiaan van Stijn (thaJeztah)
marked this pull request as ready for review
October 13, 2026 17:37
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sebastiaan van Stijn (thaJeztah)
force-pushed
the
refactor_and_linting
branch
from
October 13, 2026 20:56
5d4309e to
88e5961
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried to group changes in logical commits for easier review
John Starks (@jstarks) Kevin Parsons (@kevpar) ptal 🤗