Repository navigation
winterm: deprecate types and funcs for golang.org/x/sys - #56
Draft
Sebastiaan van Stijn (thaJeztah) wants to merge 7 commits into
Draft
Sebastiaan van Stijn (thaJeztah) wants to merge 7 commits into
Sebastiaan van Stijn (thaJeztah) wants to merge 7 commits into
Conversation
Remove the unused String methods from CONSOLE_SCREEN_BUFFER_INFO, COORD, and SMALL_RECT. These methods were introduced in the initial commit ([go-ansiterm@8b62c38]), apparently for debugging purposes, but are not used by the package itself and I was not able to find any external uses that depended on this. This makes the types identical to their counterparts in golang.org/x/sys/windows, allowing them to be replaced with type aliases and subsequently deprecated. [go-ansiterm@8b62c38]: Azure@8b62c38 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This deprecates various types and functions that are now provided by golang.org/x/sys/windows; Types: - CONSOLE_SCREEN_BUFFER_INFO -> windows.ConsoleScreenBufferInfo - COORD -> windows.Coord - SMALL_RECT -> windows.SmallRect Functions: - SetConsoleCursorPosition -> windows.SetConsoleCursorPosition - GetConsoleMode -> windows.GetConsoleMode - SetConsoleMode -> windows.SetConsoleMode - GetConsoleScreenBufferInfo -> windows.GetConsoleScreenBufferInfo Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sebastiaan van Stijn (thaJeztah)
force-pushed
the
deprecate_aliases
branch
from
October 13, 2026 22:04
322868d to
83aabaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
winterm: remove uses of type-aliases
winterm: deprecate types and funcs for golang.org/x/sys
This deprecates various types and functions that are now provided
by golang.org/x/sys/windows;
Types:
Functions: