Skip to content

winterm: reduce code duplication in cursor-helpers - #49

Merged
Brian Goff (cpuguy83) merged 1 commit into
Azure:masterfrom
thaJeztah:cursor_helpers_dry
Oct 13, 2026
Merged

Brian Goff (cpuguy83) merged 1 commit into
Azure:masterfrom
thaJeztah:cursor_helpers_dry

Conversation

@thaJeztah

Copy link
Copy Markdown
Contributor

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The refactor preserves existing cursor behavior while removing duplicated code.

0 open findings

What changed in this PR

Refactors Windows terminal cursor helpers to share movement logic and reduce duplication.

Changes:

  • Adds line and column cursor movement modes.
  • Delegates line and column helpers to moveCursor.
File Description
winterm/​cursor_helpers.go Consolidates cursor-positioning logic.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@cpuguy83
Brian Goff (cpuguy83) merged commit a6d5cd6 into Azure:master Oct 13, 2026
5 checks passed
@thaJeztah
Sebastiaan van Stijn (thaJeztah) deleted the cursor_helpers_dry branch October 13, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants