Repository navigation
winterm: reduce code duplication in cursor-helpers - #49
Merged
Merged
Conversation
Sebastiaan van Stijn (thaJeztah)
commented
Oct 6, 2026
Contributor
- relates to / part of winterm: some refactoring and cleaning up #28 (comment)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
There was a problem hiding this comment.
🟢 Approval recommended
The refactor preserves existing cursor behavior while removing duplicated code.
0 open findings
What changed in this PR
Refactors Windows terminal cursor helpers to share movement logic and reduce duplication.
Changes:
- Adds line and column cursor movement modes.
- Delegates line and column helpers to
moveCursor.
| File | Description |
|---|---|
winterm/cursor_helpers.go |
Consolidates cursor-positioning logic. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Brian Goff (cpuguy83)
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.