Repository navigation
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba5fa4b34d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - '.github/workflows/ci.yml' | ||
| pull_request: | ||
| branches: [ main, master ] | ||
| paths: |
There was a problem hiding this comment.
Preserve required CI checks for filtered pull requests
When any matrix check from this workflow is required by branch protection, a documentation-only PR matching none of these paths will never create that check, leaving the PR blocked in Pending rather than merely avoiding the expensive jobs. GitHub explicitly documents this behavior for workflow-level path filtering, so keep the workflow trigger unconditional and perform the path decision inside a lightweight job or expose a separate always-running required check. GitHub workflow syntax
Useful? React with 👍 / 👎.
Summary
Tightens the C++ build/test workflow trigger so the full six-job matrix only runs when a change can affect compilation, tests, examples, benchmarks, dependencies, or the workflow itself.
CI now runs for
include/**src/**tests/**benchmarks/**examples/**cmake/**CMakeLists.txtvcpkg.jsonvcpkg-configuration.json.github/workflows/ci.ymlThe same path filter is applied to both pushes to
main/masterand pull requests targeting those branches.CI no longer runs for documentation-only changes
Examples:
docs/**README.mdRationale
The current workflow executes Ubuntu, Windows, and macOS in both Debug and Release for every PR, including documentation-only changes. That consumes CI time without validating anything relevant to those changes. A positive path allowlist keeps the expensive build matrix tied to files that can actually affect the produced library or its verification targets.
Stacking
This PR is intentionally stacked on top of #17 (
refactor/src-layout) so its diff contains only.github/workflows/ci.yml. After #17 is merged, this PR should be retargeted tomainbefore merge.