Skip to content

🧪 Add missing boundary tests for validateRowId #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zknpr merged 2 commits into from
Jun 8, 2026
Merged

🧪 Add missing boundary tests for validateRowId #446

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edf5b54
test: add missing boundary tests for validateRowId
google-labs-jules[bot] Jun 8, 2026
75f9a0f
chore: revert stray package-lock version bump
zknpr Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions tests/unit/sql-utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,31 @@ describe('SQL Utils', () => {
assert.strictEqual(validateRowId(-12), -12);
});

it('should handle boundary integer values', () => {
assert.strictEqual(validateRowId(Number.MAX_SAFE_INTEGER), Number.MAX_SAFE_INTEGER);
assert.strictEqual(validateRowId(Number.MIN_SAFE_INTEGER), Number.MIN_SAFE_INTEGER);
assert.strictEqual(validateRowId(Number.MAX_SAFE_INTEGER.toString()), Number.MAX_SAFE_INTEGER);
assert.strictEqual(validateRowId(Number.MIN_SAFE_INTEGER.toString()), Number.MIN_SAFE_INTEGER);
});

it('should handle bigint values correctly', () => {
// @ts-ignore - testing BigInt fallback since JS allows it even if types don't
assert.strictEqual(validateRowId(9007199254740991n), 9007199254740991);
// @ts-ignore
assert.strictEqual(validateRowId(-9007199254740991n), -9007199254740991);
});

it('should evaluate empty or whitespace strings as 0', () => {
assert.strictEqual(validateRowId(''), 0);
assert.strictEqual(validateRowId(' '), 0);
});

it('should handle float and scientific notation strings', () => {
assert.strictEqual(validateRowId('123.45'), 123.45);
assert.strictEqual(validateRowId('1e3'), 1000);
assert.strictEqual(validateRowId('-1e3'), -1000);
});

it('should throw an error for non-numeric strings', () => {
assert.throws(() => validateRowId('abc'), /Invalid rowid: abc/);
assert.throws(() => validateRowId('12a'), /Invalid rowid: 12a/);
Expand Down
Loading