🧪 Add missing boundary tests for validateRowId#446
Conversation
Adds edge case coverage for `validateRowId` to verify its behavior with boundary integers (MAX/MIN_SAFE_INTEGER), bigints, empty/whitespace strings, and floating point formats.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…puts (#456) Reject blank/whitespace, fractional, scientific-notation, NaN/Infinity, unsafe-magnitude, and non-string/number/bigint inputs (null/boolean/array) that Number() would silently coerce into plausible-but-wrong rowids. Flips the #446 characterization tests to assert rejection; fixes two post-review test NITs (stale FakeEndpoint signature, tautological serializeDatabase assertion). Addresses the post-batch Codex review SHOULD-FIX + Gemini's high-priority type-coercion finding. CI green; CodeRabbit clean.
1 participant
🎯 What: Added missing boundary tests for the
validateRowIdutility function.📊 Coverage: Added tests for
Number.MAX_SAFE_INTEGER,Number.MIN_SAFE_INTEGER(as both strings and numbers),BigInthandling, empty/whitespace strings (evaluating to 0), and float/scientific notation strings.✨ Result: The
validateRowIdfunction now has comprehensive edge-case and type boundary testing, verifying its internal reliance on theNumber()constructor correctly handles extreme inputs.PR created automatically by Jules for task 13190189215291149278 started by @zknpr