Skip to content

Fix Windows Runner exactly-one primary recheck - #162

Merged
yyjeqhc merged 1 commit into
mainfrom
fix/windows-runner-primary-count
Aug 25, 2026
Merged

Fix Windows Runner exactly-one primary recheck#162
yyjeqhc merged 1 commit into
mainfrom
fix/windows-runner-primary-count

Conversation

@yyjeqhc

@yyjeqhc yyjeqhc commented Aug 25, 2026

Copy link
Copy Markdown
Owner

Summary

  • force array semantics for the final Windows Runner primary-count recheck so Windows PowerShell 5.1 does not scalar-unroll the healthy exactly-one result
  • add focused regression coverage in the existing Windows Runner readiness test

Validation

  • powershell.exe -NoProfile -NonInteractive -ExecutionPolicy Bypass -File scripts\test_windows_runner_readiness.ps1
  • git diff --check
  • cargo build --profile dogfood --bin webcodex-runner -p webcodex-runner
  • candidate identity: c40aa52734f2 / dirty=false

MSI dogfood

Real replacement completed successfully through the existing deployment helper:

  • old instance: 538bd437-ba03-4512-bf17-d8db14d33e62, build b46ece5ef747 / dirty=false
  • new instance: 7cdec7c3-687d-4826-9c70-abb291c6608c, build c40aa52734f2 / dirty=false
  • readiness: exact_fresh_build_ready
  • expected and observed build identities matched exactly
  • post-deployment lifecycle: Scheduled Task Running, RunLevel=Limited, exactly one primary Runner, zero unexpected primaries
  • temporary dogfood controller/task files were removed; the standard rollback binary was retained by the successful deployment helper

The bounded failure/rollback path was also exercised during the preceding #97 dogfood and proved a fresh rollback Runner before this fix was developed.

origin/main advanced during dogfood only by #161, whose changed files do not overlap these Windows scripts. This branch intentionally preserves the exact dogfooded commit rather than rewriting its history after validation.

Fixes #97

@yyjeqhc yyjeqhc added the run-ci Run the heavy pull-request CI jobs for an owner-authored PR label Aug 25, 2026
@yyjeqhc yyjeqhc removed the run-ci Run the heavy pull-request CI jobs for an owner-authored PR label Aug 25, 2026
@yyjeqhc
yyjeqhc force-pushed the fix/windows-runner-primary-count branch from c40aa52 to 4c51e1f Compare August 25, 2026 14:18
@yyjeqhc
yyjeqhc enabled auto-merge (squash) August 25, 2026 14:18
@yyjeqhc
yyjeqhc merged commit ea57a10 into main Aug 25, 2026
9 checks passed
@yyjeqhc
yyjeqhc deleted the fix/windows-runner-primary-count branch August 25, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Windows Runner lifecycle and deployment first-class

1 participant